X-Recipient: archive-cygwin AT delorie DOT com
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A73643860C38
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=dinwoodie.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=adam AT dinwoodie DOT org
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=dinwoodie.org; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=LohdzQk4BGva9Xtk9OHv8dCbqARRKiHwQq8wHEJUHUI=;
 b=lVH62U36Hgy2eBR0sbnvY+CPx54fz42u78VpebA34U2Oq6beuQvAh+3GFYWFPS9rxq
 J3jH5srNvyp0DVyXWMyxYDV1kQXf/l9QPPnk2BuIKai3do3OOScTI1fgYxEd47489b0D
 Zw5wPYHxlUwqlLOu9CySp1dwXXLZqSxUReWOU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=LohdzQk4BGva9Xtk9OHv8dCbqARRKiHwQq8wHEJUHUI=;
 b=n77YY3mgPHnibD8fj0uZSzTIrPO9q4SIquzsKYwuNBvM4lR3JKxQQRGHGkhe+TjMjh
 nVCBrL5Y3KI+5XtzdekjiiMBvQt9rLUQYqkCtlN2XF3OZiyU3IrJbIrfmZOECE08etI+
 WVgMr7368LPB3+0cuUII+ymQc8s9Uz6KxDbJoG09OshSVoWtVpr4NMw/LH8vrACtQlbE
 ijla++a/lHP5Rn25iI3gZyeQy/bWIcdjmm0uc/i0jMCmrCVD7WLQI6td8zckwT8s8/mh
 u1DT/1kPQvSlsE07z22hxDdiP3ay58fpkOmwZGDlmfRk5TEzFp4eP0q/SjcJ4VMZ/OGs
 PmlQ==
X-Gm-Message-State: AOAM532JiuMqVGidUrB1T2JkXfumaJI6TGk/SwCQB2KP0F1cIXATXKYs
 7XHg9xByCbO9X44rvfse1F26jl0d58Uhz4GRc6TR9Mo1Fk/SAw==
X-Google-Smtp-Source: ABdhPJyt2Q0tFUDWn7JHkujg2yJ0FdBEChb+hls0KplK63V0/I7SY4cQpkD+V8j11ANqGEfkeB9qTYH6SPkGJI5cq5k=
X-Received: by 2002:ab0:624d:: with SMTP id p13mr22342674uao.136.1597145268825; 
 Tue, 11 Aug 2020 04:27:48 -0700 (PDT)
MIME-Version: 1.0
References: <announce DOT c4e534c5-4c2e-9c35-3674-5f652695d778 AT SystematicSw DOT ab DOT ca>
 <CA+kUOa=-AJxr_2TaZoNerOquMGR8FCzi7hg3DyuvntuQqpAVOg AT mail DOT gmail DOT com>
 <CA+kUOakEVPde-W_8jocGZBwNw=wRodKBySRgxAE7_AU8As7FDA AT mail DOT gmail DOT com>
 <4f1d6241-c86b-f2f9-7b49-a9f5b998b0eb AT SystematicSw DOT ab DOT ca>
 <53c7f2a7-3bd8-f90c-b574-969d6b31f300 AT cornell DOT edu>
 <b66aea8b-2764-357c-8602-0a2e780bc90f AT SystematicSw DOT ab DOT ca>
 <d66364d2-06c4-3f8e-4989-2426ec9fde9d AT cornell DOT edu>
 <71031f78-b1be-aec2-4e54-72ff49e07543 AT SystematicSw DOT ab DOT ca>
 <11d99d00-55fb-f6a2-893d-f5ebb6e7a14b AT cornell DOT edu>
In-Reply-To: <11d99d00-55fb-f6a2-893d-f5ebb6e7a14b@cornell.edu>
From: Adam Dinwoodie <adam AT dinwoodie DOT org>
Date: Tue, 11 Aug 2020 12:27:12 +0100
Message-ID: <CA+kUOakP-dfBOfMJ+HrN2cfUfmzWOidO08ios+7kBCbmP+Yo6A@mail.gmail.com>
Subject: Re: [ANNOUNCEMENT] Updated: curl 7.71.1-1
To: cygwin AT cygwin DOT com
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces AT cygwin DOT com>

On Tue, 11 Aug 2020 at 12:14, Ken Brown via Cygwin wrote:
> > In that case, it looks to me as if the generated curl-config --libs statements:
> >
> >          if test "Xyes" = "Xno" -o "Xyes" = "Xyes"; then
> >            echo ${CURLLIBDIR}-lcurl -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto
> > -lldap -llber -lbrotlidec -lbrotlidec -lz
> >
> > based on curl-config.in:
> >
> >          if test "X AT ENABLE_SHARED@" = "Xno" -o "X AT REQUIRE_LIB_DEPS@" = "Xyes"; then
> >            echo ${CURLLIBDIR}-lcurl @LIBCURL_LIBS@
> >
> > REQUIRE_LIB_DEPS should be no, derived from configure.ac:
> >
> > if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" = "Xno"
> > then
> >      REQUIRE_LIB_DEPS=no
> > else
> >      REQUIRE_LIB_DEPS=yes
> > fi
> > AC_SUBST(REQUIRE_LIB_DEPS)
> > AM_CONDITIONAL(USE_EXPLICIT_LIB_DEPS, test x$REQUIRE_LIB_DEPS = xyes)
> >
> > but for Cygwin link_all_deplibs remains defaulted to unknown, so either that
> > variable should be set in configure, or that condition should perhaps be changed
> > to:
> >
> > if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" != "Xyes"
> >
> > with appropriate bug reports and changes to be made upstream if possible.
>
> If you want to look into ways of fixing curl-config different from what Yaakov
> did, that's fine; you're the maintainer.  All I did was look at Yaakov's patch
> and port it to curl 7.71.1, that being a quick and easy way to fix the reported
> problem.

Someone else did raise this problem upstream at
https://github.com/curl/curl/issues/5793, and the comments there imply
they'd be interested in integrating patches Cygwin uses into the
upstream code, although the upstream maintainers aren't going to do
that without someone proactively submitting the patch to them.

For my part, I'm not particularly fussed whether this is fixed with an
upstream patch or a Cygwin patch; I just want my use cases to work,
and as of 7.71.1-1 they don't. That said, my experience of being a
package maintainer would lead me to want to submit patches upstream if
at all possible, just to reduce the need to handle these sorts of
problems. My inclination would be to restore the patched behaviour
with Ken's new patch as a short-term fix, then get this submitted
upstream so that in the long-term this patch can be retired.
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple