X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4204B388CC2E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1596129462;
	bh=xlrCBCLxu7oaielBli0QSQCW1RZL8TG/Mk8E6WIAPp8=;
	h=Date:From:To:Subject:References:In-Reply-To:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 Reply-To:Cc:From;
	b=qDNw+v2mkxLDN3hvrBsDj1JYce4VmguhZE4MaUWfO3ZKdiwh7HsCDZ/3zTglwgs5M
	 oGokPbl1ufCC54iZIRYG8dHCp11uvBEN1fuQuNsXop/3AjJh5gD5lKRggIs760YsBK
	 2QugD3RIhUrlYqz9j0GB300ALgK+Kg1bLMHkiLtU=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 67940382E071
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=cygwin.com
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=corinna-cygwin AT cygwin DOT com
Date: Thu, 30 Jul 2020 19:17:23 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: Ken Brown <kbrown AT cornell DOT edu>
Subject: Re: Synchronization problem with posix_spawn
Message-ID: <20200730171723.GA460314@calimero.vinschen.de>
Mail-Followup-To: Ken Brown <kbrown AT cornell DOT edu>, cygwin AT cygwin DOT com
References: <b1992e8b-d2e8-9c44-8f93-a270d5a879ed AT cornell DOT edu>
 <864b3031-9fc8-beb3-ba7c-1ade4c31a288 AT cornell DOT edu>
 <20200730115913 DOT GL4206 AT calimero DOT vinschen DOT de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20200730115913.GL4206@calimero.vinschen.de>
X-Provags-ID: V03:K1:NWag13+1iYa9oN9J10Z+4nm62nRaN4XLaxSkCZXfbp6EbEHrSID
 3P02HBacBf3JU6TNdP5f3D4LzRqFiCp7yFXPm5sAV7SJ6XSFTOAiPriq/gkmTPTL1Io8Hy2
 zy16/O7TMg4N/Q23pBzIgLTYwQS/LWndbF8acRL8cPubUg4VGPhhnPqo35z6B3gVO/OWlXQ
 crp4Pf0IaeiXEavaPl4/g==
X-UI-Out-Filterresults: notjunk:1;V03:K0:DKDh+X6NBN8=:pYgSBjv9L1oGx7PDK3/qSG
 LQTmO8Tz9U0VgnndWIWA2IY2KsZLURFap89G00TXjtIqxsQvHNVrfgAqSQRBQfn1S5masOpye
 0egY8dX0t2oRNOHMtMahHMt9PylIDD+1s1GxlI9sBmX9pjnRw9HZGSWzdhinNJv15F7O9//59
 IYCXWN7oisLlVMpC1b6cltK7t1KRnAriW85wbvA1lvWFT7u5y/mARO2ojapKZua3gE/36SNON
 yGpVfWzFPUFnoO0+nmaEl5gvAmUDp6TQ87A/LLNCXaUWgHrqAI6fE9RCEe7QvNQTU4LGT+Zr+
 ShnNhRqx5Noox9vpwFQXmPxhOAgX/2ojmfQowi8wCqfoaC9kO66UveVvk0hhZEfVQBeQs89dd
 nRdxVMQwoaM+5Ss0OZwXP0lzBwZ94w12DZPR9H5f6RY/492A+ncGihkuPkSdNHhIHHrp/iahO
 gIEmuuJo0DaaPY7xfcLPSUrTrHLbJ1IHZXhyi3GTFDar40VfziiCjWUZtt/1wsQgq0gmTnZl6
 WwrYFW04fxrqr8qcyeIyRyrNOzRHr/xhjLUMkAzKq7zr1DtXFHDbUA9CDfrMQZ7K2nB7jCdP1
 N+O81YVDzkrXs2Lev8JLu7D5812ihiWvYyCQZvZf0oj3yyZPyFzWBErY6/n2bWYrUUrkMuX2V
 ijiEfweDHKOuBEpqYNjKyk4jZ2vf8O+bHJdAdjaAeDH4Zj9wZgR3W7kSyb9ymEe8Q88ZTVyzP
 d8/jdf1jPXd3NjJjYBzNg1OjfV/6eq3CuVVa0uAC21+F4SBG3JA3HDYuG5/GVU0lpxGQHoFO4
 iZF5d1HTFh3sapLFu3uQOr65DkYTqiz295YT4cFNeruYli+B+xUsE026LGr82ew/fdnV6C2EQ
 Q8jBSxIT0T9LBqpWkVX7O2/M5eR8L65IT9GJ9h21SaL6ogz4DlVpUKgQDqUP9hgCJBY1dQeIj
 wzQUNihgyvH4evW8iwC65HuUSFKwi79B1Y4rX9zwgDPYlTtUnMDt1R5wI5zAvpHQi5CNg24d8
 VQTbI4wqnnRJ3CWh/bUiyILJEmHGnhqWSP8MqMpTWQ5xbWaT5ssOOZu1Cro554zpkDr1JygqS
 +1rsAk3IG15g5dShXB/7WT6ur9RaQp6R5oywMEW0uQNcT/wrN+AqOpjSduphac9uBWuPU6C16
 kdiQdAp9qHn+o678rcmIOkCG+Q7Q0MWdY/NCF/k+DTqokeWV4coappIJ0qjAHMoa7dv/o=
X-Spam-Status: No, score=-104.7 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To: cygwin AT cygwin DOT com
Cc: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="utf-8"
Errors-To: cygwin-bounces AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 06UHI7ge009189

Hi Ken,

On Jul 30 13:59, Corinna Vinschen wrote:
> On Jul 29 19:12, Ken Brown via Cygwin wrote:
> > On 7/29/2020 4:17 PM, Ken Brown via Cygwin wrote:
> > > posix_spawn(p) returns before the spawned process is fully up and
> > > running.  [...]
> > I just took a look at the source, and I see that posix_spawn was taken from
> > FreeBSD.  Does FreeBSD have the same problem?  Should applications just be
> > aware of this issue and insert a sleep after posix_spawn before sending
> > signals?
> 
> Actually, this is a Cygwin problem.  I just had a look into the
> newlib implementation myself, and it turns out that the code,
> in particular the do_posix_spawn() function, is BSD specific.  It
> relies on the BSD implementation of vfork(2).  Cygwin's vfork(2)
> on the other hand, is NOT following the historic idea of the
> BSD vfork(2), rather it's equivalent to fork(2).  This is
> POSIX compliant, but certainly the reliance of the BSD vfork
> behaviour makes do_posix_spawn() as it's implemented right now,
> not overly functional for Cygwin.
> 
> IOW, we need a Cygwin-specific do_posix_spawn() using fork(2)
> in conjunction with some synchronization the BSD function
> gets "for free" by using its specific vfork(2).

Below is a POC implementation for a Cygwin-specific do_posix_spawn().
If this does the trick (at least your testcase works in my testing),
then I'm planning to move the function over to the winsup/cygwin dir
so it can be streamlined further.

Can you give it a try?


Thanks,
Corinna


diff --git a/newlib/libc/posix/posix_spawn.c b/newlib/libc/posix/posix_spawn.c
index 19c5cd0fe986..3adbac29d7fd 100644
--- a/newlib/libc/posix/posix_spawn.c
+++ b/newlib/libc/posix/posix_spawn.c
@@ -254,6 +254,82 @@ process_file_actions(const posix_spawn_file_actions_t fa)
 	return (0);
 }
 
+#ifdef __CYGWIN__
+#include <windows.h>
+#include <sys/mman.h>
+#include <process.h>
+
+typedef struct
+{
+  pid_t pid;
+  int error;
+} child_info;
+
+static int
+do_posix_spawn(pid_t *pid, const char *path,
+	const posix_spawn_file_actions_t *fa,
+	const posix_spawnattr_t *sa,
+	char * const argv[], char * const envp[], int use_env_path)
+{
+	pid_t p;
+	int ret = 0;
+	child_info *ci;
+
+	ci = (child_info *) mmap(NULL, sizeof(child_info),
+				 PROT_READ | PROT_WRITE,
+				 MAP_SHARED | MAP_ANONYMOUS, -1, 0);
+	if (ci == MAP_FAILED)
+		return (errno);
+
+	/* Cygwin's vfork does not follow BSD vfork semantics.  Rather it's
+	   equivalent to fork.  While that's POSIX compliant, it means the
+	   below FreeBSD implementation relying on BSD vfork semantics
+	   doesn't work as expected on Cygwin. */
+	p = fork();
+	switch (p) {
+	case -1:
+		ret = errno;
+		break;
+	case 0:
+		if (sa != NULL) {
+			ci->error = process_spawnattr(*sa);
+			if (ci->error)
+				_exit(127);
+		}
+		if (fa != NULL) {
+			ci->error = process_file_actions(*fa);
+			if (ci->error)
+				_exit(127);
+		}
+		if (use_env_path)
+			p = spawnvpe(_P_NOWAITO, path,
+				     (const char * const *) argv,
+				     (const char * const *)
+				     (envp != NULL ? envp : *p_environ));
+		else
+			p = spawnve(_P_NOWAITO, path,
+				    (const char * const *) argv,
+				    (const char * const *)
+				    (envp != NULL ? envp : *p_environ));
+		if (p < 0) {
+			ci->error = errno;
+			_exit(127);
+		}
+		ci->pid = p;
+		_exit (0);
+	default:
+		if (waitpid(p, NULL, 0) < 0)
+			ret = errno;
+		else if (ci->error)
+			ret = ci->error;
+		else if (pid != NULL)
+			*pid = ci->pid;
+		break;
+	}
+	munmap(ci, sizeof(child_info));
+	return ret;
+}
+#else
 static int
 do_posix_spawn(pid_t *pid, const char *path,
 	const posix_spawn_file_actions_t *fa,
@@ -292,6 +368,7 @@ do_posix_spawn(pid_t *pid, const char *path,
 		return (error);
 	}
 }
+#endif
 
 int
 posix_spawn (pid_t *pid,

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple