X-Recipient: archive-cygwin AT delorie DOT com DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7A1B3850410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1595231769; bh=y4i9v25JwoyfmEbUg0l61yFlR15CbI9reJ6xQpM5Ass=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:Cc:From; b=eD7M6TC+zcZ7o+oRNWyFoGVM1puJlljDkwG5zO1W6UEFiizu1QVxOD3BPXCwdNbfd vUvwPly+hSyFW9/Xnvf1XT5DD2+PxyjH5BkUPVn19yRcezy2cBlgNqw1FBJOjTjgGF Fn9Ot3/gWuATkaxoWsgCacBwuIo8GJGoNw6ZZcuY= X-Original-To: cygwin AT cygwin DOT com Delivered-To: cygwin AT cygwin DOT com DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 914023851C3D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=corinna-cygwin AT cygwin DOT com Date: Mon, 20 Jul 2020 09:55:58 +0200 From: Corinna Vinschen To: Marc Hoersken Subject: Re: [PATCH] Fix poll/select signal socket as write ready on connect failure Message-ID: <20200720075558.GD16360@calimero.vinschen.de> Mail-Followup-To: Marc Hoersken , cygwin AT cygwin DOT com References: <20200716092553 DOT GA3784 AT calimero DOT vinschen DOT de> <8092a464-53a1-b74a-04f1-4d95a242c2b3 AT marc-hoersken DOT de> <20200717192140 DOT GC16360 AT calimero DOT vinschen DOT de> <7ec397c4-dc25-407c-7925-d61382e80f8a AT marc-hoersken DOT de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ec397c4-dc25-407c-7925-d61382e80f8a@marc-hoersken.de> X-Provags-ID: V03:K1:+b8MjETIr5UPRWhPzq9LGtBjuDRUoUSrhPxpCZoTWc+69zAZq4o JAVDLNIGpmn3yrm6RJtKBqTw96I8x3D3F9CLm+kgeJ5NrF7+L/RjH6nOF69kyJ5z2FPzeC7 KGsaF/XeqnOQhvuV3pEhmfwCdJYfuRTvPFa2aKSfDbEijJutQhnd2j+3TrbpvhJ72S09TGv kwSk85RyxYJ4wvi2NfAOg== X-UI-Out-Filterresults: notjunk:1;V03:K0:/HH42YO/xHA=:3km5aoDaCSLy67jx+XRS/X o8L4a9lFoU3Vt4QfBvocwzmoKnhOVdtfNHfzfS1B1AVFmNu76PrZpvExQRBEOHNOoHhFGZWEL TjBH36dPNFfP7GPd734eVjpMXipzK85IOANEMQp3aeuatJNQlsBvo7a4XbDg5ntSDsDCG6HZ5 9CEswZPC1S2mskPPkD5XyzIMfSNPH2zkkbMjE/G/zVWsdKF40vNbH4zt9oZyYIzSHd92mfkub WdWD7VggofQib0YNcsBsfLxoszZduOnc0UhgLxbB9lxiMb7+faIQEzyAHj30VE8FChyz9gcGj STNDdJhXm+TfUSoFzgWLW4HAc5MsWGcSXYcomMR+TFPc9MVRjyXNYNLhahBGnbpDOHHspzOUT copY5pGls37/qIF3nTRTUsdRCH0nlYGb9mR0TelnqSvzXEYg0qCsN058n8IP5Q0FtDgbCVZ9a W9dpbTBxIZXd4t7RZxz8MX1+SeyLH7hgNIoaB+4cvkg6DPOQUFMUoxyldosuOuu2q0VPwIMcB z0WCFXsyMCpg5IQGkOd3lxeaB0MXLHuWwJM1zWzhx3M7p/9Gy/d8X6WO3u51DPQGc6e1+Kayr 4Bp7VIYIHTWugUH+yMR6taL6UGUwDybEEtZT7zQNnR1WVgT9ZezO20UoaouQykMeuYwA75zHy YfvIgHMoYSXB+B2sw1EPanYdU99iRY7icKlp4zzp39xDbbS9NL/IdZ/bxv/CMttQwLq6Ll/5o RJw/1FCykOwqXgnNCny4ZRfGsOnGCsR0hxhY/wbnzQ2bN/pn/GrcIO6UpRLLEQwiBkSj27b9S mjZnIsE8bGBpRpI7lnagl1n2U0BjDVoKit1mXsLAiQJxTUgnHvYgDrOntOvDJwa9Xg2HGcMpM KT6xJq2GL5EdQTH5dfqA== X-Spam-Status: No, score=-99.1 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin AT cygwin DOT com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cygwin AT cygwin DOT com Cc: cygwin AT cygwin DOT com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: cygwin-bounces AT cygwin DOT com Sender: "Cygwin" On Jul 17 21:33, Marc Hoersken via Cygwin wrote: > Hi Corinna, > > Am 17.07.2020 um 21:21 schrieb Corinna Vinschen: > > I don't agree here. The sole purpose for connect_errorcode is to set > > SOL_SOCKET/SO_ERROR in case a caller requests FD_CONNECT and FD_CONNECT > > is available. After being set once, SOL_SOCKET/SO_ERROR should not be > > rewritten, given the description of SO_ERROR in `man 7 socket': > > > > SO_ERROR > > Get and clear the pending socket error. This socket option is > > ^^^^^^^^^ > > read-only. Expects an integer. > > > > [...] > > > > Make sense? > > > yes, this makes sense. Please go for it. Great, done! > Is there a public changelog I can check regulary to see if this has been > released (once it is)? Thanks! git log? Or do you mean official Cygwin releases? The only public changelog is the announcement on cygwin-announce in this case. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple