X-Recipient: archive-cygwin AT delorie DOT com
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5655E384240C
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=dronecode.org.uk
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=jon DOT turney AT dronecode DOT org DOT uk
Authentication-Results: btinternet.com;
 auth=pass (PLAIN) smtp.auth=jonturney AT btinternet DOT com
X-Originating-IP: [31.51.206.31]
X-OWM-Source-IP: 31.51.206.31 (GB)
X-OWM-Env-Sender: jonturney AT btinternet DOT com
X-VadeSecure-score: verdict=clean score=0/300, class=clean
X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdeikecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepgfevledvjeffudfhvdehhfdutddthffhffeuvdeuuedtvdfgveeuhfduvefhuddvnecuffhomhgrihhnpegthihgfihinhdrtghomhdpfihikhhiphgvughirgdrohhrghenucfkphepfedurdehuddrvddtiedrfedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurdduuddungdpihhnvghtpeefuddrhedurddvtdeirdefuddpmhgrihhlfhhrohhmpeeojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhequceuqfffjgepkeeukffvoffkoffgpdhrtghpthhtohepoegthihgfihinhestgihghifihhnrdgtohhmqedprhgtphhtthhopeeomhgrrhgtohdrrghtiigvrhhisehgmhgrihhlrdgtohhmqe
X-RazorGate-Vade-Verdict: clean 0
X-RazorGate-Vade-Classification: clean
Subject: Re: Cygwin package search and cygcheck -p urlencoding still broken on
 new web server
To: The Cygwin Mailing List <cygwin AT cygwin DOT com>
References: <f78e2eaf-07d6-a9bd-ee84-e6414131b23b AT gmail DOT com>
 <9c03bed5-da26-512c-3c31-ed6cd59f8043 AT SystematicSw DOT ab DOT ca>
 <f6e7d3b9-eef8-5991-59f8-905db3a8fc53 AT gmail DOT com>
From: Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
Message-ID: <acc98a4e-68e5-d70e-6271-50c6f0dfb364@dronecode.org.uk>
Date: Thu, 16 Jul 2020 14:42:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f6e7d3b9-eef8-5991-59f8-905db3a8fc53@gmail.com>
Content-Language: en-GB
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, BODY_8BITS,
 FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <http://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <http://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 06GDhIn7028168

On 16/07/2020 08:44, Marco Atzeri via Cygwin wrote:
> On 16.07.2020 06:25, Brian Inglis wrote:
>> On 2020-07-15 14:13, Marco Atzeri via Cygwin wrote:
>>> Problem: I want to search for
>>>     libssh/libssh.h
>>> Using https://cygwin.com/packages/
>>> If I put the name and press Go the URL is changed in
>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh%2Flibssh.h&arch=x86_64 
>>>
>>> and the output is
>>>     Found 0 matches for libsshx2Flibssh.h
>>>                               ^^^
>>> Instead if I modify directly the URL in:
>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh/libssh.h&arch=x86_64 

I think that this is an invalid URL, that just happens to work, so it's 
correct that the link we produce is urlencoded.

(See e.g. https://en.wikipedia.org/wiki/Query_string#URL_encoding)

>>> Found 3 matches for libssh/libssh.h
>>> ....
>>> I guess that the current incapability is due to spurious urlencode in
>>> cgi-bin2/package-grep.cgi
>>> that is modifing the $param_grep
>>> echo '<li><a href="package-cat.cgi?file='`urlencode
>>> $partfile`'&amp;grep='`urlencode $param_grep`'">'$file'</a> - 
>>> '$desc'</li>'
>>> Could someone double check my guess ?

So it seems the urlencode is correct, but the urldecode isn't working.

I've applied a one-character change which appears to fix things.

> the git logs says that only Frank and Jon have recently worked on
> 
>     cgi-bin2/package-grep.cgi
> 
> I would like to double check any possible modification before proposing a
> patch to change the web server...

This was actually fairly easy to reproduce locally, once I realized what 
was going on:

$ export url="libssh%2Flibssh.h" ; printf '%b' "${url//%/\x}"
libsshx2Flibssh.h

$ export url="libssh%2Flibssh.h" ; printf '%b' "${ur//%/\\x}"
libssh/libssh.h
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple