X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:references :in-reply-to:content-type:content-id:content-transfer-encoding :mime-version; q=dns; s=default; b=xGHxV2E4iw1KjsV7UWwh7dyuAiYJN psJsd6I9RWsqB/jafd/YPPLQ12qI8T5WXssC0LPs16mmuktV2ra7DvbG/CF2jTff Wh2ABBxqGTFSptN9hfvB9jm+R416c+Uu3eFCcEEMfiqQiH1PqiCEWW3Fj1dQTbOy qOjFaRGGFbjjpY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:references :in-reply-to:content-type:content-id:content-transfer-encoding :mime-version; s=default; bh=OWlpW5jUjJX+ReqAfPdf3NNUoDM=; b=Lwc kmkRFVuC0jVrCScsWVHye9kXvP5zyLzrztAIfM/5boqVFeK/32z1g4RYCZDs6LqT Aoxkq81wAdfGyWY/aNaUtJZeUqjIjES8U9XyOIzZwMr9O7Xbj/IAHJbcaLognhpC bgBoEuocFvb9m+uWNZOtF0KMq41JiO4bLajnw2L0= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=je8ZYOmof9I5hMCv8FnW6TBpNfUdACZQ6Onkax3TPo+f863bIv250dt+NDbFkAGo66ERAigFDSXSTNPbnUAWtUYyxdMqH0vjxmIIjV7qBKaUpqmPPZCsmeQcLIZe1XgXYn9yl05lDFFmlPCfjS/zIuihbVn03rWlmVEKwLlarxnPwe5+95gthOR504GbMw0q1Yvg3VpLzlUhrOYS06x5DBHmMzlGvCzK4mM8FAUdyoQQOlf1N1mWU5p8DIyYInQ2Mxy4+mRXYJI9sQe918U/VbVPWRioeIiStL6kc6TEgcfgY2BLKeM24z0W238Kr5zbX/7Y//2SIRJR6GFK2614kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5cIToGTKMPmCInxOMZOEmz15pu7vregrdG7LPEspiDQ=; b=LPfzOZNGgxm//bGDupsZgPTXnz/f8UOxeiQYw4PvK30F6LZHCUOuKAB/+BDNKESVhdFvdds4KrJpHAXQlIwFmt9oMZQlBGEz8RnLA3jK388CBSR1lS3VpCxV5N8ihMWK2DovaDGXjkFaAe0SJN16JLIoNeltf+J+dLSvh0kMiWHOXNwj1v6Lqf+fDpeeR9r9OON13fR0nXil6RLDbQr0kYh9JUOrB/oYjWeerPJmuootUY2yxTRfEFyOeNE5V+ffbH6WgnqicLDhxXke1DqS6QbjL7nNjbNhgZJogHdDKgJcQ3EgGF9GdIIR+g/qhvKYTMpcG/oaXOaKlR4zQoELlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5cIToGTKMPmCInxOMZOEmz15pu7vregrdG7LPEspiDQ=; b=JABCeA8fS/cF7r5APgjl4F+m9DR3riVsarUFtDmJgQ1BJ6N3wQ44EorLgb0DLG5/Jf3nFOoA77p8vAMcbnzqxiN4NC/U2hyc6IFUxZbnPzxtaNju5npXpMSgBNYob8ckcEaDaoPWkE4Dr8AQga7m3dt3NX4pSXCOc3vuVWct8VM= From: Ken Brown To: "cygwin AT cygwin DOT com" CC: Tim Adye Subject: Re: 3.0.7(0.338/5/3): Possible reference to Developer's instances of dev files in deployed build Date: Mon, 9 Dec 2019 21:13:06 +0000 Message-ID: <789b5ce6-0da1-7376-4b1d-fce56fa3272e@cornell.edu> References: <20191206045537 DOT GA22631 AT shackleton DOT labs DOT net> <20191206110709 DOT GB3499 AT calimero DOT vinschen DOT de> <20191206143457 DOT GC3499 AT calimero DOT vinschen DOT de> <20191209091728 DOT GE3499 AT calimero DOT vinschen DOT de> <284a5954-82d4-2661-f738-0eaa2c09b802 AT cornell DOT edu> <20191209130512 DOT GH3499 AT calimero DOT vinschen DOT de> In-Reply-To: <20191209130512.GH3499@calimero.vinschen.de> user-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=kbrown AT cornell DOT edu; x-ms-oob-tlc-oobclassifiers: OLM:9508; received-spf: None (protection.outlook.com: cornell.edu does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XvzyAkUwoxG9wh9lPvFGq+ctkh0cjwh+AYuTYwrmzLNGRTujcnAr9Y3MsmPcSuQgbbaf0O+t45YBaG/U/pK2Og== X-IsSubscribed: yes Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id xB9LDkp1024153 On 12/9/2019 8:05 AM, Corinna Vinschen wrote: > On Dec 9 12:47, Ken Brown wrote: >> On 12/9/2019 4:17 AM, Corinna Vinschen wrote: >>> On Dec 7 21:03, Ken Brown wrote: >>>> I don't have any words of wisdom here, but I need to correct something I said >>>> earlier. >>>> >>>> On 12/4/2019 3:50 PM, Ken Brown wrote: >>>>> The assertion fails because 'Z:' doesn't contain a backslash. >>>> >>>> This is not quite right. It's true that path_conv::check strips the trailing >>>> backslash from Z:\, but then it adds it back before calling symlink_info::check: >>>> >>>> /* If path is only a drivename, Windows interprets it as the >>>> current working directory on this drive instead of the root >>>> dir which is what we want. So we need the trailing backslash >>>> in this case. */ >>>> if (full_path[0] && full_path[1] == ':' && full_path[2] == '\0') >>>> { >>>> full_path[2] = '\\'; >>>> full_path[3] = '\0'; >>>> } >>>> >>>> Thus symlink_info::check is in fact called on Z:\, but the assertion fails >>>> because the code at path.cc:2905 is looking for a backslash prior to the >>>> trailing backslash. So maybe the right fix for the assertion failure is the >>>> following: >>>> >>>> --- a/winsup/cygwin/path.cc >>>> +++ b/winsup/cygwin/path.cc >>>> @@ -2895,7 +2895,8 @@ restart: >>>> slow down normal operation. This extra check only kicks in if >>>> we encountered a STATUS_OBJECT_NAME_NOT_FOUND *and* we didn't >>>> already attach a suffix. */ >>>> - if (!restarted && !*ext_here && !(mount_flags & MOUNT_DOS)) >>>> + if (!restarted && !*ext_here && ext_here[-1] != '\\' >>>> + && !(mount_flags & MOUNT_DOS)) >>>> { >>>> /* Check for trailing dot or space or leading space in >>>> last component. */ >>> >>> Ok, please push that. I'll create a snapshot so Wilfed can test this. >> >> Done. I'll document it once Wilfed verifies that it fixes his problem. > > Great! I created new snapshots. > > Wilfed, please test if the latest snapshot from > https://cygwin.com/snapshots/ fixes your problem. Tim, could you test it also to see if it solves the problem you reported in https://cygwin.com/ml/cygwin/2019-10/msg00155.html? Thanks. Ken -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple