X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:references :in-reply-to:content-type:content-id:content-transfer-encoding :mime-version; q=dns; s=default; b=kbtS+txCbxR8knfrS/9Pn3iIHlsR3 e1Gwomi4KUToCCJ6ODMzKvr+FO12YzICawduC6iPmyhVjb24kk4SVjGFkzWV0Bw2 ZkOC7jDA82iYedk2DhEWOcrGKEqSJBRYWvnRtDBLP6DqnVqUlZLUBP3skhGZKHrw 5EF4EwEw9tb9+Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:references :in-reply-to:content-type:content-id:content-transfer-encoding :mime-version; s=default; bh=q7dw/JPCG0yF6JmFBnm7zLGHbns=; b=dGc z0kf+gxGHDkNrT0kyBdP/I6EVTEPhTx6HCVRc0REQcuB7vBEs65HBiCqMmt8Ijjy hGgY8oyVTJ3VNgBiokVrdGPWJRchnkfcDYrScvUXoxOgBzAAJUprzL4D2rd9KbmA S6RGesl/ie9+Ibj6RQq73/tDfBkXO81hh69Jk+EU= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: NAM10-DM6-obe.outbound.protection.outlook.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdO8nTMgAz448H2fMgkMYOXwj1yLpmRnCV9MelZjDEPV/JuhqvUaG2M7SLB+kH9rFGr2yQSEjUID7dOF5NmF9rfn4EMFvLeJF+1Z8VyR6mHlEmoSM2LIWwzjn7OY7A3J49JQ5aZfp2B2N5Fd5VeOPaDSyMr27XADBKtSfdJHk5VEHd6bRNuU/zAmpM8heN+8xx/hB+WnENf4COgugMj78kgA4dlcA7faMNnJpmocmJ9/kRRCJT0WfMgT9jm/it01wbZhFSGCwPM5WvydJY5MBaF1UeLGxVHVG1BiCaa82ELvevl8D2aE+PVCedYuhLnX3YbM102P0AKhZQ0EkiBFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfH2AvANrRjY0anoWkhGzdDefvd0O6TyGd+v1GkAVPM=; b=S57QURsPMPHVzKTCvd45HTjSCr2uuDDw2EiU8Jv7VHcgzkNAtE2NXhkdkuz4tCoHK3m/k4b2wPhMgl7n0JB/7AuSidkBpjIdMBgvevLycCVayeGPwxTBArnvZoRuddtuz9uKfW1iQWyJip7hPoizyv5RLE97aL8Zox+r2eEor5G0ofwW1ZsOYulFUzbgdqYjaW38OHCycobQVdsm8fWCFRRJZwSHv8wvInKZxEQ6PaFzoFY7YCw8kqF0zpqS3jIH49wIeLmEfw768PM/ERRQo6ZDPIbz0ApPaqs54XaEOo/VAPLCQANKWKTBCRAp8A6sbUdxMWNoYMqBnvF/VCWtMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfH2AvANrRjY0anoWkhGzdDefvd0O6TyGd+v1GkAVPM=; b=RJ33G7y8kxUSSAHiKi8iy9fDZHTCoHDeR0/uhIzwrHAiJzKyNiPK7oyLVm/R5jzZSV70BmtLHzkkJa1/luf6ET2CGgFEx5o5CDEHB6IF2kvo1e6Z0yoFxwwRwlRxbupWW5CdkMb+/eH39m9Lv/eyhT0GU8xRGy/WpTItfek/1ss= From: Ken Brown To: "cygwin AT cygwin DOT com" Subject: Re: 3.0.7(0.338/5/3): Possible reference to Developer's instances of dev files in deployed build Date: Mon, 9 Dec 2019 12:47:01 +0000 Message-ID: <284a5954-82d4-2661-f738-0eaa2c09b802@cornell.edu> References: <20191206045537 DOT GA22631 AT shackleton DOT labs DOT net> <20191206110709 DOT GB3499 AT calimero DOT vinschen DOT de> <20191206143457 DOT GC3499 AT calimero DOT vinschen DOT de> <20191209091728 DOT GE3499 AT calimero DOT vinschen DOT de> In-Reply-To: <20191209091728.GE3499@calimero.vinschen.de> user-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=kbrown AT cornell DOT edu; x-ms-oob-tlc-oobclassifiers: OLM:9508; received-spf: None (protection.outlook.com: cornell.edu does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <166B155AFCF0E64880C7205392E15184 AT namprd04 DOT prod DOT outlook DOT com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UaK4U8TJ91XshOxJ7yiXsTYr24JCCILQvzZkgZv1k77JGiWqzK3wbDkDqIIufWDKKAiqGpgbySPGS2pvQs9H7Q== X-IsSubscribed: yes Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id xB9Clmx0015855 On 12/9/2019 4:17 AM, Corinna Vinschen wrote: > On Dec 7 21:03, Ken Brown wrote: >> I don't have any words of wisdom here, but I need to correct something I said >> earlier. >> >> On 12/4/2019 3:50 PM, Ken Brown wrote: >>> The assertion fails because 'Z:' doesn't contain a backslash. >> >> This is not quite right. It's true that path_conv::check strips the trailing >> backslash from Z:\, but then it adds it back before calling symlink_info::check: >> >> /* If path is only a drivename, Windows interprets it as the >> current working directory on this drive instead of the root >> dir which is what we want. So we need the trailing backslash >> in this case. */ >> if (full_path[0] && full_path[1] == ':' && full_path[2] == '\0') >> { >> full_path[2] = '\\'; >> full_path[3] = '\0'; >> } >> >> Thus symlink_info::check is in fact called on Z:\, but the assertion fails >> because the code at path.cc:2905 is looking for a backslash prior to the >> trailing backslash. So maybe the right fix for the assertion failure is the >> following: >> >> --- a/winsup/cygwin/path.cc >> +++ b/winsup/cygwin/path.cc >> @@ -2895,7 +2895,8 @@ restart: >> slow down normal operation. This extra check only kicks in if >> we encountered a STATUS_OBJECT_NAME_NOT_FOUND *and* we didn't >> already attach a suffix. */ >> - if (!restarted && !*ext_here && !(mount_flags & MOUNT_DOS)) >> + if (!restarted && !*ext_here && ext_here[-1] != '\\' >> + && !(mount_flags & MOUNT_DOS)) >> { >> /* Check for trailing dot or space or leading space in >> last component. */ > > Ok, please push that. I'll create a snapshot so Wilfed can test this. Done. I'll document it once Wilfed verifies that it fixes his problem. Ken -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple