X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=Lp8FRQO87NBKlZQXVPDQ6824LY+yWVSC0zJPFxyjyxBED4zhQl3Gy
	ITBsYUpxoUboen11LwDBYAh1Vle1ZaX0SZJB57fTQuZPGDuupMv9Tblk8+cbIoPw
	5C0Jk+5Pkcsn4SfCs4BC2AhSe0Bc6XiCYyb/oIFAy0fFVa5EO32EXE=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=hLK4PbkyFVrGm921Ysbm6brV/cE=; b=jTNh1gIDbVoNUlwW6+RIYhI6S+mx
	DdrNdmOkHv4CAbnbzYwmQtDQyQqR28Z8syTUO07NJjzII+13fTSp7GQRf6nUFALR
	Q9O27seFIZ/U19Uq4jxWSjn+nF4c/ml7ufnKEvWZJkg44Qi16KJDnDFPogM93Grr
	p/CnIGrf4W89aIc=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-106.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*F:D*cygwin.com, HX-Envelope-From:sk:corinna
X-HELO: mout.kundenserver.de
Date: Mon, 9 Dec 2019 10:17:28 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: 3.0.7(0.338/5/3): Possible reference to Developer's instances of dev files in deployed build
Message-ID: <20191209091728.GE3499@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20191206045537 DOT GA22631 AT shackleton DOT labs DOT net> <20191206110709 DOT GB3499 AT calimero DOT vinschen DOT de> <20191206143457 DOT GC3499 AT calimero DOT vinschen DOT de> <fe61ad0a-1c5e-120c-94ab-746ff839b426 AT cornell DOT edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="6Nae48J/T25AfBN4"
Content-Disposition: inline
In-Reply-To: <fe61ad0a-1c5e-120c-94ab-746ff839b426@cornell.edu>
User-Agent: Mutt/1.12.1 (2019-06-15)

--6Nae48J/T25AfBN4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Dec  7 21:03, Ken Brown wrote:
> I don't have any words of wisdom here, but I need to correct something I =
said=20
> earlier.
>=20
> On 12/4/2019 3:50 PM, Ken Brown wrote:
> > The assertion fails because 'Z:' doesn't contain a backslash.
>=20
> This is not quite right.  It's true that path_conv::check strips the trai=
ling=20
> backslash from Z:\, but then it adds it back before calling symlink_info:=
:check:
>=20
>        /* If path is only a drivename, Windows interprets it as the
> 	 current working directory on this drive instead of the root
> 	 dir which is what we want. So we need the trailing backslash
> 	 in this case. */
>        if (full_path[0] && full_path[1] =3D=3D ':' && full_path[2] =3D=3D=
 '\0')
> 	{
> 	  full_path[2] =3D '\\';
> 	  full_path[3] =3D '\0';
> 	}
>=20
> Thus symlink_info::check is in fact called on Z:\, but the assertion fail=
s=20
> because the code at path.cc:2905 is looking for a backslash prior to the=
=20
> trailing backslash.  So maybe the right fix for the assertion failure is =
the=20
> following:
>=20
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -2895,7 +2895,8 @@ restart:
>               slow down normal operation.  This extra check only kicks in=
 if
>               we encountered a STATUS_OBJECT_NAME_NOT_FOUND *and* we didn=
't
>               already attach a suffix. */
> -         if (!restarted && !*ext_here && !(mount_flags & MOUNT_DOS))
> +         if (!restarted && !*ext_here && ext_here[-1] !=3D '\\'
> +             && !(mount_flags & MOUNT_DOS))
>              {
>                /* Check for trailing dot or space or leading space in
>                   last component. */

Ok, please push that.  I'll create a snapshot so Wilfed can test this.


Thanks,
Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--6Nae48J/T25AfBN4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl3uESgACgkQ9TYGna5E
T6AZ+A/9GvmisWmv2N0bCJ+vO+FaRn+8rUC4j5T7QpplSUOhiVOnePgzkt1nqtGi
yKYE8boYB8n34s8sbbW0FDc22WqtZ7iFCMDE+wh9lxslK7P/IH7MTEWQd/w6GuEf
9MxxzROkVb6W5ncClQpllUecHJzZt4amBbiE0zlc/V1lOon0CnqIxYjDJl5SEf/S
SRvuVAb4FaiY4k4OUgSHCl8H2YXjngDeunjYOTYOOPCagyIyPwho6LL+Z+zjoYe/
Sl9QWvQvkLfZA3rLEcNfc4fqzplaW9bXkDy2kIFVLvRLiz6utu30ttTf/+5FQfhF
mmB5cAL9Pr3bMnxyH4BfHedOPyHD2CUnDwYbOS7E3NJ68uOM/51i3E1sHfzukj0t
XEHl0NRT1ujghFUdIFjRW/sC0pRWDN7yiQ/CWVOz/+oxPPCbT/BRM2fOKWzduMg6
ujBnJ7BxUiic1iKYQh/fgkZZIBPTNXpe7aWHVX6hLkWNkifNqHOUh7XAjphEnJPZ
6FVGJk2USKBCtsF4cu6HqOhKKej7hmyf57AqEOAJ3b41ZTBGHYbXzfxWEmWRjAD1
5vNk30DEzCQSsPRTv9HypB1g5S6Pdlt3HBqHg47J/uS3ZVkr1P4/2jBfevRHzqIJ
bLBH91lCXh6fFrDg6Ypx4a56FsMFd9sUKfkAUmxPkZd/LQtDqxw=
=+Sfy
-----END PGP SIGNATURE-----

--6Nae48J/T25AfBN4--