X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; q=dns; s= default; b=bqaI1riUFbKF/Pz0mGbabGd5oJvbt44wJioDczlyffx+5FoWdklvw MDxXcqSpknUsszCDbJ3+6X3OdXqpcgMbwlRqueEP5anLthEzys/YF6CjxnUy76zC 4g05f1lz3hTKvBYNQsIJ8tW4beMO5uaNLOBwyVWJYdhmKh6YhDx8g0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; s=default; bh=1ITCfCfMl5aacmabeWAItVckIA0=; b=xypB6S4RdCP7wESggWA2cIX1glLH 5l9+5NHPHRZ7aQyrapZhJhU5aqSmahGQibN4UsipBj7VSLlTDyjLY11bPP1Veeq4 pATmnkKykocjOHgfXAj4QlGGHnm5NZM665dcbhScHD6oex4ztH7voMoKeEL03kxY nJKjzuBkGyRnkoc= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-103.3 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*F:D*cygwin.com, HX-Languages-Length:998 X-HELO: mout.kundenserver.de Date: Mon, 2 Sep 2019 10:15:08 +0200 From: Corinna Vinschen To: Houder Cc: cygwin AT cygwin DOT com, eblake AT redhat DOT com Subject: Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ... Message-ID: <20190902081508.GB4164@calimero.vinschen.de> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: Houder , cygwin AT cygwin DOT com, eblake AT redhat DOT com References: <3E262D05-F393-453A-9E43-B248DDE50812 AT solidrocksystems DOT com> <20190828125939 DOT GL11632 AT calimero DOT vinschen DOT de> <421ac447-b249-da21-1ca5-228041cfc884 AT redhat DOT com> <20190828141556 DOT GM11632 AT calimero DOT vinschen DOT de> <20190828142220 DOT GN11632 AT calimero DOT vinschen DOT de> <4a87b7a940fb0cf76aac5f3bc5b1a8b3 AT smtp-cloud7 DOT xs4all DOT net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="24zk1gE8NUlDmwG9" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) --24zk1gE8NUlDmwG9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sep 1 19:38, Houder wrote: > On Fri, 30 Aug 2019 11:54:27, Houder wrote: >=20 > > A trailing forward slash in "pathname" is stripped in path_conv::check, > >=20 > > (look for: *--tail =3D '\0' ) > >=20 > > after "pathname" has been normalized in > >=20 > > normalized_posix_path or normalized_win32_path (or both), > >=20 > > before it is fed into conv_to_win32_path. > >=20 > > Tests have shown that Eric's code snippet can be deleted w/o harm. > >=20 > > Counter arguments? >=20 > Hi Corinna, >=20 > My last post in this issue. >=20 > As reported, Eric's code snippet in rmdir() (dir.cc) has become > redundant, lines 317 - 325 can be removed. This is what I'm not entirely sure about. There's some kind of bordercase and as soon as we release Cygwin with this change, as chance would have it somebody will report a problem. I'm not opposed to removing this code, but I'd like to get Eric's input on this. Corinna --=20 Corinna Vinschen Cygwin Maintainer --24zk1gE8NUlDmwG9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1sz4wACgkQ9TYGna5E T6Bpgw/+J3irehSv6apHPZ7SOQiEuu3x3OcXXCUS4/z2uXQyU/jc66Xx1RgIQ9o5 hmWwxFUxdd9deFQzhtQHgRt5X+UljEh+JOPmTWHwCjD2khOHVAIw2IYlK3pELWHq HHWQ/Wj0DdTl9NpIVN3kOGS98kOoi2FOyT4l4cFtbaAkPS82kg34v0J/5YU4RrUd rKOXNDlIysIPPEPtwMQdewKqhFFUA3jXxEZe8TlWhHi51NyAkNEa4o/eK6snncMn V1CC0AxiArwFuVtKQCVXSV4ELnjaXj0bP2lY3WryPaCi0zAdwIFUePzSmxRSOn57 bWiuUOreRSfzf76cmOwVLfVqbzbZpq3omO42AaV9bjDB4ZhBtRu+ldC9cKIVon6V neD9YVw76WIQMr2oa7afHIjRmo9LsasCzDMnaWP4/3grQmyxHZR2QVRRwbIeNV8G Cj+5H+10Z+j1F1yEs9W84shIwJ8bxb3jG4IAc8r98nu7vHqgTWfxV4Yr/LViHKSY ASIb4lX/UsFC53T/p8PCRqX27y5RRRPlwTTf99SHALW9m1AAdLo7zZWm8ivUBJBU nUciRalXY5rv7q4blxOHcTbVbxBjWSDy4K70FAJ+TKGBYixA+F3U+vAR4U80oSrP JZboHZz6PmmxDgrBgEdflsQRiBItb9+IX0laUiXNwWi9uGuTPcY= =j9J/ -----END PGP SIGNATURE----- --24zk1gE8NUlDmwG9--