DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:date:message-id:references
	:in-reply-to:content-type:content-id:content-transfer-encoding
	:mime-version; q=dns; s=default; b=TyE5jwY5BflDrsQINm0/42tumDy77
	EV4l+njtJ9vlYC2Gyo8lMcLKTE5myA34/UIs3V0+1gEFuaSqiCqidzGd3V+3nPat
	3Fqd3+BbPEF0ZC5AWU8UehSHHdROQUwEDXcUymzSC1glNGcPjNkk7BBjiU+p0trW
	3cfVHYxQ00KBPY=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
From: Ken Brown <kbrown AT cornell DOT edu>
To: Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>,
        The Cygwin Mailing List	<cygwin AT cygwin DOT com>
CC: Eric Blake <eblake AT redhat DOT com>
Subject: Re: Can't debug bash with gdb 8.2.1-1
Date: Tue, 23 Jul 2019 15:42:19 +0000
Message-ID: <10d70ba8-41a8-10e8-0ab0-5be526931de7@cornell.edu>
References: <37d412b3-f0ff-b079-4d64-16b01898b420 AT cornell DOT edu> <73dcccf2-33a0-7608-269b-e9cb9abc2238 AT dronecode DOT org DOT uk>
In-Reply-To: <73dcccf2-33a0-7608-269b-e9cb9abc2238@dronecode.org.uk>
user-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
received-spf: None (protection.outlook.com: cornell.edu does not designate permitted sender hosts)
Content-Type: text/plain; charset="utf-8"
Content-ID: <827527381F79FE439D15F57021DD32D4 AT namprd04 DOT prod DOT outlook DOT com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-userprincipalname: ksb2 AT cornell DOT edu
X-IsSubscribed: yes
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id x6NFh8cZ008091

On 7/23/2019 9:51 AM, Jon Turney wrote:
> On 22/07/2019 15:59, Ken Brown wrote:
>> With the test version of gdb, attempting to debug bash fails as follows:
>>
>> $ gdb bash
>> GNU gdb (GDB) (Cygwin 8.2.1-1) 8.2.1
>> [...]
>> Reading symbols from bash...Reading symbols from
>> /usr/lib/debug//usr/bin/bash.exe.dbg...done.
>> done.
>> (gdb) r -c ls
>> Starting program: /usr/bin/bash -c ls
>> [...]
>> /usr/bin/bash: initialize_job_control: getpgrp failed: No error
>> [...]
>> [Inferior 1 (process 31876) exited with code 01]
>>
>> This problem doesn't occur with gdb-8.1.1-1.
> Thanks for reporting this.
> 
> I had also tripped over this problem recently: It seems that changes in gdb 
> (bisection lands on [1]) mean that any call to getpgrp() in the inferior fails 
> (this can be demonstrated with a test program that just calls that).

I can't reproduce that with the following test program:

$ cat getpgrp_test.c
#include <unistd.h>
int
main ()
{
   pid_t t = getpgrp ();
}

> I believe this is behaviour is caused by some kind of defect in the cygwin DLL, 
> but I haven't made much progress in investigating it. (I don't really understand 
> how the inferior gets into a state where getpgrp() fails, which isn't really 
> supposed to happen...)

POSIX says that getpgrp() never fails, but Cygwin's getpgrp() can in fact fail. 
I'm about to send a proposed fix to cygwin-patches.  I've just checked that the 
bash example succeeds with my patch installed.

BTW, I think there's also a bash bug here.  The bash-4.4.12 source code has the 
following in jobs.c:

   shell_pgrp = getpgid (0);

   if (shell_pgrp == -1)
     {
       sys_error (_("initialize_job_control: getpgrp failed"));
       exit (1);
     }

At first glance this might seem OK, since getpgid() is allowed to fail.  But a 
macro earlier in the code redefines getpgid() in terms of getpgrp(), which is 
not supposed to fail.

I've added Eric to the CC in case he wants to follow up on this.

Ken

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple