X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=PMm9CitUlM6XUhUh7NjFdF1/3eSAruVqqhKqd/nwdK6ptXUw9qPti
	WZgeEBn3PxWYTOG+73RAUFED9mZhS0PsAMCkdJvJQFS4pmx2rEyZFTHwTzi6wRGh
	RXogaBensmMg+MuBvidiSEnGiucTt40MC/ANc0C5toKZNEj0kQH7NQ=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=p8kMgqDS2h8aRWzdbweIoxxCnrc=; b=amW9QWWoTYFyE2gj3iWCYFiqHzai
	er7Lpi9yTp7av5+pE+qRkQfsv8ivRfaaW/fNEEhRjBoDkQ7ZwJl7y+9vDYHDTtLg
	rLqXQaltXK4uhxbMrzmbG5rD/6OD8A4avEmD/e5r+WwePYKE+X8iYetP5rUm8SM+
	mrI01iUQfPnlczI=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-106.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GOOD_FROM_CORINNA_CYGWIN,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: mout.kundenserver.de
Date: Mon, 22 Jul 2019 18:45:09 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: Ken Brown <kbrown AT cornell DOT edu>
Cc: "cygwin AT cygwin DOT com" <cygwin AT cygwin DOT com>,
        "Erik M. Bray" <erik DOT m DOT bray AT gmail DOT com>
Subject: Re: Regression (last snapshot)
Message-ID: <20190722164509.GG21169@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: Ken Brown <kbrown AT cornell DOT edu>,	"cygwin AT cygwin DOT com" <cygwin AT cygwin DOT com>,	"Erik M. Bray" <erik DOT m DOT bray AT gmail DOT com>
References: <8f6a87faa9c8130241c026889a01d763 AT xs4all DOT nl> <5414d0e1-79d9-cab7-b1bd-4761265bf8bd AT cornell DOT edu> <265a2749-95b6-38aa-a191-7913bfcc98b6 AT cornell DOT edu> <20190722152016 DOT GE21169 AT calimero DOT vinschen DOT de> <20190722155340 DOT GF21169 AT calimero DOT vinschen DOT de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="oXNgvKVxGWJ0RPMJ"
Content-Disposition: inline
In-Reply-To: <20190722155340.GF21169@calimero.vinschen.de>
User-Agent: Mutt/1.11.3 (2019-02-01)

--oXNgvKVxGWJ0RPMJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul 22 17:53, Corinna Vinschen wrote:
> On Jul 22 17:20, Corinna Vinschen wrote:
> > On Jul 22 13:44, Ken Brown wrote:
> > > On 7/22/2019 8:23 AM, Ken Brown wrote:
> > > > On 7/20/2019 6:55 PM, Houder wrote:
> > > >> 64-@@ uname -a
> > > >> CYGWIN_NT-6.1 Seven 3.1.0s(0.339/5/3) 2019-07-12 15:28 x86_64 Cygw=
in
> > > >>
> > > >> 64-@@ ls -lL <(grep bash .bashrc)
> > > >> ls: /dev/fd/63: No such file or directory
> > > >> pr-------- 1 Henri None 0 Jul 21 00:41 /dev/fd/63
> > > >=20
> > > > Thanks for the report.  This is probably caused by my new FIFO code=
.  I'm
> > > > looking into it.
> > >=20
> > > Actually, a bisection shows that the regression is due to the followi=
ng commit:
> > >=20
> > > commit 2607639992f6600135532831c8357c10cb248821
> > > Author: Erik M. Bray <erik DOT m DOT bray AT gmail DOT com>
> > > Date:   Wed Apr 10 17:05:22 2019 +0200
> > >=20
> > >      Improve error handling in /proc/[pid]/ virtual files.
> > > [...]
> > > Erik, can you take a look?
> >=20
> > I have a hunch.  It's this change:
> >=20
> > @@ -355,7 +355,7 @@ fhandler_process::fill_filebuf ()
> >         }
> >        else
> >         filesize =3D process_tab[fileid].format_func (p, filebuf);
> > -      return !filesize ? false : true;
> > +      return filesize < 0 ? false : true;
> >      }
> >    return false;
> >  }
> >=20
> > The formatter for /proc/PID/fd, format_process_fd, returns *valid*
> > negative values.  But the above patch treats all negative values as
> > error now.
> >=20
> > The fact that format_process_fd returns negative values has historical
> > reasons.  Negative values of type virtual_ftype_t are files, positive
> > values are directories.
> >=20
> > One way to fix this is to change this to all positive values.  At a
> > first glance I don't see any check for an explicit negative
> > virtual_ftype_t value, especially not in the only consumer
> > path_conv::check in path.cc, and the simple numbers have long been
> > replaced with enum values.
>=20
> A second glance shows a few problems in the code...

I pushed a patch and I'm building new developer snapshots right now.
Please give them a try.


Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--oXNgvKVxGWJ0RPMJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl016BQACgkQ9TYGna5E
T6BzBA/9EgT0K7l50Y6db4xrLIbzl0onbtaXFoqpvdZpbD/rJttVdk4oExE38eM9
DuWdJlWm80Kq/xo0vNWpyxEMkyCwZku4iy6SZfC8/pQ1zvHALD/cl6tq+v8C49so
2dbzXXy0T6SW5qfw0Vc1yMiZ3A2wDJZiSkkiHE/+OlFhB8cp/IP9Kr6vQ+D6DEuU
w2a1A10b0ARmWXOie/jcllrwl/i8fNWvWrAVhxENHRxnogjQKXc4FSOBoKe7Sclz
oAa4H6vZcyBkPC1WvE7SXutbHzrnR9D8h8XHDxF1eKsaayjhc14UaFXDo3oaNR8Y
/oOjFLgHTDV6bHefMZwiBQm4Pe4qllxIbj/mkjBUZ5GZLkEoio3lMjkJbmnTBJVy
uYe4Jk6Igqw1ft8EjBk4EkguGg1o3UQe6BNDs5iAwL44PnZvW6bFvAXHb/LdzpP2
9bSKqWATQletOJLnDrGRo1jiVtwxOTdUK/4GuXeL3sg/ySml/l5+Zg4b+92uZAmy
R8EisImbIQxzAA/WF/nO+AY8ieEbqx1hk9mv5KcU4u6BbVMqjfqXN92REn2V9UEe
dNi4UPw73rqYBomunDfQCkA0z4nXLhm8sn6q/j/sSNS8Jl1Vz2zSvQ4PsWg1r3jA
ZJQgDmtSETRhza78s6zs7+jjSZi+mOxKjIHUy+5UJcrUj221Q8U=
=l/NL
-----END PGP SIGNATURE-----

--oXNgvKVxGWJ0RPMJ--