X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; q=dns; s= default; b=UdTIQHiOfHjPIi4+AVhvw8tZjk9nmGc5MflE7mvyaxloBOJV3h3w/ YOGo4Fv6uP/0rUTL/tqBzNiBs8HWBAc2kXM4fbyGsI852YDHTkGZBcj7cR5G+mlv mtOuix6YKmZDbQIXghwODCYitykquukHF8BF3X4On9CgzI8Ia2vs8Q= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; s=default; bh=H9PY383m+Shy/c/DGVeX15J2WXc=; b=Fc4vZgjzqBKRNBtlaGcBYzEohQ/m XP5Z6YJR9So+JmeIghHV/yrWZGTT6hDrWOhUOaURadYBeiQ8JcpzhzzzqeDJaX+s 3FKx0HbVejz6GXNPcZbHcFw+dHzpVAnfcttLHv4Q6FLKz3gN7BddTRGfCLUk65qb dbrWtFsJQNOkJMY= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-105.4 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*R:U*cygwin, Attached, H*F:D*cygwin.com, explain X-HELO: mout.kundenserver.de Date: Tue, 16 Apr 2019 11:09:47 +0200 From: Corinna Vinschen To: cygwin AT cygwin DOT com Subject: Re: Setup.exe: solution to misbehaviour Message-ID: <20190416090947.GM3599@calimero.vinschen.de> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <550c60bc7704a5955804e38504cbc4f1 AT xs4all DOT nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="924gEkU1VlJlwnwX" Content-Disposition: inline In-Reply-To: <550c60bc7704a5955804e38504cbc4f1@xs4all.nl> User-Agent: Mutt/1.11.3 (2019-02-01) --924gEkU1VlJlwnwX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Apr 16 09:19, Houder wrote: > L.S., >=20 > Setup.exe writes "user defaults" to /etc/setup/setup.rc in the root > directory. Among these user defaults (which should override program > defaults) are "last-action" and "last-cache". >=20 > last-cache is an alias for the Local Package Directory (abbreviated > to local directory), the directory where the tarballs (or packages) > will be stored. >=20 > When setup.exe starts, one has to choose between "Download to local > directory", "Install fr. local directory" or "Download end Install". >=20 > As a reminder, setup.exe will show you the "last-action", i.e. what > action was chosen by you when you last invoked setup.exe. >=20 > However "all of the above" is in vain, if setup.exe fails to select > the correct root directory. >=20 > Currently, setup.exe fails to honour the -R option, which one uses > to specify a different location for the root directory. >=20 > setup.exe also fails to look for /etc/setup/setup.rc in the current > directory when setup.exe is started from the root directory. >=20 > I have written about this misbehaviour of setup.exe here: >=20 > https://cygwin.com/ml/cygwin/2019-04/msg00032.html > ( Setup: why consult registry (rootdir) if -R has been specified? ) >=20 > Attached (I hope) to this post you will find a corrected version of > the UserSettings::open_settings() method; it determines the location > of the root directory as follows: Thanks, but the form you chose is not that helpful to discuss a patch. Just send a patch in `git format-patch' style to the cygwin-apps mailing list. Please keep the extensive commenting out of your code and rather explain this in your commit message. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer --924gEkU1VlJlwnwX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAly1m9sACgkQ9TYGna5E T6DZkg//eCYKkaGzge7p/t/yDYHLlJ+yLf12TV+JJF2zb4P8ak86FYm77Dq7/A0b ydrMbU8+dwI+7nkFJPPmnqQd71/TZRTo+EeYcKTDZPh+zAxdKBHr1dBdgJTDArE0 3nL9gwMadkETwqJyOl+U2uqX5A1DGSyV2BPXex9C94vGAepRjYoAPmQlpYC6ul0N 9YkKrZYffQjaau3g/H4cv4i4NoMC3bDP1onVNSuMV+Fr9zEuKtfhO/HyAx3tI+k6 pEKV0h8wLEX4O5h7jPiqupVeCXi483uFlSKA4WNq99EnZI9G1l1tzEQO7fkbGQIm ZIgJv/0RX58TgBqwnnawlixFVuA4dAQwKnjxlyi2Z/2tz/B0VzKqhoFekPuFDY9S LuKAqzeM31uD+Au7OL20gNQtWFv+hS6ZoWSBPsX7E4oMRqQZytI+MMO3rOZccE/y 3q3Z3Ict8iImkqBGcSLyALuniwnGSR33xM0UfbdiCALPxSTlH1+kJCoShP/gFK9g bXBi87JqQHkHf0lAmH+sEuSlNfzQBBf/FbYkDUdHjDVqBgpJaWeTiGs8uH0E/rci vdqxCvdwQh7zs/nXiyVNlqoLlupAUbQQy7+hF8L12xhHjWrA2WkY2xsk9zJXU3Hg 2ZmLbDZEpluP/FRUlgLVTQalF/2HXlKVYIIgTt5fK3brdiSX5HY= =dgjH -----END PGP SIGNATURE----- --924gEkU1VlJlwnwX--