X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:references:subject:message-id:date :mime-version:in-reply-to:content-type; q=dns; s=default; b=is5H qBAaVxPNQ2onkdW4sdWKsZz0r7E4Ce2jR2fQYG0SHGBNl/DpFzz4NO5WITT2aQjG fwrpEDGYPxXgbRTE/A6bBH4++k4eimq75MiFowUadD8CWHL7VtRI+S+sKfxsvI63 RHjXDV8GVCTTnP0hpn72Y5LzXy2nOnq3Idd/3Vk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:references:subject:message-id:date :mime-version:in-reply-to:content-type; s=default; bh=7d0bJhVS7H q2cvTvY2qSBut/2RY=; b=MQmLj8sN3gDyC/BG5XQXepXT+SkDx5bujG9AlLLROR Se1O3FQRhJhgZojauTWAbLlUi94fdk3zHSURRaSkJP6LXcaIu8HOYcSNhg7Tvu/U sczJp2Prb64bAtYPPv4ER0ishGuKvYO2dxMQXO8ogI+NkKaH/I8JjrfwURhGqUYr s= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=madison, H*RU:sk:broadba, HX-Spam-Relays-External:sk:broadba X-HELO: mail-lj1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:references:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to; bh=mIl3XLQr+WxkEHSaFqbhtYhrMlLEYgap6jcMqbbAI2k=; b=bpDyiGQ5O0qOgvBN6x6NCjcjGMY9Hm7oPLt0SOq+jHhe6rBBpwNJ0gtziEI/8AeLk+ VoHm9LqDXdQRtrMA8nMISvHIdBTBRdE0XW8ISB4Q/l7eDAD52h54rB0tiANTSa4pOKLU C0Xlm3fYc35gGywEmav2js7euhSStzdJW584ZtS+2Eg/vbXtRmky8Zukvsserm4pSIHO RBVn8z3iJAWnyd46qrSeDuJQgxH0YlEH+pgTpzGUEElq0HA7s9qJ0RrDdm6u01njFEVm QC85n3oHziitQgSdu7TLGXMGUhoMsC40LzLHK0xfd6ZNzZhNx2Dox/op0wyaz2g3mx6U LENA== From: LRN To: cygwin AT cygwin DOT com References: Subject: Re: cygwin port of glib Message-ID: <18ed9090-2c35-cca2-4b7f-2d057a44b351@gmail.com> Date: Wed, 3 Apr 2019 15:16:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SKzj5fiaUl6XacMVzFnw3L467QKZ3wOWY" X-IsSubscribed: yes --SKzj5fiaUl6XacMVzFnw3L467QKZ3wOWY Content-Type: multipart/mixed; boundary="u22drptzld4WrDeZocBT0H0SU0fIsCLgS"; protected-headers="v1" From: LRN To: cygwin AT cygwin DOT com Message-ID: <18ed9090-2c35-cca2-4b7f-2d057a44b351 AT gmail DOT com> Subject: Re: cygwin port of glib --u22drptzld4WrDeZocBT0H0SU0fIsCLgS Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 05.03.2019 17:23, LRN wrote: > On 05.03.2019 17:07, E. Madison Bray wrote: >> >> If they're clean, worthwhile patches then I absolutely think you >> should get them integrated upstream if at all possible--that's almost >> always preferable. >=20 > Okay, i'll see what i can do. >=20 Made some progress, but i would benefit from some input on a few things. 1) This[0] cygwinports commit and a related gnulib[1] commit. Which version= of cygwin (CYGWIN_VERSION_API_MINOR) corresponds to 1.7 (is the 1.7 number even correct?). As a less-intrusive fix, i can switch #ifdef __CYGWIN__ to #if defined(__CYGWIN) && (!defined (CYGWIN_VERSION_API_MINOR) || CYGWIN_VERSION_API_MINOR < somevalue) 2) This[2] cygwinports commit. I don't quite get what the author means. Doe= s he mean that returning a path that looks like "//etc" from parsing a URI "file:////etc" is correct? Or the opposite, that it should return "/etc" ? = The commit seems to be saying one thing, while the code does something else. [0]: https://github.com/cygwinports/glib2.0/commit/b61abed9554ab813ed358ea5bad64= 8987573772e#diff-2d64c930085856723abe9a40105389abR256 [1]: https://git.savannah.gnu.org/cgit/gnulib.git/commit/lib/localcharset.c?id= =3D9f5ab735f030faf651961d55ce3b849dd56dcff3 [2]: https://github.com/cygwinports/glib2.0/commit/40ca93c8ae81e7a05ec098246b43c= e74e157ebd6#diff-c86c0d1edc7cdc043b8b01ee6e526817 --u22drptzld4WrDeZocBT0H0SU0fIsCLgS-- --SKzj5fiaUl6XacMVzFnw3L467QKZ3wOWY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE4MWzR43wYaAzEA49ja3pJ2dZunQFAlykpCoACgkQja3pJ2dZ unTPrxAAqEr+oQP5cT2mk/9Q9nUWMyjlFG6VeBoo49Ba0pxCXliWrLU+eiUxDob8 g0GOC66hH2f6X0TofHC02RXgKilVdg+eci3n/JqpckRxKYlTQumvs6yCDxdVdqW7 1oeXqY/hiYmMDnfquA/Dc4Tkr193pMBXrIXG6JW2yTNqFYN9ku5+KrWswTNUJug2 yZbAysl3zxevuFM+HfxIJ0x8WDNWapR0LuUe095XmtZIamt6uJs0QQ10xkumpxKM 4wJWWysusNNxn8fBjziuPgwhLRbvWU5J8lpX94tM9ZwgErZuNj3IprYmAIsBtoIF JywmPMptQau5Ga/dXGbZPtaiEhxvfutGIJaMvir+k3dY5r65Es6bAac2s83Fnrh6 rJCmNHBI+Z2a+TowWUQgjtetSnv7rcAxegAdAuwXyn+cbpLKDpeW2DariW72kHP3 2VUeFr7c4krAUwEjO1GqcLzFC85yVyMiXCXepCC1uX6CRvaz/embWgdiijNBGRyF 6ZUS/HdHau73l6OJzrQQcbJPrnXGcPxy11hENn8f36nHwQnK9QuXu/SiWZg7IgDC 1LmP+vTSWzFTdzn4sKcotUkRc8gk67SaYXMf2Z3lAo3o0vYTg/Xmc+V5NePInegj JR5CUUbJZDZn4FfVSeXNh4BZeOOI94R0dlVCPChOelj3+23t5x0= =I6z7 -----END PGP SIGNATURE----- --SKzj5fiaUl6XacMVzFnw3L467QKZ3wOWY--