X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:reply-to:subject:to:references:from:message-id
	:date:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=BZoX9Qx0jW6myCyZ
	gX7A3Rc3iTnX4SNhyJw3Hsc8SoETE+ef6mInAkuSJMPWgeo6jDBuJD2nYNcf6Zj/
	JXmPqwZuuRJDkZqGuXEA4eMd+0h0Aafv7EQ2WQJDChZWS5eQwOr6nDt1/tKK8s0L
	NV716lYIAZEoy8FccsPUZOqXOQ8=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:reply-to:subject:to:references:from:message-id
	:date:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=lTuOOiuYAr2R9RFFPQwjqQ
	7pZOM=; b=beHQyWTrZA0xS/zP/kRLHtcpAvjxLzdwpCKSq7tpvMCfZVBro1BNBo
	ynX1S0PhPNGK1UJI2f4b5m1Sn4lDsKx2zO/q9YigB9wwRS0BJhlEZ0xLglrLyj6c
	K4rai6Z9L2uhkqJENN6aho1U6GBokch7cYhymwfvpuRiVVz32m2dw=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=delegate, scars, Take, Canada
X-HELO: smtp-out-no.shaw.ca
Reply-To: Brian DOT Inglis AT SystematicSw DOT ab DOT ca
Subject: Re: Cygwin fails to utilize Unicode replacement character
To: cygwin AT cygwin DOT com
References: <20180905201459 DOT GN6350 AT calimero DOT vinschen DOT de> <5b90846c DOT 1c69fb81 DOT 6a017 DOT cddb AT mx DOT google DOT com> <20180906070117 DOT GO6350 AT calimero DOT vinschen DOT de> <20180907081715 DOT GQ6350 AT calimero DOT vinschen DOT de> <cacb0e82-5498-e703-4d88-17d25e8a126c AT towo DOT net> <20180907112926 DOT GT6350 AT calimero DOT vinschen DOT de> <02a2ad5c-21c5-fce9-5956-a907aa0927fd AT towo DOT net> <eb9947a5-cc85-1d3a-6412-a0c83176d5cc AT towo DOT net> <20180907115449 DOT GU6350 AT calimero DOT vinschen DOT de>
From: Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
Openpgp: preference=signencrypt
Message-ID: <1b170781-d54d-1d71-689d-e2efb4aed9cb@SystematicSw.ab.ca>
Date: Fri, 7 Sep 2018 10:48:07 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180907115449.GU6350@calimero.vinschen.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes

On 2018-09-07 05:54, Corinna Vinschen wrote:
> On Sep  7 13:51, Thomas Wolff wrote:
>> On 07.09.2018 13:41, Thomas Wolff wrote:
>>> On 07.09.2018 13:29, Corinna Vinschen wrote:
>>>> On Sep  7 12:34, Thomas Wolff wrote:
>>>>> On 07.09.2018 10:17, Corinna Vinschen wrote:
>>>>>> On Sep  6 09:01, Corinna Vinschen wrote:
>>>>>>> https://cygwin.com/ml/cygwin-cvs/2018-q3/msg00054.html
>>>>>> I created new developer snapshots for testing.  Please give the latest fromhttps://cygwin.com/snapshots/  a try.
>>>>> Raster Fonts: output of invalid encoding hangs cygwin...
>>>>>> This will be my last action for the next 4 weeks though. I'll be
>>>>>> back in October.
>>>> Looks like s/ANSI_CHARSET/DEFAULT_CHARSET/ does the trick
>>> Without this change, lf.lfFaceName is "T" when entering the do...while
>>> loop.
>> No, sorry, it's "Terminal" initially and then shortened down to "T" by one
>> char each in the loop.
>>> What's the purpose of this nested loop (do...while and EnumFontFamilies)
>>> anyway?
> The loop is handling the weird DejaVu Sans Mono behaviour I explained
> in previous mail.

Garbage in font name from uninit struct on stack?
Before call bzero/memset/implicit:

-  CONSOLE_FONT_INFOEX cfi;
+  CONSOLE_FONT_INFOEX cfi = { 0 };

and remove loop, which opens an attack vector by renaming a good font and
substituting one with a shorter name, or could cause problems by using the wrong
font e.g DejaVu Sans.

You need to self-impose a change freeze before heading out, once you're in
"stuff to get done before leaving" mode, which may be a day or up to a week, you
delegate or postpone decisions and actions until you return: BTDTGTS (Got The
Scars) ;^>

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple