X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=OPDIc+FA3S8rsZCU
	/QuyQeqemdhJOAzfGVc0do3eVBNYadrx2WWpWF5OFZuLxXEJTftIllnVY3gyD54h
	R2sYhIJJXGoPfJyYzq+MPMZKzPC2sLg+qSEKbiWFuSK4OaQjbnqeglXY9ukUtioj
	Imnu5V4PLDxqC8r7OfmUE/lIpJM=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=h8F3trETbT8SZbxhinXxSm
	06aYQ=; b=j4EWYYh8N10lPWAmV27BEKXQhiK/sw/HKb36t27yt+C0AKN294UkNX
	6pS+sLfqnS11/OUn3Ng88HwoBJR4V0V7TBo0tgFaE77wO1rLa2jjiO3Yw+VDZiXT
	9Kj/58A+3s6PpUmRAQ9qvsv/RbE5kdY1uKqn2M1iPAKiSHqo1De90=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=emailing, intend, grrr, blake
X-HELO: mx1.redhat.com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1
To: cygwin AT cygwin DOT com
References: <announce DOT 20180809202604 DOT GN4180 AT calimero DOT vinschen DOT de> <cc1d684fabcfe5e581ec82aae1617471 AT smtp-cloud8 DOT xs4all DOT net> <20180810114254 DOT GA25560 AT calimero DOT vinschen DOT de> <57b3092a9b5027be5f14e59c305200bc AT smtp-cloud8 DOT xs4all DOT net> <71f1280d04f70e8b74cfce78ba5690d3 AT xs4all DOT nl>
From: Eric Blake <eblake AT redhat DOT com>
Message-ID: <f9b36ce5-9027-b7a5-fd06-baa951f6812e@redhat.com>
Date: Mon, 13 Aug 2018 17:16:17 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <71f1280d04f70e8b74cfce78ba5690d3@xs4all.nl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Note-from-DJ: This may be spam

On 08/13/2018 04:29 PM, Houder wrote:

>> The modication would require changing:
>>
>> winsup/cygwin/fenv.cc (_feinitialise() )
>> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT)
> 
> GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters in 
> this
> line:
> 
>       Intel® 64 and IA-32 Architectures Software Developer’s Manuals:
> 
> ... part of a comment at the beginning of the file.
> 
> (the registered trademark sign (u00ae) is encoded as 0xae (cp1252), 
> while it
>   would be: 0xc2 0xae, in utf-8,
>   the right single quotation mark (u2019) is encoded as 0x92 (cp1252), 
> but in
>   utf-8 it would be: 0xc2 0x80 0x98)
> 
> I intend to convert the file encoding of fenv.h to utf-8. Is that a "No-No"
> or is it allowed? (I assume GIT will notice).

In general, git doesn't care if you change a file's encoding - that's 
just another content change.  In practice, you may get weird effects 
when viewing that particular patch (as the patch is not well-formed in 
the new multibyte locale, and looks funky when displayed in the old 
locale), and emailing a patch may require care in telling git which 
encoding to use for the email; but that's cosmetic, and shouldn't matter 
in the long run.  Updating the code base to uniformly use UTF-8 seems 
reasonable to me.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple