X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:in-reply-to
	:references:mime-version:content-type:content-transfer-encoding;
	 q=dns; s=default; b=b0KP99a72cK3mG1krV3jTWIZy+DzhfSgQ2NGLhWh8WM
	58Lr5c0WLKrFoE/12olIh/JH0P7mIvZZsmQlELq+3bQVYiSQ2VhkR2iYhsxT3JPv
	ZOIBQU1tgXC/IU7RxQK8+UeA95b44Lv92iYzbVPtJoT1XJFHVAT4Z/XBNx4bBiY8
	=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:in-reply-to
	:references:mime-version:content-type:content-transfer-encoding;
	 s=default; bh=QFS7w9vs+PTKr418dFZTDPA0TfM=; b=uo4SthGuLMWKwxfeE
	fG1IizC+7dYet1AhO4WcdccOx3b9Ppp6mOWB5IVzQw7OeGNvpWI7P/MPOPVOSrWj
	DsH9r1OXqkAte0Rc/q3qrF27x+QuoUwPiYkCpd4rzbVwqp66W7THLqfpsdysb945
	5TJCJ5XzClHsONGqJpn0QEWXzE=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=judgement, judgment, rights, H*F:D*ne.jp
X-HELO: conssluserg-01.nifty.com
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com w5DFSlwW021922
X-Nifty-SrcIP: [125.3.30.127]
Date: Thu, 14 Jun 2018 00:28:52 +0900
From: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
To: cygwin AT cygwin DOT com
Subject: Re: [bug: csih] Setting privileged rights to cyg_server fails on Windows 7.
Message-Id: <20180614002852.f3799e5b9d72d0c404b897ab@nifty.ne.jp>
In-Reply-To: <CAEhDDbBkDmTyAUs_pEurHmc6uYovSqUpTnVscQYjPy_93eO53A@mail.gmail.com>
References: <20180613224901 DOT d2cf679cef8eab89a834c494 AT nifty DOT ne DOT jp>	<CAEhDDbBkDmTyAUs_pEurHmc6uYovSqUpTnVscQYjPy_93eO53A AT mail DOT gmail DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes

Hi Csaba,

Thanks for your comment.

On Wed, 13 Jun 2018 16:39:22 +0200
Csaba Raduly  wrote:
> > --- cygwin-service-installation-helper.sh.orig  2015-10-28 18:23:35.000000000 +0900
> > +++ cygwin-service-installation-helper.sh       2018-06-13 22:24:30.353515600 +0900
> > @@ -2883,6 +2883,7 @@
> >      then
> >        # This test succeeds on domain member machines only, not on DCs.
> >        if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> > +          -a "${LOGONSERVER}" != "" \
> >            -a "${LOGONSERVER}" != "\\\\MicrosoftAccount" ]
> >        then
> >         # Lowercase of USERDOMAIN
> >
> 
> Won't this break Windows 7 computers which *are* on a domain ?

I think it will not.

This if-statement judges whether the computer is on a domain or not.
The judgement should be true when it is on a domain.

Windows 7 computers on a domain set the environment LOGONSERVER.
So, added line results in true on them. Therefore, the judgment
result of the if-statement is the same as in the case without
the added line.

Windows 7 computer which is not on a domain does not set LOGONSERVER.
In this case:
"\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}"  --> True
"${LOGONSERVER}" != "\\\\MicrosoftAccount"  --> True

So, the judgement without the added line is "It's on a domain.",
which is wrong. The added line avoids this miss judgement.

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple