X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=yXN1LrG
	4SZ3OTcsUpBGCSKgGGTu+baxxBfdBocTtS6W4Z5hmJ+7UbQnODj10j+fzkg5syNO
	67Wa5uGq+VdiT364Y2rwpKeef2thmtjhKNpl/n1zSKxyip7dT/utykPz1Mzs5ZXl
	3+190inhvr4uf8IBbKe8RUlwC4LehYz2E9rA=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; s=default; bh=Mb9pmaRgHVyxt
	KEi5cDhTRDK2Vs=; b=mPalp3/HqBaWtRC0bd/f9dDbWBpNS4D1yefMKrXeT9IJ3
	uu9J5uQLn5Pk4zlrtLQoBTHJx6ac3TY85yE2oVadLn8Ljt7kjN3TV8r9UA0CW0hy
	eudDbpyozec0enuMV/clkcnLx3A1XoTXnR9DAmqnZCDkG8zqSTxIdqmHchzV1g=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-io0-f172.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to;        bh=kDUSKp80c9nNbpfHvySAZGcXkuqaGNf01Lzm58w1KbM=;        b=lZlvgm6gKyCAnsN8j1D83e7TyOInXmjUpB6Ok1AlFH7f1q/6oK6ADB4DU9ihDuFwrJ         SKbxz3OSRTiA6Mejy/ks01e9NwKgZU++UrVgETH05lJjBixd7A0ekJjgAReGY7U2QoMY         881NW4kkhXjCUhEnbLN5CXpeYBrWHB7l55lYN1nEH1dCWVI27PktQgJCQ6P32RK03W0s         nDkymrDZoqGUB3jUFJzNpMFF+nKaoZ+MSA/DSQ4AoXfsNn43QrPDEkHsUy2pzT5NOMc0         y3Jk+43/iVYvic5Eh7Ov+ca6xxY3jqLIEGVN75wAOD+d7ryfOrPFk4KnOUqKo+Z0XY39         m1Fg==
X-Gm-Message-State: APf1xPDFxPlwxvsVplOcuoCv9M5Jdv6JsCVznTLgcHJI7Kjp4XYvyYpY	wCElJPz8tiQY/qFpIxlSFz2hsXVB5xMQhXN5bfVpQA==
X-Google-Smtp-Source: AH8x225oTVfnpciQK+bGTo59Re04EsvE3jlFwXp4tD1nwIOkkwRpPKGafoUiYxjk8Ea+kwVqM/CMjuLNz2lmDzef9sk=
X-Received: by 10.107.166.140 with SMTP id p134mr2426454ioe.272.1518546392124; Tue, 13 Feb 2018 10:26:32 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <874lmu6lgx.fsf@Rainer.invalid>
References: <CAOTD34ZtrCO4tAKBx0oUd4w9ic5h6djZ3vBJMwGEma6VNiytfg AT mail DOT gmail DOT com> <874lmu6lgx DOT fsf AT Rainer DOT invalid>
From: Erik Bray <erik DOT m DOT bray AT gmail DOT com>
Date: Tue, 13 Feb 2018 19:26:31 +0100
Message-ID: <CAOTD34b2Mom2uRY86BF+sATtUs2bwy2x2x3-s7xVs+0SNZ+iJQ@mail.gmail.com>
Subject: Re: OpenBLAS patch for Cygwin
To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes

On Tue, Feb 6, 2018 at 7:07 PM, Achim Gratz wrote:
> Erik Bray writes:
>> Assuming this looks good (feedback welcome) it might be nice to have
>> this patch included in the next release of the official OpenBLAS
>> package for Cygwin since its incompatibility with fork() has caused
>> problems in the past [1].
>
> It would be vastly preferrable if OPenBLAS ditched the (unfortunately
> quite common) notion that "Cygwin is some sort of Windows" for "Cygwin
> is some sort of Linux".  I've patched out quite some bit of conditionals
> like that in some other packages and it was almost always for the
> better.  The worst ones are those that go into the Windows conditional
> branch and then on to "oh wait, but for Cygwin we need something else".

Yup--OpenBLAS treats Cygwin as "some sort of Windows" and you can see
in my pull requests that there are some conditions like "if WINDOWS &&
!CYGWIN".

I will probably try another patch to remove that notion in general.

I've had a little other experience with patching OpenBLAS for Cygwin
and it's one of those cases where upstream is, fortunately, receptive
to supporting it as a platform.  Their existing Cygwin support has
just been a bit janky (a previous patch I submitted installed the DLL
as cygopenblas.dll instead of libopenblas.dll, for example).

Best,
E

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple