X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=AvW/ua4+Fsc4ySQL
	PezG45AE6VrzIYOdQG2g+dMrsBhW5Gy7Fbt94vQwVo+afpY2uNULcVK9tN4T0GGM
	F6tJhfynz9W7e5aPeMpY5GTaEqIpMaU9q0nUU6yb7TiDLz/RmVrDxRuyVgJuxkPa
	+K4LaklGIdrCasTWxNJRTEH1pMk=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=nSTpAQfMgmudEGDwA85gPd
	sP0Sg=; b=dY6ctl0Gwh3bWfRQM2Jb0kkPBQOcoJbE4zAe5wHUdVx2s/zDqKaNrB
	BR7rIpV/noyv9wm97e3qWAPul8rlUp+5T8EFl5f9/buh/ThKjT2qepv+cHKlB0Si
	mDXKU0MLLRs85foEskzQdMNxDivxYXAXzUHx98PCkIhr2A0w1rGsQ=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=SHOULD, Greetings, H*f:sk:b06765e, misunderstood
X-HELO: limerock03.mail.cornell.edu
X-CornellRouted: This message has been Routed already.
Subject: Re: setup's response to a "corrupt local copy"
To: cygwin AT cygwin DOT com
References: <b06765ec-3d9c-d52b-50c5-7ed22bbb8619 AT cornell DOT edu> <116333312 DOT 20171214224616 AT yandex DOT ru>
From: Ken Brown <kbrown AT cornell DOT edu>
Message-ID: <b031c829-d3a0-f28e-9ce0-0052e7d3475a@cornell.edu>
Date: Thu, 14 Dec 2017 14:57:14 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <116333312.20171214224616@yandex.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-PMX-Cornell-Gauge: Gauge=XXXXX
X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none;
X-IsSubscribed: yes

On 12/14/2017 2:46 PM, Andrey Repin wrote:
> Greetings, Ken Brown!
> 
>> This is a followup to the discussion started here:
> 
>>     https://cygwin.com/ml/cygwin/2017-12/msg00088.html
> 
>> When setup is preparing to download files and it finds a corrupt copy in
>> the local cache, it issues a fatal error message telling the user to
>> remove the corrupt file and retry.  Steven said that setup should
>> silently delete the corrupt file, while I argued in favor of the current
>> behavior, on the grounds that setup shouldn't be deleting user files if
>> it doesn't know where they came from.
> 
> The point being, if this is a "Download" Setup mode, the files are NOT "User"
> files, but a local setup cache. And all files therein SHOULD be valid package
> archives.
> There's of course situations, when setup.ini on server become corrupted or
> otherwise out of sync. But being rare, they should not interfere too much.
> 
>> There is a middle ground: setup could query the user.  Additionally, as
>> suggested by cyg Simple, there could be an option that directs setup to
>> silently remove corrupt files.
> 
> Make it mode dependent.
> If it's a "download[ and install]" mode, cleanup and redownload.
> If redownloaded file still does not match the setup.ini hash or if it's an
> "install from local cache" mode, leave file alone for investigation and notify
> the user.

You've misunderstood the context.  The error is only shown in download or 
download/install mode.  And, as I said, it happens when setup is *preparing* to 
download files and finds a corrupt copy already present in the local cache.  In 
that context, setup has no idea where the file came from.

Ken

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple