X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:cc:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=ZwT02Yybb2LGmXyr
	d271tL8b08Yh7ZLhVUCGwYJVvuq99OJdEBERSbWaV2ZV45fOD/yaQig7y4zfHxep
	X6Dy0kXYM6JrXGwHdzAwLkzZghkmReSvoZjnry10JSi7w97Ac1nTAcZSUz9YrCY8
	yoMxgrAHIaawRZaK/lwUIEK/PiQ=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:cc:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=hnjfnhBRsp7hpa4d5T6x4S
	c/Gx8=; b=n2tF/FOx/q2yXMwGvm9xDF/98gQGhEcF4Ci1cyIJ8qkQ3yAnzqbe+K
	oUG1D25fcTIxA/ZaInYFZL2FDu4AWpB6jfk1eYJ1KJgFBpan/POflFgOnRsa7saR
	G1v8Gu3GPrbIM5jRt0bruwODqH+uwa/fSEj0VRe4ZpH8FJFVAXu0c=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=checkout, Hx-languages-length:1136, Hx-spam-relays-external:ESMTPA
X-HELO: out4-smtp.messagingengine.com
X-ME-Sender: <xms:i_wfWtwNW3FD7vUyeufFFtyKikOmHBYEmYATBkmw9Xs2neV6O5DDnQ>
Subject: Re: mksetupini fails validating packages because curr is test
To: cygwin AT cygwin DOT com
References: <CAL_02JBn=m9z9d6cjJ==-wc1_k6iG=0rmRR4VqiOuB0vfAkovA AT mail DOT gmail DOT com> <3e13ae03-786f-6157-00a3-53e909495751 AT dronecode DOT org DOT uk> <CAL_02JC8t9TM6bRyrovCVJRv+pogdn+fNH7kv8ha016XZw0irA AT mail DOT gmail DOT com> <a7c24330-21d1-42aa-bc3b-db9620ac77d8 AT dronecode DOT org DOT uk> <CAL_02JCCmg4S03+Z1W_ADX0rR4nqxXcM0gjqhR07g56HNhQwkg AT mail DOT gmail DOT com>
Cc: Ivan Gagis <igagis AT gmail DOT com>
From: Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
Message-ID: <8690f394-94f0-58ad-8a6b-8067edabc9d5@dronecode.org.uk>
Date: Thu, 30 Nov 2017 12:41:43 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAL_02JCCmg4S03+Z1W_ADX0rR4nqxXcM0gjqhR07g56HNhQwkg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 30/11/2017 09:28, Ivan Gagis wrote:
> I use git repository on github to store the files. And to update it I
> clone the repo, run mksetupini and then commit and push.
> So, I'm not sure what actually is going on with mtime of the files
> there. Perhaps git messes up the mtime of cloned files.

Yes, a git checkout will have the mtime of the checkout.

I've pushed an update to the calm repo with these changes:

- mksetupini and calm now exit with non-zero exit status on an error
- Fixes a bug where equal mtime was considered newer
- Adds 'mksetupini --disable-check=curr-most-recent' option to turn off 
this check

Do I need to package this for you to test it?

> But why is this check of mtime needed at all? Isn't version number
> enough for tracking earlier-later files?

Maybe this doesn't make much sense in the context of mksetupini, but 
this is a useful check for calm to make.

People make mistakes.

People also forget the subtleties of how version numbers sort and upload 
versions which aren't greater than the current version, when they think 
they are...

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple