DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:from:date:message-id:subject:to
	:content-type; q=dns; s=default; b=kAjSej9wIy6Zlnie9VD40dmhHocZj
	nfdbHjyJtrUKc3CTEDTgjuodYzaKw5ul8vmdb052izJ9OKnf3zfIATwuUpH0OjiM
	91xIAFEKEHgM0zKI5FN0KQEzBmKkZ4N/XcqFW8VOABmiDQnygSbzbA953aboAOWL
	kxGAgpxzGujfq0=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
MIME-Version: 1.0
From: Ivan Gagis <igagis AT gmail DOT com>
Date: Wed, 29 Nov 2017 16:58:45 +0200
Message-ID: <CAL_02JBwqseAuH+N+-AE-5A9bs1Y-Nvrt080e-p88pHwVy4mGA@mail.gmail.com>
Subject: mksetupini does not return error code
To: The Cygwin Mailing List <cygwin AT cygwin DOT com>
Content-Type: text/plain; charset="UTF-8"

Hi,

I found that in case packages validation fails the mksetup script just
returns success, though it prints a line in the console saying
"mksetupini: package set has errors, not writing setup.ini".

I think it should return some error code so that it would not be
considered as success by CI scripts where mksetupini is called from.

The problematic lines are as following:

https://cygwin.com/git/?p=cygwin-apps/calm.git;a=blob;f=calm/mksetupini.py;h=f24e4c5751e1f7e13516e8689c041403ba1f8d38;hb=HEAD#l63
returns nothing, should return non-zero error code.

https://cygwin.com/git/?p=cygwin-apps/calm.git;a=blob;f=calm/mksetupini.py;h=f24e4c5751e1f7e13516e8689c041403ba1f8d38;hb=HEAD#l118
returns nothing, should return result of do_main().

I'm not familiar with python, so I don't submit a patch, but even
without knowing python it is clearly seen that the errors are not
returned properly.

Br,
Ivan

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple