X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:subject:to:references:cc:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=uwb0hO1j3ti4HP5L
	SAcxSSMEe221Vxy/vV1mkbmPPxOsZ9in/0+wnBkXB+ySUim7n5sHx71vswQOEGXE
	vc0yrXM2RocQYsPrsW9vwDopsYxbZO812ihaYm+pPfe8neMiBaOlfsIed8CgzkcT
	GujZqkqSS49Ytl8BSitcfryrLgE=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:subject:to:references:cc:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=wo5MGXnG/PMWrN8MyFTCki
	2spgM=; b=EKenZu9/RauDLJKfCgN26t8nZqlss06j5UF15CYHBcfydpcUGdluZM
	7Cub9Lq7FTr+N0d+Ed70i4tdMp7m4WgrZFzp6mDcJA8K3enQ1xRKmG1jk3DECOyQ
	UWRqU+y6fNE1oSN22Xr1XDEheLLdpP/vbw4Mx9zy6e1U0OADEAdKY=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=adopt, Hx-languages-length:1357, H*Ad:U*andy, Hx-spam-relays-external:ESMTPA
X-HELO: out4-smtp.messagingengine.com
X-ME-Sender: <xms:aVwQWfNQ_Q-ovbGQnxcuiba0sqskk0docmTMhmXR1WzBDN1FdA-NRQ>
From: Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
Subject: Re: adopt and update libatomic_ops and libgc
To: The Cygwin Mailing List <cygwin AT cygwin DOT com>
References: <CAM-5HMv9qbUM-=450K7RG7J_4yQWCTCOM1Hp5AWbAAs6Hb+s0Q AT mail DOT gmail DOT com>
Cc: Andy Li <andy AT onthewings DOT net>
Message-ID: <012a4d1f-6d82-422d-000a-f214a133df56@dronecode.org.uk>
Date: Mon, 8 May 2017 12:54:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAM-5HMv9qbUM-=450K7RG7J_4yQWCTCOM1Hp5AWbAAs6Hb+s0Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 07/05/2017 13:41, Andy Li wrote:
> I would like to adopt and update the now orphaned libatomic_ops and
> libgc packages, which is a dependency of the neko package I
> maintained.
>
> The updated cygport files can be found at:
> https://github.com/andyli/libatomic_ops-cygwin
> https://github.com/andyli/libgc-cygwin
>
> Note that I've split them into separated packages, since the source of
> libgc no longer contains a copy of atomic_ops, and they are versioned
> independently as well.
>
> Please review and let me know if there is anything to improve.

Thanks.

libatomic_ops.cygport:

A comment that we need to correct for this installing it's documentation 
into usr/share/libatomic_ops, rather that usr/share/doc/libatomic_ops 
might be nice.

This could alternatively be written using a custom src_install which 
calls cyginstall then moves the directory, which might be less brittle 
to changes in the file list?

This might be an upstream defect if it doesn't respect --docdir?

libgc.cygport:

DEPEND might be better written pkgconfig(atomic_ops)

Again, stuff installed to usr/share/gc/ should probably be moved to 
usr/share/doc/gc


I note we also have libgc-7.2d-2 as non-source package, which just 
contains usr/share/doc/Cygwin/libgc.README.  That probably needs to be 
cleaned up by being obsoleted.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple