X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=eKFKHmNzNluFIzgeRpWi/5zu5wDLkq8mbTLjEvRyIp+4O4+DMLbVn
	Eahj9VutMB8Ugiy9FsMRJx6hJexo0qk+FXlGo0HoKBgJ4qeFcZncXS0gBpWK2hBb
	Eb922LiWIJqfLRu8kgr5Jj57rKxz+x3T8oge7Eg3Mg96gZ8T+pA1DY=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=vrfMhT5g5kOM+wsOeo8kqQzCCMM=; b=DlR7nek3e2BCMPcyi6yBiTVe+PiA
	l+aJgRfCCY8QtQUmgsec5fea06UrWxXRrGO0CV9bqvz/yY4X2HV/9nJlHR6wZ/0I
	zMXlUWsdbk+By252Nx72dWinRDjnRT2bF4uDU5rdbz+X/ACFoWN/6/xqnsI1NEXn
	uMJ4h/xQg7Ac5ZM=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-101.6 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:2cb5cd9, sk:misconf, H*f:sk:2cb5cd9, H*MI:sk:2cb5cd9
X-HELO: drew.franken.de
Date: Thu, 19 Jan 2017 19:16:43 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)
Message-ID: <20170119181643.GB25162@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <84a7692e-041a-8b99-2ea9-fb1c784fc01c AT shaddybaddah DOT name> <20170119103840 DOT GD13008 AT calimero DOT vinschen DOT de> <2cb5cd97-a711-8d11-c07a-2534ee67298b AT shaddybaddah DOT name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="7iMSBzlTiPOCCT2k"
Content-Disposition: inline
In-Reply-To: <2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name>
User-Agent: Mutt/1.7.1 (2016-10-04)

--7iMSBzlTiPOCCT2k
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan 19 22:26, Shaddy Baddah wrote:
>=20
> Hi,
>=20
> On 19/01/17 21:38, Corinna Vinschen wrote:
> > On Jan 18 14:34, Shaddy Baddah wrote:
> ...
>=20
> > > And I'm sure the problem is that this well-intended change to the scr=
ipt
> > > fails on the assumption that LOGONSERVER is always populated. It isn't
> > > for me on Vista.
> > >=20
> > > cygwin-service-installation-helper.sh:2884:      # This test succeeds=
 on
> > > domain member machines only, not on DCs.
> > > cygwin-service-installation-helper.sh:2885:      if [
> > > "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" \
> > > cygwin-service-installation-helper.sh:2886:        -a "${LOGONSERVER}=
" !=3D
> > > "\\\\MicrosoftAccount" ]
> > > cygwin-service-installation-helper.sh:2887:      then
> > > cygwin-service-installation-helper.sh:2888:     # Lowercase of USERDO=
MAIN
> > > cygwin-service-installation-helper.sh:2889:
> > > csih_PRIVILEGED_USERNAME=3D"${COMPUTERNAME,,*}+${username}"
> > > cygwin-service-installation-helper.sh:2890:      fi
> > > cygwin-service-installation-helper.sh:2891:    fi
> > >=20
> > > I fixed this by modifying the test to check LOGONSERVER is not empty:
> > >=20
> > > if [ -n "${LOGONSERVER}" -a "\\\\...
> > >=20
> > > Can this be fixed in the next release?
> >=20
> > Sure, please provide a patch, I'll check it in and release a new csih
> > soonish.
>=20
> I would, but there's a couple of hitches. Without understanding the
> syntax (and I should bring up the bash man page here, I will do after
> this), I can't be sure that the following test:
>=20
> "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}"
>=20
> wasn't designed to handled an empty LOGONSERVER variable.

No, it wasn't.  The idea is that if LOGONSERVER =3D=3D COMPUTERNAME your
machine is not in a domain.  Actually, I *never* encountered an environment
in which LOGONSERVER isn't set.  Are you sure this isn't just some kind
of misconfiguration?  I don't think Cygwin is the only application
checking for LOGONSERVER.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--7iMSBzlTiPOCCT2k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJYgQKLAAoJEPU2Bp2uRE+gu6kQAIsqBRTOu0zEYLlfKeruEIXS
MOnNHcLrERPuX95bWu3LhZjCmAHJARw6Rfzh7vJj0QuS7RaANgWX4Ryc101XCURt
AHx9WwvIQn+UO1x0SFBP41oDZvDKozhQqEJScdJQCcGnrVHvClXTNrzKg9U4KHZe
9KQNVXOzcEf2XJJJX4bzD5aufHZ+DvD9wIWF9hrHH1cnkLv8xuB+TeH75qt+68S+
rN7Zg/R4IqkhJuoHN5ldoaZauDnKzh31alfEWmW2KXuq/IJAX3iauMpzwDasDN1F
vGhAzsgaoj8WtLJxTCUbDe7iDHVYZ0NGOC6XaJT0CFS9pGAUeeKlTdI7f632ZF01
U6vnNuCGrvFzItcvZ0hVxGjPw7kzwqV7XeWcCZ6hNRNd8iCGtrfLHCxgvq4aiuh1
p+E9bDAb2okZbRb1qVRlefWkdJcpTG3MpcnHP7BZUjPJ7R//CZv+WSodj+VH/VN5
sFXhqt5Odmej5p9FjDrwNW7BgwQ171v7BIIMSGktHJv75BOiQsnk9gd0uhjGBDLD
SZ4hPFoqQPj+CUsppMPtZipYGelUstPrSYR41j+EDvrvDRFIVitJdALYE1GGAQ9B
LagQd27g0mNo83oIvnT2jZl48krkl4PS8znTyy3/1Ny/CxbXoCxPIAwNG2ibojSD
NE5jWyrIE5fqG1Cu7a9P
=s6WX
-----END PGP SIGNATURE-----

--7iMSBzlTiPOCCT2k--