X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=p8Oc+CsJ2BS2DJOJ
	OZ1271EHjsoZxYR5HWkgv6mMO9vICqW4WKzJioWXv5BYvT1wkhgLPN8FFYz1wjn0
	j9vABvfE/KHnjql7L/V1hkcpjHMG/OswezMfnXaaS+7qCO+SYzT7JNSEaldcAIiS
	A+uEqTHLaLuGMPQv2FTk7qi3Gs0=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=OlywhYvITlCCglguqDNhFN
	7wfT0=; b=xE5Ff/4diSpw0vqFJan01e3jw9kIRQ0Zt35ARrWViWdu5qTwtUvzmJ
	Wnu+JwEbzcka7M0UPJkKCCeB26cde8+2xKafKL6Xd+8m5HCCEgMn7qb/e/eEIRRN
	891AQqypNWvQSmPXi43nV1498QT2qrhDr707S10wnBu9lX5PWf7fs=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*r:10.10.10, gpg, GPG, H*i:sk:6d5d628
X-HELO: mail.thinkmo.de
Subject: Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?
To: cygwin AT cygwin DOT com
References: <8d66dac6-689d-972f-d06a-f4c1869b6b87 AT waldmann-edv DOT de> <6d5d6289-ea61-cd18-fb48-c5053f292e0f AT gmail DOT com>
From: Thomas Waldmann <tw AT waldmann-edv DOT de>
Openpgp: id=6D5BEF9ADD2075805747B70F9F88FB52FAF7B393
Message-ID: <b6417df6-b205-2172-1af4-7422b25664f6@waldmann-edv.de>
Date: Thu, 12 Jan 2017 18:32:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <6d5d6289-ea61-cd18-fb48-c5053f292e0f@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes

>> https://github.com/borgbackup/borg/issues/1268
> 
> Are your pipe handles in open in binary mode or text mode?  You should
> always ensure they are in binary mode.

That was my first idea also.

https://github.com/borgbackup/borg/blob/1.0.9/borg/remote.py#L188 this
is the place where the ssh subprocess is forked and the pipes are set up.

There is nothing special about binary mode there, but as mentioned in
that ticket, I just tried it out to send binary data over such pipes and
it worked:

https://github.com/borgbackup/borg/issues/1268#issuecomment-239923192

(that \n should get modified to \r\n if in text mode, but it got through
"as is")


-- 

GPG ID: 9F88FB52FAF7B393
GPG FP: 6D5B EF9A DD20 7580 5747 B70F 9F88 FB52 FAF7 B393


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple