X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=BBsrpU/XCPG1H84N0JZ99Ns+JKswEg05/BSIOf2g4bI
	MXYh+wnOA0CnBwTEPdlJiKRID+J7aSY7Nvlm4IyXno5LODbIpqv8Fk3Xmc3ot1n/
	OKlZC1YK+0gAEive67a85Es0rpiCmRh1FAjoPC3D1pC39R8sYig527ng4HRbX7dc
	=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type:content-transfer-encoding;
	 s=default; bh=VYcY/lnTrVYUKSqMlleRcNleEbA=; b=PpdqwnfJ0LqLD4Ts7
	FUfpE5cOG93Lmm/WovvJoPWnkv9MdJ6rMSpDHLYGFOHjwuD1OyHBxP57j3gB5lsH
	atG55ma5E+4k3Tba4wMPjqt0PP9Nk/iB/+SXqqv/xzZZiJOcBMKnM1Jstq+vbRf4
	RPmpUuh8Tj5F3QQegcxKjT2Two=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*i:sk:CAPTiy3, Hx-languages-length:2555, skills
X-HELO: mail-it0-f52.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:content-transfer-encoding;        bh=VIZ7qFB12MHRnE8hqBYFPnM7p15CBaluy9e8uznv4/A=;        b=KDZHFKnEVJK4uaUaIhufQXCmGgi7GeV5xP3Vkr7L3NIUigZ/xfZmlgxYZ/FyrHemQB         tK+6Wfu8MUtraXwBbYmgdnWKO0Xk7SEPtV2dnxNUtQd9//OCvqA4qD3spKhxlRg6b34s         84z9zNqbYWGwdkZTSaIWp1wJXP9kVyWZA3UHRip1IUELeGp601CPNA+PxDGvVyqG/EWb         dm4t7Xu8AVNI129EA6tqIXQtbeJjnJ2P5L/L7Dds8yeQvtpkWZHvT1jqIvwzcXfwGN6D         Qx6/0+O9kZVO0+PD+2BhrCobX1bU6VGVKVmm8gdFW5Ubu13yafHRgqtpCaTwNlD/VkEm         d3kg==
X-Gm-Message-State: AA6/9RmdlY65FUJ3sd6NeUxSeqdslguUpibMvqICYpPFRq1M/hLiFw89Sm2qTtwLDP1CKM7LZdVF3KnLfJjwHA==
X-Received: by 10.36.181.78 with SMTP id j14mr16304082iti.20.1475622888543; Tue, 04 Oct 2016 16:14:48 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAPTiy3NmXx0UGJ1aY3txvAgxffATjvHdxVeURbrbkyPHEpPLxQ@mail.gmail.com>
References: <CAPTiy3O9eEhdgWcdEKkY=Egd+_8WJtxOc6WXjhecr9Du=-f=fg AT mail DOT gmail DOT com> <nsqpd6$tvm$2 AT blaine DOT gmane DOT org> <CAPTiy3NY7oB0g4fg_nmsF8YzzPRdMh2aFnezy5ceoKiM8UWW8w AT mail DOT gmail DOT com> <nsthp6$jtq$1 AT blaine DOT gmane DOT org> <CAPTiy3NzXWSv8+kazpeXYx9EB18nQ+f+S1aSyQcAF4aMrNdqtQ AT mail DOT gmail DOT com> <CA+Fg1xbhdZkexKwEFYmy-BtQdV5ZPYOeJC9K-F0Kdh0V701zBg AT mail DOT gmail DOT com> <CAPTiy3M+C9H41K65e0Dyqqc+AUismTrPGwmoCmNQc=-Gv++NYQ AT mail DOT gmail DOT com> <DD849478-5A57-441D-B6C8-6A1488E80FA0 AT solidrocksystems DOT com> <66dbf3c5-a3d4-a04a-30e8-805750f36a1f AT redhat DOT com> <CAPTiy3NmXx0UGJ1aY3txvAgxffATjvHdxVeURbrbkyPHEpPLxQ AT mail DOT gmail DOT com>
From: Gene Pavlovsky <gene DOT pavlovsky AT gmail DOT com>
Date: Wed, 5 Oct 2016 02:14:47 +0300
Message-ID: <CAPTiy3M5kjksyqVG+f6fJa0grjwnOkNnqDX=TKRMRgBkeKmcgA@mail.gmail.com>
Subject: Re: Native symlinks and setup.exe
To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id u94NFHY6013930

Never mind, I found it's in another repository.
The code looks quite different, adapting the symlink code from newlib
to setup doesn't look straightforward, at least to my limited C
skills.

By the way, if I have an already created symlink, how do I check (e.g.
in a bash script) whether it's native or cygsymlink?

On 5 October 2016 at 02:08, Gene Pavlovsky <gene DOT pavlovsky AT gmail DOT com> wrote:
> Eric,
>
> Before writing a patch it's wise to check if it would be accepted, now
> that your position is clear, somebody might do it.
> I don't think I'm up for the task, but I'd like to at least take a
> look at the sources.
> I've downloaded the git sources and found the link creation function
> is in winsup/cygwin/path.cc, can you tell me where are the sources for
> the setup util?
>
> Thanks.
>
> On 5 October 2016 at 00:04, Eric Blake <eblake AT redhat DOT com> wrote:
>> On 10/04/2016 03:53 PM, Vince Rice wrote:
>>>>> Obviously, a political discussion is required, to decide whether it is
>>>>> ok, as is, or if a change in package logic would have benefits.
>>
>> The easiest way to have the discussion would be to write a patch,
>> instead of debating about different behaviors but then expecting others
>> to do the work.
>>
>>> I don’t see that changing. And, as already noted, setup isn’t a Cygwin program,
>>> so it knows (and cares) nothing about cygwin environment variables.
>>
>> setup.exe has its own untar'ing code (it is NOT forking tar, since one
>> of the packages setup.exe has to install is tar, and it would be a
>> chicken-and-egg problem if setup always forked out to a tar program if
>> it can't first untar the tarball containing tar).  But while setup.exe
>> apparently does NOT currently honor the CYGWIN environment variable with
>> regards to how its untar'ring code should behave on symlinks, there's
>> nothing that prevents you from writing a patch to teach it to do so, and
>> perhaps that patch can even share some of the existing code for
>> cygwin1.dll so that you aren't writing it from scratch.  It should
>> already be clear that code exists in setup.exe that handles symlinks in
>> tarballs - all that this thread is complaining about is that the code
>> doesn't do it the way that cygwin1.dll does it.  But someone has to
>> write such a patch, and preferably someone that cares enough to be
>> bothered by the current behavior (I don't, so it won't be me writing it).
>>
>> --
>> Eric Blake   eblake redhat com    +1-919-301-3266
>> Libvirt virtualization library http://libvirt.org
>>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple