X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type:content-transfer-encoding; q=dns; s=default; b=cLxWTD5Df95QE+n7y5k3IAhnBAOd5YolGU1HI3JBSL0 /PVrZQEXKDj11H0xVPtSSLbLf5gsOqPkuoVNUd1mp7NdaRYjaYKSJtgFTeq2u3yi DxgSs8KAxvDM6f1cVHetBoYTG7JSpADsPHV+rI4nTMvpGehQXUlR9+e+MLKge0j4 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type:content-transfer-encoding; s=default; bh=uS363yb25ZX9NtMb0On20ZeHGH8=; b=el04mLRpwwBIu+xYE rEX/ZXBjvKD+8cNvs+I9+8Hg6QE8aMrcj9k+cNUoeBqPWhSlx4KVsiyMTJ3HCH56 DYFD8Q2fS/Ox5OvF84hKWLl6N/cnrQnCbRo576OM+C6Hd3XpJYiA3J7Gldgu8zHi Enk5MwPRuXJumUubrRND7mEMH0= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=eblakeredhatcom, U*eblake, sk:eblake, eblake AT redhat DOT com X-HELO: mail-io0-f176.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=BR5mhfzIrug+RzUke2JFWeyWxOc7sD6GmI4Z34u/PDs=; b=JnOdp9/LrjnTWuoJuizWa6wj0dBLTI/mviuiuBvYhISM6OaMdvtnzcpO6/mQ/qYAsL dyIC2KG5VfqYe3aA9vniWE7O1dI4jToxSzXadiEjEwWAi+T465Ks98pOlCYIg/8t8HFg 9E0eNQrci+BPj4hqLP70LYyWGl6+N5hmSn0wZufTflGWf29Wq7A1eovXBZ98PArdWL6O bPGwvAIC78wS9TZA2c87HXbgatVS2e0DNrVUk/JqcC/i3BQJSr4dlQgP5HjAXfOxYg8+ y0kME2IEAXRtBfjcJO/iE1dSKxQAsUrYxbmq1e0uCcbTSA40bFzNXwGXjNs8REbK43tO IrWw== X-Gm-Message-State: AA6/9RnJhyE2wXL7N7v6KzizwyMuzBKIIgh4EGMGeJM+I8AQ4ehNIuFcjAy96jcGnf4LI56P7hSN/sEV5MkCRQ== X-Received: by 10.107.3.193 with SMTP id e62mr7155719ioi.55.1475622525760; Tue, 04 Oct 2016 16:08:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <66dbf3c5-a3d4-a04a-30e8-805750f36a1f@redhat.com> References: <66dbf3c5-a3d4-a04a-30e8-805750f36a1f AT redhat DOT com> From: Gene Pavlovsky Date: Wed, 5 Oct 2016 02:08:45 +0300 Message-ID: Subject: Re: Native symlinks and setup.exe To: cygwin AT cygwin DOT com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id u94N9BCE013487 Eric, Before writing a patch it's wise to check if it would be accepted, now that your position is clear, somebody might do it. I don't think I'm up for the task, but I'd like to at least take a look at the sources. I've downloaded the git sources and found the link creation function is in winsup/cygwin/path.cc, can you tell me where are the sources for the setup util? Thanks. On 5 October 2016 at 00:04, Eric Blake wrote: > On 10/04/2016 03:53 PM, Vince Rice wrote: >>>> Obviously, a political discussion is required, to decide whether it is >>>> ok, as is, or if a change in package logic would have benefits. > > The easiest way to have the discussion would be to write a patch, > instead of debating about different behaviors but then expecting others > to do the work. > >> I don’t see that changing. And, as already noted, setup isn’t a Cygwin program, >> so it knows (and cares) nothing about cygwin environment variables. > > setup.exe has its own untar'ing code (it is NOT forking tar, since one > of the packages setup.exe has to install is tar, and it would be a > chicken-and-egg problem if setup always forked out to a tar program if > it can't first untar the tarball containing tar). But while setup.exe > apparently does NOT currently honor the CYGWIN environment variable with > regards to how its untar'ring code should behave on symlinks, there's > nothing that prevents you from writing a patch to teach it to do so, and > perhaps that patch can even share some of the existing code for > cygwin1.dll so that you aren't writing it from scratch. It should > already be clear that code exists in setup.exe that handles symlinks in > tarballs - all that this thread is complaining about is that the code > doesn't do it the way that cygwin1.dll does it. But someone has to > write such a patch, and preferably someone that cares enough to be > bothered by the current behavior (I don't, so it won't be me writing it). > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple