X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:references
	:mime-version:content-type:content-transfer-encoding; q=dns; s=
	default; b=B3LPHkcLFurDcJoRkV3QOjQ5/pNFWTGmaTeJ8vmNEYUj7TDARIAbK
	cIElIxizRicIX3JMteWxyplqwgl0SIDx9+BCX/RvXdwB+0YJNG5FXQ0DX4Dfoh8W
	1A4YgCV7asToSsPcsiXKGbdAw2nvOa2us8QypVqcYuBG7Kj0BmDsGA=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:references
	:mime-version:content-type:content-transfer-encoding; s=default;
	 bh=RynaCQaZAklBAc4DTKIacLdzFIM=; b=fY8ejvR2XWz8TtB1tBRNrchYTNyZ
	NcFzaLtP2lwlCmi9iDlUAAK7q2PtBt2sOeq041omdpG0xOhaypvRnT6VJQzp1szr
	ZkoLAms5ngwZaisND6Q8uRceoxSuPZ7MyACGCCoR6Gwxd2VN9E4Ej5wj2XV4SZre
	RXQL3JPINETBWNc=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=fish, confd, workarounds, conf.d
X-HELO: blaine.gmane.org
To: cygwin AT cygwin DOT com
From: Andrew Schulman <schulman DOT andrew AT epa DOT gov>
Subject: Re: fish Remove unneeded workarounds in /etc/fish/conf.d/cygwin.fish
Date: Fri, 02 Sep 2016 03:08:59 -0400
Lines: 36
Message-ID: <c59isbpd4c86r53sujudjk020bf5j821l4@4ax.com>
References: <CACDsba2MOnZWWe3kqokTie8JqR=fXXCEHan02wu6YHY_RUY5fw AT mail DOT gmail DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Archive: encrypt
X-IsSubscribed: yes

> The cygwin-specific file /etc/fish/config.d/cygwin.fish has this section:
> 
> # Work around an autocompletion bug, where fish tries to execute strings
> # in parentheses in the PATH.  For example it tries to run the x86 function
> # if it sees a PATH component like '/cygdrive/c/Program Files (x86)'.
> # See https://github.com/fish-shell/fish-shell/issues/952#issuecomment-27499216
> .
> # Work around the most common cases here.
> 
> function R --description "print '(R)'"
> echo '(R)'
> end
> function tm --description "print '(tm)'"
> echo '(tm)'
> end
> function TM --description "print '(TM)'"
> echo '(TM)'
> end
> function x86 --description "print '(x86)'"
> echo '(x86)'
> end
> function X86 --description "print '(X86)'"
> echo '(X86)'
> end
> 
> This was to work around fish bug
> https://github.com/fish-shell/fish-shell/issues/952. However, this bug
> was fixed in version 2.3.0. I tested this quickly by removing the
> workaround and fish seemed to complete paths swimmingly (heh).
> 
> I suggest this section is removed from fish-2.3.1 as these workarounds
> are no longer needed.
> Thanks, Matt

Thanks for pointing that out. Yep, I checked and they don't seem to be needed
any more. I'll remove them and put out a new point release. Andrew


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple