X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=cZMRk//pEx3lkuvdgWEJdCo/Uo6Sr9Nf+1RMhAdwgDt88jhyPSix5
	Aw4hSdaiJLzyzo8gZhxccn3JmL4aDrax4BTzNjW+CL8/4bWUssTufNWz8L4OLxxN
	6qOQI+UHEJsbKwtKjmhJPsdiHZNTnyuPs7Iisz6xqssQxuJwLKNGBg=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=AbtiMq92lWSzFF6QiggO8jB9by0=; b=cEL+HsM8Ctq1h0M7kmHU/Fw1gzGa
	jWWT5gv/SNBpLBVMugzAkuTtYgxXPm+/ONMuQdmLzZMq4UV5PfGp1dKH4XybaSid
	6lPT/FBmOXZ7XXWi66Mxl+wXMGeP+zVAe6I16FT4azrM9k1v8AqfHRY9b8maKEZ9
	MsNBagUSrskBIQ8=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-101.5 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1272, H*f:sk:930c261, H*MI:sk:930c261, H*i:sk:930c261
X-HELO: drew.franken.de
Date: Wed, 24 Aug 2016 10:28:13 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Native build fails in winsup/cygwin/libc/strptime.cc because of strtou?l_l()
Message-ID: <20160824082813.GB1493@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <930c2619-1e9e-7275-c245-0a8c4bd92e6c AT t-online DOT de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="R3G7APHDIzY6R/pk"
Content-Disposition: inline
In-Reply-To: <930c2619-1e9e-7275-c245-0a8c4bd92e6c@t-online.de>
User-Agent: Mutt/1.6.2 (2016-07-01)

--R3G7APHDIzY6R/pk
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Aug 24 00:19, Hans-Bernhard Br=C3=B6ker wrote:
> Hello everyone,
>=20
> building the git version of cygwin natively on Cygwin-2.5.3, I'm running
> into a problem with strtoul_l / strtol_l. winsup/cygwin/libc/strptime.cc
> fails to build:
> [...]
>=20
> Looking at the .ii file, it appears __GNU_VISIBLE is not active for this =
C++
> source file?

Yes, we discussed this already yesterday on the Freenode #cygwin-developers
IRC channel.  The reason is that sys/cdefs.h is included before winsup.h
is included, the latter defining _GNU_SOURCE.

However, it appears that I don't see this problem when cross building on
Linux.  It only shows up in a native build.

After some digging it turned out that in the cross build case _GNU_SOURCE
is predefined when using the -xc++ option:

Native:

  $ x86_64-pc-cygwin-c++ -xc++ -dM -E - < /dev/null | grep GNU_SOURCE
  [no output]

Linux:

  $ x86_64-pc-cygwin-c++ -xc++ -dM -E - < /dev/null | grep GNU_SOURCE
  #define _GNU_SOURCE 1

That's pretty weird since _GNU_SOURCE is not supposed to be defined
by the compiler or C preprocessor at all.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--R3G7APHDIzY6R/pk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXvVqdAAoJEPU2Bp2uRE+gppwP/AwD4myWPb0Si9JFg4lkVffG
tsptJ1GjJhDCtncFvULkeD+KRn26RgaBNZoJxDkofTkhX1HdAfQYI5iwelTXDeYu
ktHx7P4HDsjeAAYndj/olGr6S6N1zFd1hZ2hrHtM33JLN4Yo3LgNfqGiBlYXvTCE
c4G0DkbTdrqly1KE18zv9IbulWp77SLvT6pHVuY5WM2Jz+KlTb9RPX62DDofYFEF
jrpQG7xzs0O83FEpHPqEfw8l9ZnOg0hEs6ZdMj6vbOs4U5u3cmh29BCvRCJwl5K6
zSuRg1DeeQ5N/9WQ2SxxsVWmas/KaGSKEmDOywlOrSBBymNq1edDhqTZwcCTDQ4+
kD+V0Kk+OKoZ1YT7VyylIzZe5Fdqjowai4lEaXePuoDIylfGmLllnnzD+Ul7eZ7M
6PwQS7NL3YfrPOWjeRSWmGz4Yo2uAPkEk3MlroNRkLuka0fYa3i+b+HOcVcEwZiC
Ui95wMC8V768QQt9phtnCTCWsKQfkJTWWGFbmm0oFxexpLAxJjH4Ti20CROi8/ja
RXlTNCWhDgxhN2bJZWBHkpLfHKq42jHDccKOnG54XHE5auKU9afmFCMIlCoKA8KU
GBd+TVW43yi/RE2SXJ4sqP5Byce8poQ6SeZZZwSvz74yxWme5TQyz7bfrPPbcDh8
8lcYaauwr/MxBzaKN7GQ
=+s9M
-----END PGP SIGNATURE-----

--R3G7APHDIzY6R/pk--