DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=IRBvQ7ZQzh3d+N7/C0ncmyCMvlsu9b6JCcPQdpIGxHcCJCF5kxRZG
	EwS+txSuHoaDJK1tUWw5SdLJopFu+EyOrIxye7U+aWfieGqwW69mb8afvSHJSFfU
	cA4tHoLqBs+gXaw6lpmkTXVNmxCBCvRTlBqP/JffcPs8z+sNLLwbg0=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Sun, 21 Aug 2016 12:30:28 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: GIT source build failure: wcwidth.c::_wcwidth misses __locale_cjk_lang()
Message-ID: <20160821103028.n7via5q3t4xbusjx@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <9cd85e4f-ac3a-cd76-71bf-445d7676a312 AT t-online DOT de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="tdliegzaoc2r2mut"
Content-Disposition: inline
In-Reply-To: <9cd85e4f-ac3a-cd76-71bf-445d7676a312@t-online.de>
User-Agent: Mutt/1.6.2-neo (2016-07-23)

--tdliegzaoc2r2mut
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Hans-Bernhard,

On Aug 21 00:09, Hans-Bernhard Br=C3=B6ker wrote:
> Hello everyone,
>=20
> FWIW, I can't get the current may git clone of Cygwin to build on the
> current release version of itself: (64-bit "Current" on Win10):
>=20
> /home/hbbro/prg/cygwin/bld/x86_64-unknown-cygwin/newlib/libc/libc.a(lib_a=
-wcwidth.o):
> In function `__wcwidth':
> /home/hbbro/prg/cygwin/bld/x86_64-unknown-cygwin/newlib/libc/string/../..=
/../../../newlib-cygwin/newlib/libc/string/wcwidth.c:301:
> undefined reference to `__locale_cjk_lang'
> /home/hbbro/prg/cygwin/bld/x86_64-unknown-cygwin/newlib/libc/citrin/../..=
/../../../newlib-cygwin/newlib/libc/string/wcwidth.c:301:(.text+0xa4):reloc=
ation
> truncated to fit: R_X86_64_PC32 against undefined symbol `__locale_cjk_la=
ng'
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:670: cygwin0.dll] Error 1
>=20
>=20
> Adding
>=20
> 	#include "../locale/setlocale.h"
>=20=09
> in libc/string/wcwidth.c appears to fix this.

thanks for the report, but I can't reproduce this.  I can build Cygwin
fine natively as well as on Linux, with and without optimization.

gcc -H shows how setlocale.h is already included via the inclusion of
./local.h --> ../ctype/local.h (simplified for readability):

  newlib/libc/string/wcwidth.c
  . newlib/libc/string/local.h
  .. newlib/libc/string/../ctype/local.h
  ... newlib/libc/string/../ctype/../locale/setlocale.h

This even works for me when building from within the source dir, which
isn't a supported build configuration.

So why does this fail for you?  I wonder if some compile time settings
are responsible for this problem.  How do you build Cygwin from the git
repo?  Do you use some special debug options or something like that?

Btw., there *is* a minor glitch in string/local.h.  The extern
declaration of __locale_cjk_lang should have been removed when changing
__locale_cjk_lang to an always inline function in setlocale.h, but it
has no negative impact on my builds.  I just removed the declaration.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--tdliegzaoc2r2mut
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXuYLEAAoJEPU2Bp2uRE+gstgP/3mR5UfKqt6ZTIr/2XLxdsJB
xKS0/nc+JcJciaUzsydMkDP9HYPpDTMRZXYUkc65iXFcMR1bO6APjC7dS9DLQluR
h6wjiNBvHXk/fs+MrnS71ZPbhN3Wvp5OPuzaL/x821P9sqsH/Uqhf5cb0B8P1tzJ
CEjwyyx3v9TF7puuN8pTRsoJA7dNqWN4O1vdvjOaXQMm8LNWbsUNpYStjUnFDL/Q
T6y50jmYc80789CdwZ3wAGpw4NNteBH5s/Y6IY76WvtQi7G1gXRvjz39MSE2mn/v
wj2T0JR7CiEbcPtRZm4BLPS4F1d09sY9gCnd0FkL26at0YgZos73supY2mC0d0gR
e71NtWJfJ3RGMu+bLfckVFZi+c+WxdQZaq/oP/SC1lCQudbQ79XtcZK/4n4vYJKY
vRL0+GCtzhNfHVDfHZ2KKcmX9tIpHyFER/mZwZSOX0rsr543PorKtEyyibAx++Xy
6TQcWUJlSwmQuF8curAlCRCh1gxzH8Z0K5qW62+yDvDs3134+H4A4q0sbHYQTpOm
MvgxG0DelxgKR+fjDM0seRulrD1FrNINjTh1ae1kegiyp3IqgDCkC+vLiPhR/Kng
bdTjQ5SJir2/d6xfOfXImt0O0hHQOp9/2q1LGDgqELnZZm0yDPD6Dxv+nBZ59ymI
XCGLjLwcFUoEOmrMh4fR
=zMUn
-----END PGP SIGNATURE-----

--tdliegzaoc2r2mut--