DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=cz/3ASYhCPj2mNS0c14lfbJfnZMBD9AxpTkA5OhO3niEOvqHNKQF6
	7EEsQcCZvNF2VlW5PeLOXcU6KQ9bJdT1vFLo2a9YMW3bqKYIGwL8DCBVayDefxZo
	XXbxkGWkz/AnSSMRvdx/G7AtsA7B7MoQvmF2zUWPBmPVwBRg4iiVbM=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Mon, 20 Jun 2016 10:20:10 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: gettimeofday not defined
Message-ID: <20160620082010.GA3667@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <loom DOT 20160619T212652-82 AT post DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
In-Reply-To: <loom.20160619T212652-82@post.gmane.org>
User-Agent: Mutt/1.6.1 (2016-04-27)

--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Stephen,

On Jun 19 19:30, Stephen Sheldon wrote:
> Sometime in the past several months MPlayer stopped compiling for Cygwin.=
  There
> was a complaint about gettimeofday not being defined.  The failing file d=
id
> include sys/time.h, which contains a definition.  I found one similar rep=
ort
> on the Cygwin mailing list.  I noticed that MPlayer was putting the macro
> "-D_ISOC99_SOURCE=3D1" on the gcc command line.  I replaced it with
> "-D_DEFAULT_SOURCE=3D1" and MPlayer compiled.  It also works without any
> ...SOURCE.
>=20
> Here is a small test case to show the problem:
>=20
> //#define _ISOC99_SOURCE 1
> #define _DEFAULT_SOURCE 1
> #include <sys/time.h>
>=20
> int main() {
>     struct timeval start;
>=20
>     gettimeofday(&start, NULL);
> }
>=20
> It compiles with _DEFAULT_SOURCE or without any ...SOURCE. I hope someone=
 can
> examine the very complicated #if statements in sys/feature.h and sys/time=
.h
> and tell me that whether I should raise the issue  with the MPLayer folks=
 or
> not.

As you might know, the feature test macros in newlib/Cygwin have
been heaviliy revamped to be more aligned with standards.

I examined sys/time.h and it turned out that gettimeofday was
accidentally guarded with __MISC_VISIBLE || __XSI_VISIBLE, while
it's not guarded at all in GLibc.  I fixed that in git so this
will be fixed in the (very soon) upcoming next Cygwin release.


Thanks for the report,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXZ6c6AAoJEPU2Bp2uRE+gj3oP/iA4E70Salyh/UUzZs1pzZSs
yZAchn6dY1Xk/vasg9U2FKBN6mMreKnJXuX/ER1A5d8NkBDoPXrQ0dPXU2d36Rzj
aFWuXLlblN43jhPx6BloDaPZ82Nxpai4kKsN/pZ7tzI+aN0HFWbdc/DIRzHTsH64
1mQCgD4zsPPRxfBT7Hb8Z4HLSZs/bbvqH004mKEgchuS/3MmteJC1Cn+IotcXIYR
oRPlSRUAO9x/kmIDXoFC4D7Hf9w8jGqZnWqqV3vuRCgUcCcELAlgJwTIfXaZrmem
SMpn/B0jnEQr4gid9ZAWpOlHd+2pvLvtXAxXGIhM+DgUJbhmaXfahg0/gOdEwRAu
oRPcbE2zTl4bUcZYV251cXBkMZZSAF+68bGyrQXuMQo1i5pyDoW/WltK57ThVXnm
BsyQUxcxtpNX0lQ5MNFU6gBT4On4I9Zvn6uug7U0sT9CISduXyOOMyLy0mhzqDIG
1OIw7nokpPgiOKxacp7cXFkQGVXL6fjtNe2AGSnsiYpL0rRJKubBJQSiqYh9qqnv
un4eA1eNisFVizKn2TwrcWeo9YTsUa8++KRauon6qYHrPejAoLvRHhURYyUQhgUq
fS8EoXpNppgMcS80Or6mmaTbFPY637B0HZTzkpAXOBRgG1CQwYF6ZfXVPm1jnpwJ
3PUMlkoOfHgtEmOKF6mX
=cABs
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--