X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=cthMbt66tLtlwL9f
	GziTxz3ONDhAxObNk1caWif8yxmkqQMrWYnrLJDwLEF8eOZY/pOl2bVN6yMqYSLG
	7mzl6RTMnhlzySKaSD6Kpfw0sxIsY7eg1VpIP0oJU/cfPUrCUAsmOH0srfRclrM6
	jbMFJW+w0eOcZn95GQ2zZCek0Jc=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=TNIY0Lpt7i6yUtIGKAacv1
	FLuM0=; b=vnDUDN+mpW7W+yxBoPsKzRAsG+5vW5VfKEGG1Fr4hbyRGF1R9CMwu/
	+WbAnHuuXcnA1r0lB6+PZac1rBC0SfH+B4Vr1VCn5kPQz4/4irTbQ35mh9p3pwZT
	tmzlmd45ldY4MRHizxkotQ0ESahx9p5i/rgf8Tm2vDtEcAwwvqY8A=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*M:cygwin, H*Ad:U*yselkowitz, Hx-languages-length:1312, H*F:U*yselkowitz
X-HELO: mx1.redhat.com
Subject: Re: add fish to /etc/shells (base-files)
To: cygwin AT cygwin DOT com
References: <pe94jbtrjf32qn2u0mbtrful36o1trjguj AT 4ax DOT com> <ngvnm4$tms$1 AT ger DOT gmane DOT org> <lro6jbph7mumea7qcf0jbdnut23kujk3i4 AT 4ax DOT com>
From: Yaakov Selkowitz <yselkowitz AT cygwin DOT com>
Message-ID: <cf899cc5-4267-3f59-478e-b7ba5361e2eb@cygwin.com>
Date: Wed, 11 May 2016 14:06:16 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <lro6jbph7mumea7qcf0jbdnut23kujk3i4@4ax.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes

On 2016-05-11 12:09, Andrew Schulman wrote:
>> Am 10.05.2016 um 20:19 schrieb Andrew Schulman:
>>> Achim, can you please add /bin/fish and /usr/bin/fish to /etc/shells in
>>> base-files?
>>
>> I seem to remember that this was discussed before.  If you could perhaps
>> look up that discussion and fill me in what the conclusion was last time
>> around?
>
> Hm, you're right, it was discussed before:
>
> https://www.cygwin.com/ml/cygwin/2014-02/msg00696.html
>
> I don't know if there was consensus, but the last word there from CGF was
> that shell packages should run a postinstall step to add themselves to
> /etc/shells.

While I'm always ready to reconsider previous decisions, this is how it 
appears to be handled in Linux distros.  The implication thereof is that 
(once all packages have been adapted) the default /etc/shells should 
only contain those shells available by default (namely, sh, bash, and 
/sbin/nologin), e.g.:

https://git.fedorahosted.org/cgit/setup.git/tree/shells

(except that /sbin != /usr/sbin on Cygwin.)

> That seems reasonable. There are questions about the right way to do it,
> but I'll ask those in a separate thread.

Probably best if we have a cygport function for creating the necessary 
postinstall and preremove commands.

-- 
Yaakov

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple