X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=ASKF/3NNTtiwxlI5P0CXRMIUA/uEgG0thZ7W2KGqOwCVzL6gpkPD1
	QBsDjwdRD1iMGuxlWG1l9qD6eAeSxp5DLQIeFE6Jog02BDes0N5p5U8olwvX6uSv
	CHP+KsHDXmbaWNnu0KmU4MAKqU9qBHrnEOk3Xvi4b2wQCVHX9oPN54=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=i44JmKO5wc1CqGuVqJ+mlstc/1U=; b=EymeSgkWnxy8UT7OCIf2UAGo82Q6
	HTgbhg9qkE2klP6vNDyYRuXG0I8rfYVHF0ZH4rKOMM0k/1neKpxeiH5vp9OFW4SG
	27xH/M0vuzBeQYFFL31e5FK/3v5Q8wYWEIPgj17BNXXoeZEhdFxB6DtDYcqqs1Qw
	TqKxv0N/jGSgKy4=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-94.7 required=5.0 tests=BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=H*R:D*cygwin.com, H*R:U*cygwin, Hx-languages-length:1892, H*f:CAFo71_57DCPp
X-HELO: calimero.vinschen.de
Date: Mon, 8 Feb 2016 15:36:30 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Problem with new acl code and cdrtools
Message-ID: <20160208143630.GG12975@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg AT mail DOT gmail DOT com> <20160208131835 DOT GC12975 AT calimero DOT vinschen DOT de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg AT mail DOT gmail DOT com> <20160208141015 DOT GD12975 AT calimero DOT vinschen DOT de> <CAFo71_57DCPp=DF9FzH1=suFuu-J4MAoObC8y=3nVujGHThqJQ AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="oOB74oR0WcNeq9Zb"
Content-Disposition: inline
In-Reply-To: <CAFo71_57DCPp=DF9FzH1=suFuu-J4MAoObC8y=3nVujGHThqJQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

--oOB74oR0WcNeq9Zb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb  8 16:13, Ismail Donmez wrote:
> On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen
> <corinna-cygwin AT cygwin DOT com> wrote:
> > On Feb  8 15:31, Ismail Donmez wrote:
> >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
> >> <corinna-cygwin AT cygwin DOT com> wrote:
> >> > On Feb  8 12:01, Ismail Donmez wrote:
> >> >> Hi,
> >> >>
> >> >> cdrtools has some code to detect Solaris style ACLs:
> >> >>
> >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
> >> >>      defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
> >> >> #   define  HAVE_SUN_ACL    1 /* Sun UFS ACL's present */
> >> >> #endif
> >> >>
> >> >> Since cygwin still seems to be defining aclfromtext() and acltotext=
()
> >> >> functions (which are not defined in POSIX) cdrtools thinks this a
> >> >> Solaris-style system and get up getting a compile error later on.
> >> >
> >> > Probably due to including sys/acl.h.  Does swtiching to cygwin/acl.h
> >> > help?  Or changing the above check to prefer POSIX ACLs over Solaris
> >> > ACLs?
> >>
> >> This is a generic code so I don't want to add a cygwin specific
> >> dependency there. Is there a preprocessor definition for cygwin
> >> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
> >
> > If you include cygwin/version.h you could use the version definitions.
> >
> > Alternatively we could allow to use the Solaris ACL functions even if
> > only including sys/acl.h, given some macro:
> >
> >   sys/acl.h:
> >
> >     #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS
> >     # include <cygwin/acl.h>
> >     #else
> >       [...POSIX definitions...]
> >     #endif
> >
> > Would that help?
>=20
> That should help, I cook a patch and send to cdrecord maintainer.

Wait, that's a bit premature.  I'm not even sure yet if the macro name
is ok.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--oOB74oR0WcNeq9Zb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWuKfuAAoJEPU2Bp2uRE+ghQsP/1LGrIPpghyob4SRNy/WRXsX
Zg6yFOnVJvyNhI4Se3nuxzST4+862i+mMshxvPS34u+Oaxcz3Kj+slAcXpivtaAt
97mznfHYMjhYpTBRrc7zgSDBwcps82TgsiKV6q4bAePt0iprLXieHJgC2rRYPlEK
IPoZGQfsatU5tXtpORmw+Xgkb3R4pK1Feh+notN+zlFUiIHu8Y2RdgC3TEj9gPnU
uhiQTy7Oc/rVxS2xIomJBaHA1Htw9TjhGg/wr9GgVKXdJ9z0hO0v9PgzoSv6UX/H
uJkiVrYXjkeqeduiqekX+IRc7QbqoOL9oP9XeabUVIHMck5SMVLQd6KEfnyhoSxp
qBndgeE3rF4sQwN/CCqrQ3rqbmBHylRrhL5R6NtG0/1d6TZuxPnocUZh3SPYdoGb
I0yYRGd9tiWtMrzV9Q2RVBW/KV1wh8ktF+IEfKj590SWHvvZMT8vkMOlatGUpwS1
/qixgHZofU2F0B8F3Z1Pb/MZy15SnWct9WbX+jkzpyDEUi9GViMAGKAuxrKpx49I
yC/tyvZrH6sHI4LT5sHznXcyE12dlj7oiYk14INlvA7fGxiDrFuBwY8wltI6ZfNu
rcHbQ5wADgzwa0jqhGBnbSk2/xZ7UIIx6BrSFOOTS3krP6pD+yq+Wkdxa1h7RVVf
GuO4cvhEbH5oMJaIMADS
=teve
-----END PGP SIGNATURE-----

--oOB74oR0WcNeq9Zb--