X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=uiP6luP
	zDSzz9+KPeWQYfTdIcCNbDlgF+c268MGwiNV+g3Huyj5NSQrPjdPmthf58h0KCWn
	Fczd/YkqBmjDyAFjhbj+hx5UJAnwLJxhGaHElNf0GF33i+razGv7wCSVOyyRfyVT
	kac3NTDPsc6kxWsf3Bxz8lCO3vBdCqGiaAG4=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; s=default; bh=Eh3KSzcZkP1/d
	COOJ+byZNLmQ8E=; b=PElA4TpaTMJYCDGt3cvsd75JoFzNhAkk3LDBI4QG6cNJI
	tFIJRS1IvKuX6hlJmhFIl/OU0DH+T4y7wIbC1J4MkyZUv7LaEUFMoU8tn8urL6P1
	jCAZDbPsoB5ngWzV6PRam2xfRuad+E1vt31NdvmwLVmjlnyl+poEIerH62TPGY=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=getfacl, aclh, UD:acl.h, acl.h
X-HELO: mail-wm0-f45.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:content-type;        bh=ekot3IFe1ZcpugQymJOSN1JN9c5Z2/c5jo4E1jFfPaU=;        b=UlRnT3c/oa0Z4fnPGcVB59kjUu/AyoHWTT8Ejryarx5ealaDYglTK/smZ2g192LiIO         606fqH5Pt2YlMJwypeS7LpkQ1GdG35lly/IX8F+xjr9i1E7428Ry3GWN8esr4TXNIkaO         ZjiG31mH8JuySRLncWq0JCvgao+KQsLmF9dAMBalSKLjuahwACHdHD9P788EJ7lkI958         LjAvx5aESYr0Vdo8Rz07naVGgAIIv/ddXr+zjoPtBKYCFgQLozkYtSkOQl8J5yeeQtB2         C7A0hJFlsnj8v2OhukJpeT68qhgQZcdkgVKlCbjxqkBGnSHM/w593Kmg3os1nB01P8OQ         le4Q==
X-Gm-Message-State: AG10YORKaAM9UPXTLK663C/Qliig7ZtvmdwVrbDNNoSJyUGYaITxHxZwwnHVytrmRNj8x8xNLr1aBoVtb0jq3g==
X-Received: by 10.194.192.198 with SMTP id hi6mr27819850wjc.141.1454938299407; Mon, 08 Feb 2016 05:31:39 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20160208131835.GC12975@calimero.vinschen.de>
References: <CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg AT mail DOT gmail DOT com> <20160208131835 DOT GC12975 AT calimero DOT vinschen DOT de>
From: Ismail Donmez <ismail AT i10z DOT com>
Date: Mon, 8 Feb 2016 15:31:09 +0200
Message-ID: <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg@mail.gmail.com>
Subject: Re: Problem with new acl code and cdrtools
To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes

On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
<corinna-cygwin AT cygwin DOT com> wrote:
> On Feb  8 12:01, Ismail Donmez wrote:
>> Hi,
>>
>> cdrtools has some code to detect Solaris style ACLs:
>>
>> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
>>      defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
>> #   define  HAVE_SUN_ACL    1 /* Sun UFS ACL's present */
>> #endif
>>
>> Since cygwin still seems to be defining aclfromtext() and acltotext()
>> functions (which are not defined in POSIX) cdrtools thinks this a
>> Solaris-style system and get up getting a compile error later on.
>
> Probably due to including sys/acl.h.  Does swtiching to cygwin/acl.h
> help?  Or changing the above check to prefer POSIX ACLs over Solaris
> ACLs?

This is a generic code so I don't want to add a cygwin specific
dependency there. Is there a preprocessor definition for cygwin
version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+

>
>> Since we are switching to POSIX ACLs it would be nice to remove
>> Solaris-only ACL functions.
>
> We can't do that for backward compatibility.  The Solaris function
> have to stay available, not the least for Cygwin's getfacl/setfacl
> which still use them.

I see, thanks.

ismail

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple