DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type; q=dns; s=default; b=Ai
	B881Fx1y/OqsYY/FueS7hfQ0PGCUKuthejD6WkPtPlPOj84dJgQaJuLdopSK5MeC
	MBGQY4BStt3M+SeUsKEzNLUxPYrpldCkHhELxntcd0opiK9IHFN883ydL2lHsU9V
	lopjBgO0Ze9m1imwAaqVjUPd85unciMy66qyC3tOM=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
MIME-Version: 1.0
In-Reply-To: <CAO1jNwv+Lza40TnN+woA_R1HpsnEZZvYda2f8A49NE+xvKUCGw@mail.gmail.com>
References: <56AC2C35 DOT 9060903 AT cornell DOT edu>	<CAO1jNwv+Lza40TnN+woA_R1HpsnEZZvYda2f8A49NE+xvKUCGw AT mail DOT gmail DOT com>
Date: Sun, 31 Jan 2016 22:17:17 +0000
Message-ID: <CAOYw7ds-N=f+JCn-2rtFqOyahmA_M9mVNwv1CZH6__M-K7ht1A@mail.gmail.com>
Subject: Re: cygwin_conv_path sometimes removes trailing slash
From: Ray Donnelly <mingw DOT android AT gmail DOT com>
To: cygwin AT cygwin DOT com
Content-Type: multipart/mixed; boundary=001a11401eba966864052aa8a147

--001a11401eba966864052aa8a147
Content-Type: text/plain; charset=UTF-8

On Sun, Jan 31, 2016 at 11:38 AM, Jan Nijtmans <jan DOT nijtmans AT gmail DOT com> wrote:
> 2016-01-30 4:21 GMT+01:00 Ken Brown:
>> I'm using cygwin_conv_path to convert Win32 paths to POSIX paths, and I'm
>> puzzled by the conversion
>>
>>   d:/ --> /cygdrive/d
>>
>> without the trailing slash.  By contrast, we have
>>
>>   d:/foo/ --> /cygdrive/d/foo/
>
> This came up before:
>    <https://cygwin.com/ml/cygwin/2015-10/msg00048.html>
> I had to workaround it in tkimg.
>
> It's easy to workaround in your program, but - indeed -
> that shouldn't be necessary. I too would expect that
> when the input contains a slash, the output should too.
>

I've attached the patch that we use on MSYS2 for this. We found
ourselves patching projects all over the open-source landscape
otherwise so fixing it once and for all seems sensible. Note however,
a full fix also requires another patch that I posted two years ago [1]
that Corinna chose not to apply. In the two years since, we've yet to
find any issue with that patch. I will rebase it shortly in-case
there's any interest in reconsidering it.

[1] https://cygwin.com/ml/cygwin-patches/2014-q1/msg00010.html

Best regards,

Ray Donnelly.

> Regards,
>      Jan Nijtmans
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--001a11401eba966864052aa8a147
Content-Type: application/octet-stream; 
	name="0001-Don-t-remove-trailing-slash-from-root.patch"
Content-Disposition: attachment; 
	filename="0001-Don-t-remove-trailing-slash-from-root.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ik33x7sv0

RnJvbSBkYTkyYjhmYzNiZWIzYWVlZGQ5ZDMwYzZkMjk2ODFlZDljNDhmNmRh
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSYXkgRG9ubmVsbHkg
PG1pbmd3LmFuZHJvaWRAZ21haWwuY29tPgpEYXRlOiBTdW4sIDMxIEphbiAy
MDE2IDIxOjA2OjEyICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgcmVt
b3ZlIHRyYWlsaW5nIHNsYXNoIGZyb20gcm9vdCAoJy8nKQoKRml4ZXMgcHJv
YmxlbSByZXBvcnRlZCBvbiB0aGUgQ3lnd2luIG1haWxpbmcgbGlzdCBhdDoK
aHR0cHM6Ly93d3cuY3lnd2luLmNvbS9tbC9jeWd3aW4vMjAxNi0wMS9tc2cw
MDQ4MC5odG1sCgogICAgKiBwYXRoLmNjIChwYXRoX2NvbnY6Y2hlY2spOiBu
ZWVkX2RpcmVjdG9yeSA9IDEgd2hlbiBzaW5nbGUgc2xhc2gKClNpZ25lZC1v
ZmYtYnk6IFJheSBEb25uZWxseSA8bWluZ3cuYW5kcm9pZEBnbWFpbC5jb20+
Ci0tLQogd2luc3VwL2N5Z3dpbi9wYXRoLmNjIHwgNiArKysrKysKIDEgZmls
ZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKykKIG1vZGUgY2hhbmdlIDEwMDY0
NCA9PiAxMDA3NTUgd2luc3VwL2N5Z3dpbi9wYXRoLmNjCgpkaWZmIC0tZ2l0
IGEvd2luc3VwL2N5Z3dpbi9wYXRoLmNjIGIvd2luc3VwL2N5Z3dpbi9wYXRo
LmNjCm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggZTQ5
ZjE4MC4uNTA4N2FkZgotLS0gYS93aW5zdXAvY3lnd2luL3BhdGguY2MKKysr
IGIvd2luc3VwL2N5Z3dpbi9wYXRoLmNjCkBAIC03MzMsNiArNzMzLDEyIEBA
IHBhdGhfY29udjo6Y2hlY2sgKGNvbnN0IGNoYXIgKnNyYywgdW5zaWduZWQg
b3B0LAogCSAgICAgIG5lZWRfZGlyZWN0b3J5ID0gMTsKIAkgICAgICAqLS10
YWlsID0gJ1wwJzsKIAkgICAgfQorCSAgLyogU3BlY2lhbCBjYXNlIGZvciAi
LyIgbXVzdCBzZXQgbmVlZF9kaXJlY3RvcnksIHdpdGhvdXQgcmVtb3ZpbmcK
KwkgICAgIHRyYWlsaW5nIHNsYXNoICovCisJICBlbHNlIGlmICh0YWlsID09
IHBhdGhfY29weSArIDEgJiYgaXNzbGFzaCAodGFpbFstMV0pKQorCSAgICB7
CisJICAgICAgbmVlZF9kaXJlY3RvcnkgPSAxOworCSAgICB9CiAJICBwYXRo
X2VuZCA9IHRhaWw7CiAKIAkgIC8qIFNjYW4gcGF0aF9jb3B5IGZyb20gcmln
aHQgdG8gbGVmdCBsb29raW5nIGVpdGhlciBmb3IgYSBzeW1saW5rCi0tIAoy
LjUuMwoK


--001a11401eba966864052aa8a147
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--001a11401eba966864052aa8a147--