X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:references:to:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=xRyVFR9NJrt7+Jz6
	0EbQf/0r/am+j5wLcLVDN4/2jGtks8IbYaNUvir1QP7loGUqpjywMr3MjziqEhPA
	QfOYtP7WPOTCGHCkZGDUfzJOb7XmhS31eiVn0oOEV+2lTlxLHTbRBeEK5AGsCwoW
	F2EECUyXIfgvnOxkTk2Ns9VL1wA=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:references:to:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=0a0rR+VhT7n4+yUsJ7JOF3
	TQ2+I=; b=Fnz5qQXi/Fk3H+qwa+w6X4uYZMIPssf0NvQfpL3HpLiLYczbF2Jbqt
	w1OcED2xog70Qm5hXaCnJj8BNNXKC/bf2v3UDYhK0g/lmGa/7YAzz+Be4+KdodfS
	wyMb1JSSN2N0rV3INicj2FSyj/sxogwcJIhEmN/T18LTs3FDLlMSE=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2
X-HELO: m0.truegem.net
Subject: Re: Cygwin multithreading performance
References: <CABPLASTtRK4mNxh0M_AnZgjJQ15kWPx+L=U=VCU3Wwi7jV_57A AT mail DOT gmail DOT com> <564E3017 DOT 90205 AT maxrnd DOT com> <CABPLASTLrH_udLuu2F-m5P6dkENW1Z4YHEudp4NG0-FGLJgPMg AT mail DOT gmail DOT com> <5650379B DOT 4030405 AT maxrnd DOT com> <20151121105301 DOT GE2755 AT calimero DOT vinschen DOT de> <5652C402 DOT 7040006 AT maxrnd DOT com> <24780-1448274431-7444 AT sneakemail DOT com> <5653B52B DOT 5000804 AT maxrnd DOT com> <20151126093427 DOT GJ2755 AT calimero DOT vinschen DOT de>
To: cygwin AT cygwin DOT com
From: Mark Geisert <mark AT maxrnd DOT com>
Message-ID: <5656DDEF.9070603@maxrnd.com>
Date: Thu, 26 Nov 2015 02:24:47 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39
MIME-Version: 1.0
In-Reply-To: <20151126093427.GJ2755@calimero.vinschen.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Corinna Vinschen wrote:
> On Nov 23 16:54, Mark Geisert wrote:
>> John Hein wrote:
>>> Mark Geisert wrote at 23:45 -0800 on Nov 22, 2015:
>>>   > Corinna Vinschen wrote:
>>>   > > On Nov 21 01:21, Mark Geisert wrote:
>>>   > [...] so I wonder if there's
>>>   > >> some unintentional serialization going on somewhere, but I don't know yet
>>>   > >> how I could verify that theory.
>>>   > >
>>>   > > If I'm allowed to make an educated guess, the big serializer in Cygwin
>>>   > > are probably the calls to malloc, calloc, realloc, free.  We desperately
>>>   > > need a new malloc implementation better suited to multi-threading.
[...]
>>>
>>> Someone recently mentioned on this list they were working on porting
>>> jemalloc.  That would be a good choice.
>>
>> Indeed; thanks for the reminder.  Somehow I hadn't followed that thread.
>
> Indeed^2.  Did you look into the locking any further to see if there's
> more than one culprit?  I guess we've a rather long way to a "lock-less
> kernel"...

It took me a while to figure out what I wanted to see in the strace 
logs.  I ended up adding a small patch to pthread_mutex::lock() to 
record a timestamp on entry, and also log that in the pthread_printf() 
near the end of the method.  With that I'm able to see how long a thread 
has to wait for a lock before actually acquiring it.  That will allow me 
to unravel the sequence of locking and unlocking and give stats for all 
threads and/or locks.  That could be generally useful to evaluate 
different memory allocators or different locking strategies using the 
same allocator.

But that is just groundwork to identifying which locks are suffering the 
most contention.  To identify them at source level I think I'll also 
need to record the caller's RIP when they are being locked.

In the raw strace data I'm looking at for the OP's testcase, I can see a 
lot of cases where a thread wants a lock but is delayed for milliseconds 
before getting ahold of it.  I can't say ATM whether it's just one or a 
few locks suffering this way, or more.  Work continues :).

..mark

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple