X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:references
	:mime-version:content-type:in-reply-to; q=dns; s=default; b=obLQ
	YjzS8hRvwGtpfy1S/hwktbj+ofGL415UT3iky5f5WGLX17ZHC2BXDR7GSWXkgUGr
	ex+PLMRJL+XSklrpRi+KkpQ6L3rTn/grZFIEopyUvrYupXdLLPMJvh7lnD61D8Mm
	/g1+Eekqk/7N2Vw+oMNKVL1RKiNCIEfDPf8fXXM=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:references
	:mime-version:content-type:in-reply-to; s=default; bh=OOnFrtx7cX
	unxHsU42cdm4DMTqc=; b=hKCnvoH/j+DcYqvcGx/d0/Pdc9bepvuTvzYkrnVJ0I
	yYiPots0kqROa9kyg8Ww4uhJ+LhnbD/Hu7qEaTitcav4xW6oTpL3ykOAkQohRtu5
	s1W1HRM3C71FTtUJkdvQqND8zEz1DS6xyzarwyH5IJRMyXDP3USydYWTKxZKqUhA
	Q=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wm0-f41.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:date:from:to:subject:message-id:references         :mime-version:content-type:content-disposition:in-reply-to         :user-agent;        bh=So1sBc7mdlshhF7hzWCjkoeU+Hv1cGwstt7SCiARrp4=;        b=NPsl7RTt12lGN6O2GxFwvy0CW5XvGsNMinIKsbx3Y9Ri1P6z+DZKJKXybvr1yf7fR+         PwXn6kx4XGZV4g3nBHm70/1ZeVU/q6XM60aOBwaIOIlUJIkys70mYYmmRKog02b1opu+         zntRAWMDg2bf3Kw1o2IXS1MXLSY/qDqD9fHMOpz6j1JkbqR7lWwe5WuFyBtgLK16eSVn         x0LLJcNV3PbonVTPECTxYr7NPagmCY/I6lMaG2IxE/OQpnzaS+QqrKiLhILquUEXySnn         wiwXkEccWMfSeX4+PivjJoggE4mZQ/1u1c/N2jMp/XWkPKM6Qz/R8kEMti4GXYnjdoB9         v5Ww==
X-Gm-Message-State: ALoCoQn3dQa7amIZtwzZeFpDNk517Fj/0cdClyBoMd70ilJ3lr83FJwFUW8eKfEixGntX2kQKi3s
X-Received: by 10.28.24.199 with SMTP id 190mr22809821wmy.101.1448317880177;        Mon, 23 Nov 2015 14:31:20 -0800 (PST)
Date: Mon, 23 Nov 2015 22:31:17 +0000
From: Adam Dinwoodie <adam AT dinwoodie DOT org>
To: cygwin AT cygwin DOT com
Subject: Re: Https proxy auth issue with git in cygwin 2.2.1
Message-ID: <20151123223117.GB14466@dinwoodie.org>
References: <CAFkLm6xW=5uUP+CRrmUontqPzqAZ+r4WdwjVAhP+XTvs53JmFQ AT mail DOT gmail DOT com> <20150921103100 DOT GF14466 AT dinwoodie DOT org> <loom DOT 20150925T090939-654 AT post DOT gmane DOT org> <20151005202249 DOT GM14466 AT dinwoodie DOT org> <loom DOT 20151016T142002-602 AT post DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <loom.20151016T142002-602@post.gmane.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes

On Fri, Oct 16, 2015 at 12:26:14PM +0000, Johan Laenen wrote:
> Adam Dinwoodie <adam <at> dinwoodie.org> writes:
> 
> > I think I've found the problem, and you're right -- Git has changed the
> > way it makes the curl call.  The culprit is commit 5841520b in the
> > upstream Git repository, which has the following commit message:
> > 
> > | http: always use any proxy auth method available
> > |
> > | We set CURLOPT_PROXYAUTH to use the most secure authentication
> > | method available only when the user has set configuration variables
> > | to specify a proxy.  However, libcurl also supports specifying a
> > | proxy through environment variables.  In that case libcurl defaults
> > | to only using the Basic proxy authentication method, because we do
> > | not use CURLOPT_PROXYAUTH.
> > |
> > | Set CURLOPT_PROXYAUTH to always use the most secure authentication
> > | method available, even when there is no git configuration telling us
> > | to use a proxy. This allows the user to use environment variables to
> > | configure a proxy that requires an authentication method different
> > | from Basic.
> > 
> > I can't confirm this is the problem, though, as I don't have a test
> > environment that uses NTLM.
> > 
> > Do you have the ability to either run a test version of Git I can
> > produce that patches out this change, or (better) to build Git yourself
> > without this patch to see if that is indeed the change that's causing
> > the problem?
> > 
> 
> Hi There,
> 
> I can into the exact same problem after upgrading to the latest cygwin version. 
> 
> So, following your advice, I took git-2.6.1.tar.gz from github, untarred,
> and modified http.c:
> 
> $ diff git-2.6.1/http.c t/git-2.6.1/http.c
> 466,467c466,468
> <     if (curl_http_proxy) {
> <         curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
> ---
> >       if (curl_http_proxy) {
> >               curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
> >       }
> 469c470
> <         curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
> ---
> >       curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
> 471d471
> <     }
> 
> One make configure, ./configure, make and make install I can confirm that
> unpatching the change undoes the problem :)

Hi Johan,

I've just spotted this email while trawling through other Cygwin/Git
related things; somehow I missed it when it was first sent.

I see you've raised this on the upstream Git mailing list already, and
there's been some useful discussion there, so I'm not proposing any
further discussion on this list.  I just wanted to reply with my Git
maintainer hat on and acknowledge the discussion has moved upstream.

Cheers,

Adam

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple