DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=bgg/wYyAkpvjLSiVDNbpgO0cbFTeaQjniHqaIaPG0O/xRdz7P4UX8
	cR2Qn37wEkRQUAR7HV6um5JSBbVid8GRRI51HRGK0720nABUrBc+2WHL7JZgrI/X
	NOn+iJQyR/w/yk8/rNvRqDaFoGjkqzamfHGWreCuZ0Tc/yR7bY0MtM=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Thu, 30 Apr 2015 12:56:44 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Trouble with Git 2.1.x pushing to repos over Samba
Message-ID: <20150430105644.GM3657@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <CAOC2fq8dCzjjZU3eHWWh_h5s7O0M+z482+prWz9HsQWVqAjVng AT mail DOT gmail DOT com> <397346277 DOT 275101 DOT 1430383452664 DOT JavaMail DOT zimbra AT ceos DOT com DOT au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="fbglzKaagM3twbm3"
Content-Disposition: inline
In-Reply-To: <397346277.275101.1430383452664.JavaMail.zimbra@ceos.com.au>
User-Agent: Mutt/1.5.23 (2014-03-12)

--fbglzKaagM3twbm3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi John,

On Apr 30 18:44, John Orr wrote:
> > From: "Michael Enright"=20
> > $ git push origin master
> > fatal: '//host/path/to/repo.git/' does not appear to be a git repository
> > fatal: Could not read from remote repository.
> [...]
> #: john AT johndesktop:/cygdrive/l ; ls -ld .git/objects/
> drwxr-xr-x 1 john Unix_Group+1000 0 Nov 13 14:13 .git/objects/
>=20
> (albeit, Corinna, with my group issue still not yet resolved)

You tried the /etc/group tweak as I suggested in my latest mail in that
thread, I take it?

> access(/cygdrive/l/.git, R_OK) returned 0
> access(/cygdrive/l/.git, W_OK) returned 0
> access(/cygdrive/l/.git, X_OK) returned -1
>=20
> The last test is the one run by git, that makes it reject my /cygdrive/l/=
.git directory.
>=20
> Not sure if that's relevant, but just in case.

Thanks for the info.  I found a really dumb bug in my code.  The
access() function is using a Windows function for access checking under
the hood.  To account for the Samba account mapping in Cygwin, there's
a function converting the S-1-22-x-y SIDs in the file's ACL to Windows
SIDs if there *is* a mapping.  But I made a small mistake which has
a big result: The ACL is not completly copied over, thus the Windows
function has to deal with an incomplete ACL.

I fixed that in the git repo and uploaded new snapshots to
https://cygwin.com/snapshots/  Please give them a try.  Don't use the
snapshots for anything else for the time being!

  PLEASE TEST ASAP AND REPORT BACK!

  I'll be unavailable for a few weeks starting tomorrow, so I'd like to
  do a bugfix Cygwin release, preferredly today, if this patch works as
  desired.


Thanks,
Corinna


P.S.: As a side-note: While this patch (hopefully) reverts this code to
      work as pre-1.7.34, it seems that the internal Windows access
      check function is not quite up to the task for Samba shares in
      scenarios as John's one.  It will always report back the access of
      the "others" part of POSIX permission bits.  Only with the new
      mapping of S-1-22-x-y SIDs to real WIndows accounts, or with
      winbindd-supported mapping, the Windows access check will really
      work as desired.

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--fbglzKaagM3twbm3
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVQgpsAAoJEPU2Bp2uRE+gqkEP/0hqqlviP5Yopeohv8srB6uo
IPCY17SSxyOBTYUAzbwZgytfxldniQ+ML4xTnySjBQdVwsE/5namZxDuqK2j3OTq
CYmJAP9gFdz6PeJRgMAmoMmzW37tZX5yOGJo1zVcvA+kjbvBaKygz8HNy5kfqJkl
ojaFQoE4ROqKriivUozar545Hc6x/IVRXEKgiBLm/X6VXZeBkVMYLAOdjxWqymBK
FDyfYKeHvA+GJWiwWsbu2IVi8M0N+nZys5AFYg8mbaH6445XEajx3oJmn+vFFGKb
Gk2bwGNSUQFCsZ3uTR/HTG4aK7grGalS3JQEeBnPYzWdrzESH3wTr6RWcjUKa0NG
NhCnPV+vTwIenc45TGCJD6U5uPtgZ017nE/K/YAVkXZnnElAXOJgI9g+2OBOBQUp
dVfz6AVPZ4/eTciJbYIEmH3QjhbgbN9DoILR7Hey6QCPrqsVVVIrWTrqw3ujtymf
QxAp7udQYgJv8tJH8UdGEdgcyKWvDPgbGM5vFdQTChd3LvPNXoVSkVDQ5EFiFSj8
VEXzU4nF5RmIsla3jI87/zA9Gl5nQ+/aocVeD68ADyqCung+hvZcntf2Sue8A7ON
9owueubD93pXsNtEUYeQdWMBNXalI6MYiu8USqXwxX2+KZAO7ix9CP4/RgdMeX3i
kj9P4JwrPTZIvvInFarW
=zsnQ
-----END PGP SIGNATURE-----

--fbglzKaagM3twbm3--