X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=jZiu80gB54WjzQG+sZuDyx414d/6WKPSq0zkrda8+8GKBzTR1R0lD
	yRfQJNPTLZXyiYHmWxR7TfggQIniAF1JjwjF7OF6mw5z2qo3XZTlmpzPfBC9JG7m
	bOhQUlpIEGDWQcNvl9AGoa9ZRcv/JEyb6AupdacHbI40tiZp/PMM4A=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=DqNgdoVIXbcc91KwnxMmmyRx5N0=; b=T6RGn9Ylh0ryGvAjOsO7wO/+CH6A
	/Ns9SwkNG2QCUqYln5EDhmonUJ1O3wW9znEZSmPCSXfbn+7TO3ueCYTb6XklYEYv
	Id8I7PQhNSQk4HmeOccuycIUp2nDau9tVJaLUTpSlIV3xxqETfu8qsK3J+pAvTdj
	XeLy4TF+P7em2Ps=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2
X-HELO: calimero.vinschen.de
Date: Thu, 16 Apr 2015 18:43:46 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.0.0-5
Message-ID: <20150416164346.GG3657@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <announce DOT 20150415160254 DOT GF7343 AT calimero DOT vinschen DOT de> <CAK-n8j6MpTscHoOCmzkrrTHAxtzL4XuV5TY-x5f-S6mJ8WQk5A AT mail DOT gmail DOT com> <20150416162146 DOT GD3657 AT calimero DOT vinschen DOT de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="juZjCTNxrMaZdGZC"
Content-Disposition: inline
In-Reply-To: <20150416162146.GD3657@calimero.vinschen.de>
User-Agent: Mutt/1.5.23 (2014-03-12)

--juZjCTNxrMaZdGZC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Apr 16 18:21, Corinna Vinschen wrote:
> On Apr 16 08:17, Jim Reisert AD1C wrote:
> > I am unable to start Cywin/X X-server 1.17.1 with this version.
> > Previous releases of 2.0.0.x were OK.  I had to revert to 1.7.35-1 for
> > the time being.
> >=20
> > Other than updating to 2.0.0.5, I also installed the April 2015 "Patch
> > Tuesday" updates from Microsoft.  I don't know if the two are related.
> >   Windows 7 Home Premium, 64-bit
> >=20
> > Exception: STATUS_ACCESS_VIOLATION at eip=3D77C50F8A
> > eax=3D00000000 ebx=3D612D67B0 ecx=3D00001000 edx=3D612D2648 esi=3D00000=
000 edi=3D0028C790
> > ebp=3D0028C608 esp=3D0028C604 program=3DC:\Cygwin\bin\XWin.exe, pid 166=
0, thread main
> > cs=3D0023 ds=3D002B es=3D002B fs=3D0053 gs=3D002B ss=3D002B
> > Stack trace:
> > Frame     Function  Args
> > 0028C608  77C50F8A (00000000, 612D2648, 00000000, 612D67B0)
> > 0028C738  610CDA1F (000043FF, 00000000, 00000000, 80012428)

On second thought, if I can trust the args output, that would be an
fchmod(0,0).  If there's no uid or gid 0, which there isn't unless you
explicitely created them in the passwd/group files, the uid and gid have
no SID connected to.  This may be the culprit here.

> I could add an extra check which refuses to change permissions if
> the account's SID can't be found, but since this occurs very deep
> in the call stack, the error message might be pretty vapid.
>=20
> Alternatively I just let this slip through and you might wonder
> why the group hasn't changed in this case.

I added a change to this effect, but it occuurs to me that this may
be really just a missing test if the uid and gid values are backed by
a real Windows account.  It seems better to return EPERM here.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--juZjCTNxrMaZdGZC
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVL+bCAAoJEPU2Bp2uRE+gMV4P/2SxkR66W+HzN8+D8bW8alro
f7mAeyw3CC+ypMkYWo5pO7NnZAHOXeVUBShtaeiTEUft5JuonwfeVZYsOlqHtJDd
X6xlLJdtlgYYPfd18LZY1YVhAEi9nwVHEEvpksLo1vA7MGuj22giA+VYKEGMvLJy
Wgs/w2o/iFWaRIkflBk6nzjmc/LI7/1jp/U29Jtcq0xb7M8T/4uIPdpJvECH4QgD
9yy5PvVxAVl7byJeq7qeAPBWY+l0pMkETOwLXzAgYL9PRxdbHTZ0F2CXY0owJ3Qg
AHEZ2uUPPlHUcyfQMygiiyDVfN1qX2OXPN8pt6N563s5pBO+0qzcD2U0gZbSuyJ5
gvFVzzXCIJntYmQ3rxszavXfTSZ9pwD8jwi37HFA/LDuiQLSX/cgxJ/3wEessKYW
PlDmjvyYcgu/T5VwPGXxQu397TGxrbGN8Ik9fxhGwHFw51Frg3RGnch2TWk++lp0
r6uiKS7cyB3Vze9dkZBX/6P2u34gmxvCLozh51Stee3Bs3dGVmZ/ETPZYtoNPHDT
ZCshWhYZHUiuxXW7/c7+QXwKyen//aAtAQinqLTS1vQIE/22p4kkF6pLHn33ltkb
2ld9VEHmfhj+H+fMj1QW3nyJTTgLVBdDi8gWTmOLAWkDWVWYr66ll61x1RkpMt2H
g6sAQPEnPCOGVO/Pdt3C
=atAP
-----END PGP SIGNATURE-----

--juZjCTNxrMaZdGZC--