X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=IITtBPcFrVZL/hTf4Jk1jjwc95nbkADng9LP8BOsK7FohtVQ5GdZ0
	9uvqSqJBAX/eCUzBYaHViUigXiFLJFb6zobR2LeY8yZ6MEqWNKR1oU+eU/vVr2Fm
	0Q627XEHr3OD0ePNkpS9+DTNWIIGhStI56OFnYM9iZONSBQdzO9DaE=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=1RLvmlT9SxLCmWw/fm0XnS+YXOY=; b=bIHRqFdXelsGDB8zVDTyG/Iga3TS
	jUNEfaQ/OlG3ZlB8A133KERlWmGpYgTekFl2Q/p1Jpv/l9Jc+6NAQSRa90FnPkR5
	4EbcSOxElOsuMbbLUUD1KNBSx+2xcsp9L1SGG9zime0nTgBwGoHLOSjLejQa61L/
	Y4DsFjFNdlR4ScE=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.3.2
X-HELO: calimero.vinschen.de
Date: Wed, 1 Apr 2015 15:45:54 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Cc: Qian Hong <fracting AT gmail DOT com>
Subject: Re: Cygwin / MSYS2 runtime fails on Wine beause of accessing to (*ReferencedDomains)->Domains[-1]
Message-ID: <20150401134554.GW13285@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com, Qian Hong <fracting AT gmail DOT com>
References: <CALd+sZQu4496pEW-B9eCsS-EC426uSgieh9cjECe5reBW52GQQ AT mail DOT gmail DOT com> <20150401103733 DOT GA4835 AT calimero DOT vinschen DOT de> <CALd+sZQaBX1aioKZkt2uNGGgPUJN+i=ZLEr9ipO9iC7V_1CRSg AT mail DOT gmail DOT com> <20150401113620 DOT GA11571 AT calimero DOT vinschen DOT de> <20150401122206 DOT GA5725 AT calimero DOT vinschen DOT de> <CALd+sZSrpWp8O+MTVSVaiNYupSnjLr2_uGz=9Bxp-zjqjkEhgw AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="0lx/R+CYDdR/AN/7"
Content-Disposition: inline
In-Reply-To: <CALd+sZSrpWp8O+MTVSVaiNYupSnjLr2_uGz=9Bxp-zjqjkEhgw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

--0lx/R+CYDdR/AN/7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Apr  1 21:31, Qian Hong wrote:
> Hi Corinna,
>=20
> On Wed, Apr 1, 2015 at 8:22 PM, Corinna Vinschen
> <corinna-cygwin AT cygwin DOT com> wrote:
> >
> > I now `git push'ed and re-created the April's fool snapshot *with* the
> > patch to address your issue.
> Thanks for the quick fix.
>=20
> I tested a little bit but it doesn't work, and my patch to Wine still wor=
ks.
>=20
> Unfortunately it would be a bit tricky for me to provide a backtrace
> very soon due to limited debug symbol support of WineDbg. Before look
> deeper, could we confirm we are testing the same binary?
>=20
> I'm testing:
>  x86/cygwin1-20150401.dll.xz
>=20
> $ sha1sum cygwin1-20150401.dll.xz
> 01d5092d48f3742cedcb28ea646b10088373d549  cygwin1-20150401.dll.xz
>=20
> $ sha1sum cygwin1-20150401.dll
> 5619b74582a6584626c6dc05106698f9560d0d8a  cygwin1-20150401.dll
>=20
> I renamed cygwin1-20150401.dll to  cygwin1.dll and copied to
> C:\cygwin\bin\cygwin1.dll
>=20
> But Wine bash.exe still crashes, in a slightly different way:
> originally, it complains about access to invalid memory address
> 0x00000002, now it turns to invalid address 0x00000000 =3D> not sure
> this is useful information.

A bit more debugging would be useful.  I debugged this on native
Windows and the code is not accessing a negative index to the domain
list anymore.  From my POV *this* part of the code is working as
desired.

> Here is some strace.exe output:
>=20
>   228  142321 [main] bash 11 __get_lcid_from_locale: LCID=3D0x0409
>   659  142980 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <Administrators:S-1-5-32-544:544:>
>   715  143695 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <LOCAL:S-1-2-0:66048:>
>   146  143841 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <INTERACTIVE:S-1-5-4:4:>
>   141  143982 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <Authenticated Users:S-1-5-11:11:>
>   155  144137 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <Users:S-1-5-32-545:545:>
> --- Process 11, exception c0000005 at 6113FD85

That's a crash in wcsncpy.  Where's the NULL pointer coming from?
The pointer I created for the domain name points to an empty
unicode string, it's not NULL.

Oh, hang on.

On Windows, the name part of the logon sid is the login sid as=20
a string.  So, if the login sid is S-1-5-5-0-1234, the name of the
sid is L"S-1-5-5-0-1234".

Is it possible that Wine doesn't reflect that?


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--0lx/R+CYDdR/AN/7
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVG/aSAAoJEPU2Bp2uRE+gipAP/A/cGj8r5nDanqcLzDBo7yEd
5NjsljnIfoR19FdfIBWa48nj2BUkhwhSeji6k71W38L/54eZfIyEoH8cMZ3HMnxO
G/SXocfmLKEo/+eXGgsBPlOxnJRWQi0CCvS3oRB78GrAWNU644FNWbyhkD1rSWDV
wqQVhhWvzJnjjvOBJhjJQmPZrFDxzk0oRYS0m541y10RRol/TJ4nKS47Jwgf/3By
72RX1M7U7dR3QuOxi57DBczDeuKLu7OTfU5U/FcIBkdmuihtUaA5adSh8BRfoET4
IZEpdC3GgQgyiVpUEl9bgBkiLGlywI2c2ljE+rog8eUWimtyrT8qd4cRE4J5wev5
z0ZTVJ8Ph+W/nrxoa9szJvLKF3lDu3rlxygHpghQqvsgnPd9ER9rmur2rr3B4fpi
F5MRKoB9QIdmxg0YdSZK7QDymjfdXvMDRDd0etNiRWu/DCabThI4UrqZpdmN0hcx
F2vClOZZWlPyz1ZqiAGCLCah6DM3oB7dEuPOU+NAQjAiSn+zcTC4XZKrLvSRcCOY
UPlyNjTLlBV5o7c8oiHWOCTA4UAmalns5f1ommnp8B+be6ke6HBsBW1Eiv/3yflD
SwpZDNmkajDlnU34t9oJPK6gdAbpFpxliEpY8/WDnHZXHMRrpuYOlmsv+ev5zZeX
fg84G9Bppw4kXqNgnIuL
=hGPz
-----END PGP SIGNATURE-----

--0lx/R+CYDdR/AN/7--