X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=Rj23AhT2TDSlgwue4BdxJBmh5dP7g6f7dUmvb3750npXUVqHCfVAA
	PFRct2b7LB7qqPdKqBTQv6jPg82yGs6JAH0MdJTN23hSIliQEHLmmWvL2RjR6/c+
	dJD475fgEtfVtaI5LL9vz4I/3OpCob6K++vfwP98ZnQ6idAsS4ipyQ=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=iYXruESR2TRhpg9WsMVYIqmhBkQ=; b=TEz+zOqKgPcVjTGtLlA2OqmehT//
	f/a6YcHzVe0fN+bfjQN6FV7C+qV+rUVlM+VGP5Xvv8b3AOTdFLAhe/5DmoE9YODq
	UDLRVCExV0ION6RjBzEBXvFKwmL8m6lKeB1fZs8G+duQFaxpJRMDRhbJ+ZRnsHZb
	YlrQ8KlUX8m5c0E=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: calimero.vinschen.de
Date: Tue, 24 Feb 2015 16:24:49 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Clearing O_NONBLOCK from a pipe may lose data
Message-ID: <20150224152449.GL437@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20150222220747 DOT 789401d2 AT tukaani DOT org> <20150223105653 DOT GG437 AT calimero DOT vinschen DOT de> <20150223122345 DOT GM437 AT calimero DOT vinschen DOT de> <54EC2566 DOT 4030703 AT towo DOT net> <20150224110953 DOT GF437 AT calimero DOT vinschen DOT de> <20150224161601 DOT 68f0a08c AT tukaani DOT org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="x7gJcYyRf5ZnuMVj"
Content-Disposition: inline
In-Reply-To: <20150224161601.68f0a08c@tukaani.org>
User-Agent: Mutt/1.5.23 (2014-03-12)

--x7gJcYyRf5ZnuMVj
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb 24 16:16, Lasse Collin wrote:
> On 2015-02-24 Corinna Vinschen wrote:
> > On Feb 24 08:16, Thomas Wolff wrote:
> > > Am 23.02.2015 um 13:23 schrieb Corinna Vinschen:
> > > >On Feb 23 11:56, Corinna Vinschen wrote:
> > > >>On Feb 22 22:07, Lasse Collin wrote:
> > > >>>Alternative idea: Would there be a significant downside if Cygwin
> > > >>>remembered if non-blocking mode was enabled at some point and
> > > >>>close() would use that flag instead of the current (non)blocking
> > > >>>status to determine if the background thread hack should be used?
> > > >>No, that should be doable with very minor effort.
> > > >That's still an option, of course.
> > > I think that sounds like a solution.
> >=20
> > I applied a matching patch for this:
> >=20
> > https://cygwin.com/ml/cygwin-cvs/2015-q1/msg00079.html
> >=20
> > Please give it a try.
>=20
> I applied the patches to the snapshot 20150223 and it works now. Thank
> you.

Thanks for testing!

> I'm going to release xz 5.2.1 in a day or two. Should that release have
> a workaround for this Cygwin bug? The workaround would avoid using
> O_NONBLOCK on stdout. It adds a race condition to signal handling in xz
> but it's usually a very minor issue (xz 5.0.x has the race and no one
> has complained). On the other hand, the fixes to the threading bugs are
> somewhat important for xz too, so maybe I should just add a note that
> xz 5.2.x isn't safe on Cygwin yet but will be in the (somewhat) near
> future?

Whatever you prefer.  I think it's fine to point to using at least Cygwin
1.7.35, but if you can live with updating to some 5.2.2 after 1.7.35=20
comes out, the workaround in 5.2.1 would be nice.

I'm still working on performance improvements in the account handling,
but when that's settled, I'm going for 1.7.35.  Let's say a week or two.


Thanks,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--x7gJcYyRf5ZnuMVj
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJU7JfBAAoJEPU2Bp2uRE+gbDcP+wWrDIWWwCroLYhPCT73+ufo
h9+iRbsu0mWGcUVyMgCwgksetUotJv1/fYz+aS6fXO2KTF3OyhO8B7QG9BCgov5f
uPEgxnMQENhSo8/uvfWU/e4HEkQ5wIAK19FRN8SKO/hiij1FJVgmKemfT6hFgfFs
mhxKn/apsOUjjqfVqtHrWvMTUoiGstP0vgXRaIluuZEEjei2ZcNypaUT81yVWGAT
qaSi1i6BPr5t60m+DnVym1WsEEz1dkhI6Ktnv8X3XgFxhlCI38uHa98CEBKj6Rq/
rDhaGQf7lXdOhRKL2dU7fLHLvffNmNJw54/cLHV8CADmxt94x46C5JZyLABzLUPk
yQ7plPEYQgY0VBMwRDJuBlbDGasoS33xxCX/2su06WCiVIqS+tYLLxL/EqOQlyrP
mf3iHQyh1SkZjiwkSFSM26HFbzYyk+UjyRpEPBdt4y61pxARy389Jf69FVNwEA/7
05xWOuV+vWtLuLdEmHCPg+HCooOyGwQyenlJ1nk9apQWzJ0SX/MukDSVwbYGiCwQ
IlnbQPEVVh4fQ5BbhJaaoFvdCtTqjYwK3LzeO8B86T/OklVLkEP7xbqSjcRAGS3z
t/ZKH7jh8DLiFhZUxtVI6cmSW9Otb9LZ4MAc+knhMrBbfKn7XXlq2WoyTRMDYz0h
K+ALnLbxnhrBmZ9aW+gc
=N7q+
-----END PGP SIGNATURE-----

--x7gJcYyRf5ZnuMVj--