X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; q=dns; s= default; b=SArAAvnXaG/eZuLT3YLytcvKTwtvD6uLZ3wScWhvRJtQSj3ZHJUcN ZFsyErw1wgApXImF5WM1h+irKC2yvRScydDcWRxJkxJJg+IhoYRGLPDpqNGBUZaH wpznjen7BHl9BwUOT2goOK+76uOic5JW8lGOsFORYWAKiIP/1GrvIQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; s=default; bh=h1d/aQapSrrkTsUGkRj7PNqWQPk=; b=t5XuLJ1cSYFteB0kC9vqFtAHy2B+ RykmxPRfMVdXExa3QorlZV3ZuVg6gool8gwY+OYnN8n5hJFBQofsJ0uPzyz2TKTJ dangObaFv+yh5OeK4M+PktOk6yLN9KOSQckX37U/Bg5F2Gj9MBQtULfO8q1p3dw3 Yd6SMxYqjxTT92Y= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: calimero.vinschen.de Date: Mon, 16 Feb 2015 10:35:26 +0100 From: Corinna Vinschen To: cygwin AT cygwin DOT com Subject: Re: mintty needs a patch Message-ID: <20150216093526.GC7225@calimero.vinschen.de> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <20150215092707 DOT GF7225 AT calimero DOT vinschen DOT de> <54E0E860 DOT 1080308 AT towo DOT net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rPH0Y77Oimr1cvNq" Content-Disposition: inline In-Reply-To: <54E0E860.1080308@towo.net> User-Agent: Mutt/1.5.23 (2014-03-12) --rPH0Y77Oimr1cvNq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Feb 15 19:41, Thomas Wolff wrote: > Am 15.02.2015 um 10:27 schrieb Corinna Vinschen: > >On Feb 14 23:10, Tony Kelman wrote: > >>I was trying to build mintty from its src package today. As a heads-up > >>for whoever next tries to build the package, I get the following error > >>on either 32 or 64 bit: > >> > >>gcc -c -MMD -MP -DTARGET=3Dx86_64-pc-cygwin -DNDEBUG -std=3Dgnu99 -incl= ude std.h > >>-Wall -Wextra -Wundef -Werror -mtune=3Datom -fomit-frame-pointer -O2 wi= ntext.c > >>windres --preprocessor 'gcc -E -xc -DRC_INVOKED -MMD -MP > >>-DTARGET=3Dx86_64-pc-cygwin -DNDEBUG' res.rc res.o > >>wintext.c: In function =E2=80=98win_text=E2=80=99: > >>wintext.c:522:13: error: array subscript is above array bounds > >>[-Werror=3Darray-bounds] > >> if (!fonts[nfont]) { > >> ^ > >>cc1: all warnings being treated as errors > >>Makefile:117: recipe for target 'wintext.o' failed > >>make: *** [wintext.o] Error 1 > >> > >> > >>This can at least be made into a warning by taking off -Werror, but it = looks > >>like it might be a real off-by-one. Our neighbors over at MSYS2 have a = patch > >>https://github.com/Alexpux/MSYS2-packages/blob/master/mintty/01-array-b= ounds.patch > >>(the packaging repo there has a BSD 3-clause license) to change FONT_MA= XNO > >>in wintext.c from 0x1F to 0x20. > >Sadly the mintty maintainer is AWOL for quite some time. Would you > >like to take over maintainership? Given the overall stability of the > >package, maintaining it shouldn't be much of a burden. > I have contributed to mintty before and will look into this issue. > I'd like to discuss further details in PM if you like. Not in PM. This is what the cygwin-apps mailing list is for. Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --rPH0Y77Oimr1cvNq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU4bndAAoJEPU2Bp2uRE+g+t8P/RmukVgGRbv2wspCTnhl5kyO IuyESZMlit9yIS2Ana6Tt2r1/xRS3kdRbC1h+pK/ovwGmGeW7ypcr4diy0tG/Xrm 4uP0MY0ew55lRH2Tn+CpEys/03YpovpDyDpzWR+zW+K0FPVNzxaJgGVBaU2ZfDFa NmIe6LNBg2Nuq7M5qIwMYwKpcs1pBPW7AumY6YmJoYgo1PfhP9b6jSZOd0Euf+YQ TMXWj8NX1MYoCMsXS/9uxIPzU43W4XsqD+jtFWvH26azJqx+mRGPantLQf799HuS wHNINGiF3KCfGxWmDgXuMSYUXlHiftNtP30DG73tnZ94J8UjnImALLNcYgXzkhsn UQhS6zoKbuMv/HklVBhBeqhT2/Wlcs0ZoeCMkGg0hsXVc5qNz/yIidsbvBApndso 7MUqlSU8cscljPWLy20AqKLDGXSssHeG2kSKFlyyz3MeKqota/B4SNM7hqQifFZC naLQQ2GA55s+BJk8lA2gHGArMV4fiK7eqZEdhz9WCX8td+6+hHW/RBpXtoUUkJLY MRuXz7XTd+z0PklFH5nccwKklWyh87FbzRCY4BcLyKnRygir8SUG1I3wwgxLsY59 6EJNOcLhGBahRfFb+6c5Ne4fmGzG5zR+TpqBfLNCvOwo7AkiGHGtYdXs2LQQbiwC xXxspiD8B/8riqZouIg1 =CMtI -----END PGP SIGNATURE----- --rPH0Y77Oimr1cvNq--