X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=BX6dUa/UrX5HOn5gtbYRZ1bxQ9RhReueRsdQRQbGLTN
	mZZ4H55QtR173QZZH2EAsY11xBkEp3r2PLcncbXEpnznYr2ZCgn1j8VqQDCRCF2D
	zXltdD3iL61XcJIWS1gz42+LgpRPOvIwDk2AjCQnOJ3rUayPHDwXGGsL5G1RUTMY
	=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 s=default; bh=XN3xycT7/fxwG8g9QC2MjqHtrzE=; b=PsTYiN0Argbbj0+x2
	kbatSyDaoq4czVqhKx8LPy/lnlSJGlteowIsMAeXTNZmc6Ej8G/M3JwtauOvxCBQ
	jmKI4tOJqlMCpzU9IVOOOP4WlTeqs+15ALYkvN7m4QsFMIJIMG+AD0o0DtzOmiYV
	Io5T9sOzOQI1ZJp9+hjTW6aWWg=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2
X-HELO: mout.kundenserver.de
Message-ID: <54E0E860.1080308@towo.net>
Date: Sun, 15 Feb 2015 19:41:36 +0100
From: Thomas Wolff <towo AT towo DOT net>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: mintty needs a patch
References: <BAY169-DS4C6B8EA9E64E844F67D9BA7210 AT phx DOT gbl> <20150215092707 DOT GF7225 AT calimero DOT vinschen DOT de>
In-Reply-To: <20150215092707.GF7225@calimero.vinschen.de>
X-TagToolbar-Keys: D20150215194136411
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-UI-Out-Filterresults: notjunk:1;
X-IsSubscribed: yes

Am 15.02.2015 um 10:27 schrieb Corinna Vinschen:
> On Feb 14 23:10, Tony Kelman wrote:
>> I was trying to build mintty from its src package today. As a heads-up
>> for whoever next tries to build the package, I get the following error
>> on either 32 or 64 bit:
>>
>> gcc -c -MMD -MP -DTARGET=x86_64-pc-cygwin -DNDEBUG -std=gnu99 -include std.h
>> -Wall -Wextra -Wundef -Werror -mtune=atom -fomit-frame-pointer -O2 wintext.c
>> windres --preprocessor 'gcc -E -xc -DRC_INVOKED -MMD -MP
>> -DTARGET=x86_64-pc-cygwin -DNDEBUG' res.rc res.o
>> wintext.c: In function ‘win_text’:
>> wintext.c:522:13: error: array subscript is above array bounds
>> [-Werror=array-bounds]
>>    if (!fonts[nfont]) {
>>              ^
>> cc1: all warnings being treated as errors
>> Makefile:117: recipe for target 'wintext.o' failed
>> make: *** [wintext.o] Error 1
>>
>>
>> This can at least be made into a warning by taking off -Werror, but it looks
>> like it might be a real off-by-one. Our neighbors over at MSYS2 have a patch
>> https://github.com/Alexpux/MSYS2-packages/blob/master/mintty/01-array-bounds.patch
>> (the packaging repo there has a BSD 3-clause license) to change FONT_MAXNO
>> in wintext.c from 0x1F to 0x20.
> Sadly the mintty maintainer is AWOL for quite some time.  Would you
> like to take over maintainership?  Given the overall stability of the
> package, maintaining it shouldn't be much of a burden.
I have contributed to mintty before and will look into this issue.
I'd like to discuss further details in PM if you like.
------
Thomas

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple