DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=vGyMalbtSvSt/2CoWTk1AKnKdGUfs7MJvIsQRUcXHsNFVRjkHnGR8
	UPkhZinlhZ7amiQXvdG+NgcoyMH2BBEMSOajNXxid8CIFeKCa30spoxMTyzXRYkx
	N/TlcPD1zMFAzi7/8Cz0m+85PtQr3/ls7Z2YWKJZAvpFxh/eTdwLdM=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Sun, 15 Feb 2015 10:27:07 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: mintty needs a patch
Message-ID: <20150215092707.GF7225@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <BAY169-DS4C6B8EA9E64E844F67D9BA7210 AT phx DOT gbl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="H8ygTp4AXg6deix2"
Content-Disposition: inline
In-Reply-To: <BAY169-DS4C6B8EA9E64E844F67D9BA7210@phx.gbl>
User-Agent: Mutt/1.5.23 (2014-03-12)

--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb 14 23:10, Tony Kelman wrote:
> I was trying to build mintty from its src package today. As a heads-up
> for whoever next tries to build the package, I get the following error
> on either 32 or 64 bit:
>=20
> gcc -c -MMD -MP -DTARGET=3Dx86_64-pc-cygwin -DNDEBUG -std=3Dgnu99 -includ=
e std.h
> -Wall -Wextra -Wundef -Werror -mtune=3Datom -fomit-frame-pointer -O2 wint=
ext.c
> windres --preprocessor 'gcc -E -xc -DRC_INVOKED -MMD -MP
> -DTARGET=3Dx86_64-pc-cygwin -DNDEBUG' res.rc res.o
> wintext.c: In function =E2=80=98win_text=E2=80=99:
> wintext.c:522:13: error: array subscript is above array bounds
> [-Werror=3Darray-bounds]
>   if (!fonts[nfont]) {
>             ^
> cc1: all warnings being treated as errors
> Makefile:117: recipe for target 'wintext.o' failed
> make: *** [wintext.o] Error 1
>=20
>=20
> This can at least be made into a warning by taking off -Werror, but it lo=
oks
> like it might be a real off-by-one. Our neighbors over at MSYS2 have a pa=
tch
> https://github.com/Alexpux/MSYS2-packages/blob/master/mintty/01-array-bou=
nds.patch
> (the packaging repo there has a BSD 3-clause license) to change FONT_MAXNO
> in wintext.c from 0x1F to 0x20.

Sadly the mintty maintainer is AWOL for quite some time.  Would you
like to take over maintainership?  Given the overall stability of the
package, maintaining it shouldn't be much of a burden.


Thanks,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--H8ygTp4AXg6deix2
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJU4GZrAAoJEPU2Bp2uRE+gPQ0P/A2LavuIdFxLgKjkts1CSn/H
7iQs/vrCMEzFuMPhh+C+2/879k5Gep96wkhRxVG+MJpIuc58dLzkdAmGVdo3SC32
nyUiAK3mzffs3FFNBeFAiEuvVeYnR4HChYOOspWU4rcsHVjWwZ8+0AgjP+SmaFxX
dDwSARE4ll8XS9hjj43o+4IXiEmrjhBylEW4/TQZC2i45n401UOfqcv+7JVW/Wf0
4l6HRSk7AfsUxDcx+RKieJGYHmiC8IeVr58ikBWAeWO6Qxy7xrWbLp0t/bmZ65f0
JcF3KVQaf+C+r7MJbYGaFRUBJcu2MGj7l0oENZr6BuqnWhaP/RGKd8EFxetxrt80
zpGUByREn1a0GGmL8kuD0ZaDYQRieon7JhSsVr1aLVPXxAxSKSDtsS4cSL/KzmaZ
EFspmxOsL3YzBayn9lsFKc8JvttQ0skthIxkFPtHPZty1h7hINQpAqpIF6RZ1tmp
u50lIjTSMMLcQ7kLrpBx8GGax4J+Uz/tQbRrx5qBu1V4uKZGSzfINKc/PuG5nKob
Nud5+1nlCvDXraG4QnpMwtcZu+c2O2g3G3ZFDX3st5+4qyW1ARtM5+2LPC8jZDvw
Nl1R0a1QRFYsbYHK4u3d/xQ+pr1AHU7+DDaeu78ymENhQTtG6KGJXH1rcIy5zCD+
6kiFMkSxYyzLdg7u+23c
=BYRD
-----END PGP SIGNATURE-----

--H8ygTp4AXg6deix2--