X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=Apaju+IufAFlEZ2dg8NWUAT1z36n2qsCoyPGVGj3L6O
	56jYQX/iUNJzvQxnZ7OCBmzdaO3wxVjyBHXsVzwu5SRE1sn9gq3Fi6zpqTfBe+pP
	E8E7bKFi1dcE6d4Jrr5Z1F355fKFpU+2+5cgw9FPPcZ4fVuB/3Mm9Ad9oJzLyliE
	=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 s=default; bh=J77GCknu4RfkpuSOtHMGIjloq6A=; b=Uc6dlP4cJXg/DUTYJ
	1pGrzLubOBMtR4vKHO1GlEhGo3K/nAKQiW0/8rwQVx7kMuF5Jvg0cn7Ni1GqeAE5
	EAEHnzta0J2WI2c+sWASVqxmFJW0cCiDCp1nX4TXLThXqPvIyozpIAafgTRhdtfM
	jSjPKE9Hs7V2g9JNaRaNP76wmQ=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mailout07.t-online.de
Message-ID: <5455114E.7050306@t-online.de>
Date: Sat, 01 Nov 2014 17:58:54 +0100
From: Christian Franke <Christian DOT Franke AT t-online DOT de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26.1
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 1.7.33-0.4
References: <announce DOT 20141029120845 DOT GY20607 AT calimero DOT vinschen DOT de>
In-Reply-To: <announce.20141029120845.GY20607@calimero.vinschen.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes

Corinna Vinschen wrote:
> I just released a 4th TEST version of the next upcoming Cygwin release,
> 1.7.33-0.4.

There is an older regression in mkgroup.
A separator without a preceding domain name is printed for the builtin 
groups:

$ mkgroup -L THISHOST
SYSTEM:S-1-5-18:18:
TrustedInstaller:S-1-5-80-...
+Administratoren:S-1-5-32-544:544:
+Benutzer:S-1-5-32-545:545:
...
THISHOST+HelpLibraryUpdaters:S-1-5-21-...


Introduced in mkgroup.c CVS 1.54, April 2014:

@@ -415,8 +341,8 @@ enum_local_groups (...)
...
           printf ("%ls%s%ls:%s:%" PRIu32 ":\n",
-                 with_dom && !is_builtin ? domain_name : L"",
-                 with_dom && !is_builtin ? sep : "",
+                 mach->with_dom && !is_builtin ? domain_name : L"",
+                 mach->with_dom || is_builtin ? sep : "", <==== Hmm.... :-)


BTW: mkgroup should possibly also print the extra builtin groups which 
are now reported by getgroups(), for example 4(Interactive), 
11(Authenticated Users), ...
Groups with variable SIDs like LogonSession are an exception.

Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple