X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=oWxHY+2l2AFq65IxmzGD05ahtbGXVXijSdnMeQNLWOO
	oSIpL9cHf9SYi4Mr3nkwlUUsI8p/1JkZtm1oUal+d5PGJWipil7TOffokzmTFS1J
	RA0Wlw4d1sZdTAFZwPIC21U0xNmaox0zZoiduJHCrx3DV9b0IWBqS9hWrWplMeto
	=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 s=default; bh=EF7PGPMEkTjTE28EHX+djqxr5UY=; b=XvmJp8UsRsu/gjzdm
	I/N4ccYflaflx79xFCh3TQnhkIvB9WU+4Ty6rabgAHb4dhbFyUOOtsAPvkpeHAVo
	FlUOWrUbSYqsWLa8ZQXjzpb0PMrY1ttIpLmjDVz1/HNVwc8pN7CB4UTULFIlP0xd
	GrU05+5FvZyxAx8CO2Xd07lAMU=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: mail6.worldispnetwork.com
Message-ID: <5374B8EA.5080801@shaddybaddah.name>
Date: Thu, 15 May 2014 22:54:02 +1000
From: Shaddy Baddah <lithium-cygwin AT shaddybaddah DOT name>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Icedove/24.4.0
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: screen on 64-bit mangles mintty/buffer
References: <5370E144 DOT 4010905 AT shaddybaddah DOT name> <90t1n9l4g51dgrq060rc6ua48eog4178v8 AT 4ax DOT com> <5373AF2E DOT 5090402 AT shaddybaddah DOT name> <20140515071745 DOT GI2436 AT calimero DOT vinschen DOT de>
In-Reply-To: <20140515071745.GI2436@calimero.vinschen.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes

Hi Corinna,


On 2014-05-15 17:17+1000, Corinna Vinschen wrote:
>
>
> Nice detective work, really.  The goldstar is well deservered :)
>
> On May 15 04:00, Shaddy Baddah wrote:
>> I quickly worked out that the code has a bug for "%i". At some point
>> the code was changed to push and pop the parameters being passed (0 and
>> 39 in my eg.). However, the "%i" select/case block was incrementing the
>> arguments in a no longer used array for parameters:
>>
>>
>> 	    case 'i':
>> 		if (p_is_s[0] == 0)
>> 		    param[0]++;
>> 		if (p_is_s[1] == 0)
>> 		    param[1]++;
>> 		break;
>
> Unfortunately there's no newer upstream release and this bug is present
> in the ncurses 5.9 version in Fedora 20 as well.  From what I gather from the
> surrounding code, I *assume* something like this could fix it
>
>              case 'i':
>                  y = npop();
>                  x = npop();
>                  if (p_is_s[0] == 0)
>                      y++;
>                  if (p_is_s[1] == 0)
>                      x++;
>                  npush(x);
>                  npush(y);
>                  break;
>
> I'm not sure the relation between x, y, and the p_is_s indices is
> correct, though.

Yes, that's the code that I thought of as well, and same, I'd have to
get my head around the exact order of p_is_s (unfortunate name), etc.

When you say the bug is present in ncurses 5.9, is there any application
that is directly affected? I ask as screen being affected was sort of a
fluke. It's configure script should have detected terminfo notation was
available for use, and used the equivalent entry for "cs".

So I'm wondering if there are many applications still out there that are
trying to use the older, more terse termcap form? And also linking in
with ncurses?

Seems unlikely, as I would have expected that if there were, and any
were using a cap entry with "%i" that there would have been obvious
presentation problems.

-- 
Regards.
Shaddy


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple