DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=OPCAk6icfLho6Ugu6EpA2l+vh0gbkFTpJl2xhRmvcvwN4WxDS3kKh
	NxTw+z+vZdu3rAqi1xiCA69MiDMlZh4m6MVHATCmkHUNlC3MxXdP7LegTldaXsiE
	5oN8VD8veSdJphEc0WWvwmX5c7Zb/3lGnnXK3b9U8OdHffasRslA9I=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Sat, 29 Mar 2014 15:29:28 -0400
From: Christopher Faylor <cgf-use-the-mailinglist-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Public key authorization problem with latest snapshot
Message-ID: <20140329192928.GB4316@ednor.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <5329B9D0 DOT 6070703 AT cornell DOT edu> <20140319160914 DOT GD2715 AT calimero DOT vinschen DOT de> <5329C9EF DOT 1000305 AT cornell DOT edu> <20140319170508 DOT GF2715 AT calimero DOT vinschen DOT de> <885290127 DOT 20140320015843 AT yandex DOT ru> <20140320150258 DOT GD3729 AT calimero DOT vinschen DOT de> <5336F3E3 DOT 5000402 AT cornell DOT edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5336F3E3.5000402@cornell.edu>
User-Agent: Mutt/1.5.20 (2009-06-14)

On Sat, Mar 29, 2014 at 12:25:07PM -0400, Ken Brown wrote:
>On 3/20/2014 11:02 AM, Corinna Vinschen wrote:
>> On Mar 20 01:58, Andrey Repin wrote:
>>> Greetings, Corinna Vinschen!
>>>
>>>> The code is now practically equivalent to what is in 1.7.28.  Only the
>>>> VectoredContinueHandler, which was the reason Cygwin's exception handler
>>>> could be called twice, is not called anymore.  Instead there's a vectored
>>>> exception handler which is only called during debugging.
>>>
>>>> Before:
>>>
>>>>    if (!handler_installed)
>>>>      {
>>>>        handler_installed = true;
>>>>        SetUnhandledExceptionFilter (handle);
>>>>        AddVectoredContinueHandler (1, handle);
>>>>      }
>>>
>>>> After:
>>>
>>>>    if (!handler_installed)
>>>>      {
>>>>        handler_installed = true;
>>>>        SetUnhandledExceptionFilter (handle);
>>>>        AddVectoredExceptionHandler (1, handle_while_being_debugged);
>>>>      }
>>>
>>>> If anybody can explain this weird behaviour, please educate me.
>>>
>>> I can't explain the behavior, but I could say, that setting
>>> "handler_installed = true;" before the handler is actually installed is not
>>> quite right.
>>> Unless that variable is used inside either of two functions called afterward,
>>> I would move it down to the end of `if' block.
>>
>> BTDT.  This isn't the problem.  I *may* have found the culprit today,
>> but I ripped apart a lot of the code so I'm not really sure yet.  Stay
>> tuned.
>
>The problems I've reported seem to all be fixed in the latest snapshot 
>(2014-03-29 15:21:43 UTC).  Thanks!

I'm sure Corinna will be happy to hear that.  She put in LONG hours
getting that issue sorted out.

I helped too, of course, by offering important "I don't like that
implementation" style feedback.  It was one of those 50/50 collaborations
where one person does all the work and the other person mentions it on
a mailing list.

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple