X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:references :in-reply-to:content-type:content-transfer-encoding :mime-version; q=dns; s=default; b=rjurtElnEQ1ctmXfmygv4bBDPEBxb 5T2HQ7W5ntHW1nNxCFl1M/UHJ1xb5Lu6aS4LnUDX4gSyuQ80n1vbwveYbqXbO3R0 3J8Dqvkt5y/a4ENOtQAsuRVzmky21nwB6+XB8ilyy+BEJt72AUxPrtxRfRNJqyGy J7IuTxhXdeTuio= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:references :in-reply-to:content-type:content-transfer-encoding :mime-version; s=default; bh=w5kzzgT3fgjBNWJkLR1jq+iMwbA=; b=FTR LsRfsp53v44DPmy5QMNyW3pMmUEMvs4426ofPutgxZbgOak8ULJ6PkEqLht70m18 T2dwX0DHmyQb9zynBA2XmJw5krv/QPGzSN7WRPbuIyB6fjCNoSAdINb1dFbSPXu1 l1VYIyyzbGxZ0+gsnOHZU1N/oCvpZWo8nxgOp11I= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: gwo3.mbox.net X-USANET-Received: from gwo3.mbox.net [127.0.0.1] by gwo3.mbox.net via mtad (C8.MAIN.3.82G) with ESMTP id 380sBFXdE3360Mo3; Thu, 06 Feb 2014 23:29:30 -0000 X-USANET-Routed: 5 gwsout-gwsd Q:gwsd X-USANET-Routed: 3 gwsout-vs Q:bmvirus X-USANET-GWS2-Tenant: nwea.org X-USANET-GWS2-Tagid: NWEA X-USANET-Source: 165.212.120.254 OUT jim DOT garrison AT nwea DOT org S1P5HUB4.EXCHPROD.USA.NET TLS X-USANET-MsgId: XID580sBFXdE4550Xo3 From: Jim Garrison To: "cygwin AT cygwin DOT com" Subject: RE: qsort_r and libc.a version? Date: Thu, 6 Feb 2014 23:29:13 +0000 Message-ID: <0C723FEB5B4E5642B25B451BA57E27307514FBE4@S1P5DAG3C.EXCHPROD.USA.NET> References: <0C723FEB5B4E5642B25B451BA57E27307514F78A AT S1P5DAG3C DOT EXCHPROD DOT USA DOT NET> <52F3E4DA DOT 40002 AT cygwin DOT com> In-Reply-To: <52F3E4DA.40002@cygwin.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-IsSubscribed: yes Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id s16NToPx025272 > -----Original Message----- > Behalf Of Larry Hall (Cygwin) > Sent: Thursday, February 06, 2014 11:39 AM > Subject: Re: qsort_r and libc.a version? > > On 2/6/2014 2:04 PM, Jim Garrison wrote: > > I tried to build libgit2 so I could try to build gitg but encountered > > > > undefined reference to `qsort_r' > > > > GitHub has a closed issue for this > > https://github.com/libgit2/libgit2/issues/1606 saying that qsort_r was > > added to glibc in version 2.8, released in 2008. > > > > Since libc in Cygwin is part of the base package, how would I find out > > which upstream version it's based on? > > Cygwin uses newlib for its C library. From what I can see, qsort is there but > qsort_r isn't. > > > There was a commit in libgit2 that was supposed to fix this : > > > > > https://github.com/libgit2/libgit2/commit/0d77647adc1f76df66e437e6442d > > 7f7706e2c38e#diff-bb2cd4651768482b99cb1c52d29ceffdR694 > > > > but I don't know enough about Cygwin internals to determine why it > > still fails on Cygwin. > > The problem with that patch is that it doesn't take Cygwin into account. > If you append a check for Cygwin there as well (i.e. defined(__CYGWIN__) ) > then that should resolve the compile issue. > > -- > Larry So the correct patch for this would be to treat __CYGWIN__ the same as __MINGW32__ and use the internal git__insertsort_r function? -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple