DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type; q=dns; s=default; b=D1Qpit
	KrK4mv1SP8JU90cTiTP05VAxhoBPP4DliLw/OO935KRPfumTbEnTLQhhqlCdmjHN
	4fgoup7Dk7f98y6U0KXWdoLvKnLLUQRKXlVdfPP0MM/7kV4d6bNHNMlJXepOLYyx
	88HXwz1GzNTcbI7knzxh3NFDBJaBwSmTxOtd0=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Message-ID: <5299867E.2080301@tiscali.co.uk>
Date: Sat, 30 Nov 2013 06:32:30 +0000
From: David Stacey <drstacey AT tiscali DOT co DOT uk>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: [PATCH] 'rebase' uninitialised variable (was: Cygwin64: Rebase problems)
References: <5274DCA9 DOT 7020408 AT tiscali DOT co DOT uk>
In-Reply-To: <5274DCA9.7020408@tiscali.co.uk>
Content-Type: multipart/mixed; boundary="------------080503080208090709030606"

--------------080503080208090709030606
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 02/11/2013 11:06, David Stacey wrote:
> I'm trying to reinstall 64-bit Cygwin, using a snapshot taken on 
> 2013-10-24. The post-install step goes into an infinite loop whilst 
> running 'texlive-collection-basic.sh': perl is attempting to load some 
> modules (IO.dll, MD5.dll, Fcnt.dll, Cwd.dll), which fail with rebase 
> errors. The script waits five seconds before trying (and failing) 
> again; this repeats ad infinitum.

I am pleased to report that I have tracked down the cause of my rebase 
woes to an uninitialised variable in the 'rebase' package. A simple 
patch (attached) fixes the problem.

Jason Tishler: As rebase maintainer, if you agree with my diagnosis then 
please could you make new versions of 'rebase' containing the fix for 
both architectures. Thank you.

Dave.


--------------080503080208090709030606
Content-Type: text/plain; charset=windows-1252;
 name="rebase-4.4.0.1-1.src.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="rebase-4.4.0.1-1.src.patch"

--- origsrc/rebase/rebase.c	2013-03-19 17:33:54.000000000 +0000
+++ src/rebase/rebase.c	2013-11-29 18:32:08.760089000 +0000
@@ -861,6 +861,7 @@ collect_image_info (const char *pathname
   img_info_list[img_info_size].slot_size
     = roundup2 (img_info_list[img_info_size].size, ALLOCATION_SLOT);
   img_info_list[img_info_size].flag.needs_rebasing = 1;
+  img_info_list[img_info_size].flag.cannot_rebase = 0;
   /* This back and forth from POSIX to Win32 is a way to get a full path
      more thoroughly.  For instance, the difference between /bin and
      /usr/bin will be eliminated. */


--------------080503080208090709030606
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--------------080503080208090709030606--