DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=b3LOXm2BogwnleysBgfuy7FG8MFgW3gZFLHXb5aRBwZlpnTxFRClp
	SoBGb170eUaJYvL6fwcRryBrhWyYQAV3yaaJXJmxiE5gPk6JTRJOvq4WxFPBTF75
	Dg4zOF9MS+IczbK23ovqCczJ5IfZ7+WPvbCPG1dcTZwvNiZRIya6p4=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Tue, 19 Nov 2013 11:03:43 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: cygcheck -svc segfaults on Windows 8.1 with cygwin64
Message-ID: <20131119100343.GA27525@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <1384839303 DOT 14356 DOT YahooMailNeo AT web125203 DOT mail DOT ne1 DOT yahoo DOT com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk"
Content-Disposition: inline
In-Reply-To: <1384839303.14356.YahooMailNeo@web125203.mail.ne1.yahoo.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

--qDbXVdCdHGoSgWSk
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Nov 18 21:35, Gabriel Marcano wrote:
> cygcheck -svc causes a segfault on Windows 8.1 on line 1610 of cygcheck.c=
c, based on gdb output. I'm including some gdb output below that showcases =
this issue:
>=20
>=20
> 1610=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 strcat (osname, products[prod=
]);
> (gdb) list
> 1605=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (prod =3D=3D PRODUCT_UNLICENSED)
> 1606=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 strcat (osname, "Unlicensed");
> 1607=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else if (prod > PRODUCT_PROFESSIONAL_WMC)
> 1608=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 strcat (osname, "");
> 1609=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else
> 1610=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 strcat (osname, products[prod=
]);
> 1611=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 }
> 1612=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 else
> 1613=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 {
> 1614=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 }
> (gdb) p prod
> $1 =3D 101
> (gdb) p sizeof(products)/sizeof(void*)
> $2 =3D 101
>=20
>=20
> 'products[prod]' in this case is accessing memory outside of the
> 'products' array. The odd thing is that a few lines back, the
> declaration of products includes 104 elements. I do not know why this
> discrepancy exists-- anyone have a clue?

Yes.  The size of the array is not what you think it is.  The reason is
that several commas are missing.  Since I created this array, it's all
my fault :}  I didn't notice this because I'm using the Enterprise
version which have a product value 4, which is pretty safe.

I'm going to fix this in CVS today, but at the same time I'm also going
to look for a solution to differ between Windows 8 and 8.1 (also 2012
vs. 2012R2) in the cygcheck output.  Right now cygcheck just prints
Windows 8.


Thanks for the report,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--qDbXVdCdHGoSgWSk
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIcBAEBAgAGBQJSizd/AAoJEPU2Bp2uRE+gNWAQAIq/R9Ag+u0xbqy9TjPIlbSH
ETCwjSpfSLGV3jLAnL68Yb9cXGWxjoQLJmRoHbJRpyQKTqDqxeB17F6Sf//JC3bY
8bA+JcbALsE7bT/UjJ4tbYUeLQ8t6YNgLo6Vata4XcsW4KNWiybpuAogf/qgW64r
v/H3v14IiZPP4wzjwX0fT7xqz1g9YjchLrMU5Degun4/DLveMkh1VvM4zuVyAVqM
rZXd5dbWHKqzPnCIvRrSmtU2wmn+b11oLMm7Hu7qx8QSDHwnJ85ASLEhxxxueZpU
UWqK3D+JTdORj+iyDuLTVB/cKkk1e7LSpXfRkPOTXDJiHD+uz/xMqRgzTAHq+tF/
tyQQnVeoscp4HE24a3bFuGwV4Mr7RzPkoWGZS3pTGT/cD4ff28xekXYJ5sxb4+mi
dCnNzDgS6TFbRyLxw+iIKXRwuTabn53GA+q8ORG6AwMN874R4W9W9+EjIQU/f5nN
etYkGeS9zcyO6EnRlf8z3oJPTJh/+86GYMKTuoQ4hSKub17eeWnXY3yfdq9yEr+P
mz8ZPpx6jyj6WN1Rq1MA+SZ4Ih928WhLvppNkC3C5dH6fBkariXsj1HRzkC25Yki
7oPDHyBSRc6hXr484+o/2AmBxqPIbPRAGLduU69kB4Q7bWLOFyklY5hy0ZjXYAIe
2m+AwypHSoEAcqDukcWz
=Krtk
-----END PGP SIGNATURE-----

--qDbXVdCdHGoSgWSk--