X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; q=dns; s= default; b=pd226e9KE/Jd8O18b2bzsN6S6rHKmnbLpCMTTEQZGqXsJJ2BQBn1A OXcsX3x/lLM1+NOuRXXWUp3kj5il7xc2jAg6jtIoOaXeADyDC4sNiAwD10NfPxPj DIm7LaxGnbuWbtNqJUsccsP5W+JR6R24weBJTHVPj2IBEeHPHH4Md4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:reply-to :references:mime-version:content-type:in-reply-to; s=default; bh=om3ENfyyO0YlM9/Xocxi1tqnv/Q=; b=Ol6N3K7/+USFu413Cdl+mwGvC8V0 KRb9OP47Yi4Gl756TV9rM7I+vBkYMvUoWMxgX1UjHDMh34rrD1JllL7FZ0JVWgtA nDdxMrJtNhin1sTgc3TKsK2Tya0ajbTRXXEDqgZWCwCA292uTZWOz1ntZkaBE1w9 cAeXiMNODIyqCUo= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: calimero.vinschen.de Date: Sun, 27 Oct 2013 10:51:59 +0100 From: Corinna Vinschen To: cygwin AT cygwin DOT com Subject: Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror] Message-ID: <20131027095159.GA29907@calimero.vinschen.de> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <52692BAC DOT 5060800 AT mandriva DOT com> <20131024150921 DOT GB24229 AT calimero DOT vinschen DOT de> <20131026062530 DOT GA5850 AT ednor DOT casa DOT cgf DOT cx> <20131026094704 DOT GA15394 AT calimero DOT vinschen DOT de> <20131027012705 DOT GA1534 AT ednor DOT casa DOT cgf DOT cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <20131027012705.GA1534@ednor.casa.cgf.cx> User-Agent: Mutt/1.5.21 (2010-09-15) --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Oct 26 21:27, Christopher Faylor wrote: > On Sat, Oct 26, 2013 at 11:47:04AM +0200, Corinna Vinschen wrote: > >On Oct 26 02:25, Christopher Faylor wrote: > >> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote: > >> >/usr/include/w32api/winnt.h:3541:20: error: previous definition of > >> >?struct _EXCEPTION_REGISTRATION_RECORD? > >> > typedef struct _EXCEPTION_REGISTRATION_RECORD { > >> > ^ > >> >In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0, > >> > from /work/Cygwin/winsup/cygwin/cygtls.cc:20: > >> >/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid > >> >type in declaration before ?;? token > >> > } exception_list; > >> > ^ > >> >/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target > >> >'cygtls.o' failed > >> >make[3]: *** [cygtls.o] Error 1 > >>=20 > >> Feel free to provide patches. Simple compilation issues do not > >> require copyright assignment. > > > >I applied a patch. The redefinition of _exception_list to > >_EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early > >"just build, goddammit" porting stage. Later on it turned out that > >x86_64 doesn't use frame based exception handling anyway so all the > >code using _exception_list is unused on x86_64 anyway. > > > >I also changed the public header so that it only > >applies if !x86_64. > > > >That leads to a question: > > > >Why on earth do we have a *public* header exposing the exception > >handling on a certain CPU? This isn't a standard header, neither POSIX > >nor Linux nor BSD systems have it. > > > >If there isn't a compelling reason to keep the header, I would opt > >for folding the content into the private Cygwin header exception.h > >and drop the public header entirely. >=20 > I think its existence predates me. I vote to nuke it. 2 pro votes, 0 dissenting votes. Done. I just hope the voting period wasn't too short... Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJSbOI/AAoJEPU2Bp2uRE+gaXEQAID8YlgncvxpAfcssXJHvsHH 616zvNSD/tJTgRvtekKOSKQhz16STUr58m8OWeEG5iUiDXVh+vxhCPOeX4n6SnYy InJLrxojUWw9zM1aLhvtqb013CrGRGBKoRSnx4bQVvpnPX7AfNuroR/i2GkoQBk8 klxWk5ye3bb1v9ghZw5cSGFhwL8xE1o+xT1kp2uiB74lEii8Ovd+FpMD7mYeF+6H IcFeqgTkOin/aPoF5dUItPE6ARs84VgFvpIBLb2CpOgM7zj5GGYIMIA7ISnFtqSD pOn9RzyaSyRCZim+WrdXjbP0/Blr5w1hH3G9OPbrbSBaYdcBsXh63r5GYjxnYaDk 0fhCdUw7x2whtzNkgwdwIWGx2zH++LnF5c+TjrdI1c1jHho5aiGI58ObXsu4ST/4 XAvhH/G+fUHZ/wsVh8W1imjngwwuTY84idpgSPtN2Abwv4GU0wjmnfkcBEcWhSqV aYJkmFgTxzGUKfAoCa6S5wAyfPJ/agvKkJFcGM7gtdjqwpaDbTNOo+ptGhaeBOp2 FTzDDNdNVWr4awZ19+bj8pYxeLWwcjW/yIMfkpTxFpEMgD77yP7nyBe/4EPf3W1j FObwCcc8zNz6Ej5jzA3mYxjqmTxhKxdsW5KYnxgyiERFFJkQCSADv9QQpRti8luJ 3NmwTj4rcvc7QI3FpB7P =Pq4d -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--