X-Recipient: archive-cygwin AT delorie DOT com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; q=dns; s=default; b=H/hB3tMXsPR/WS75SNXc4ArnO07JQZ/SYTPuRV1g9pX 5eio4p7uiD5pRzYlXSZ2yGo5YJaCYP3VH7A1/T1ob2v82TI33rRsVuUj7SZ3hh+U pMR+OaiNHfDyGwOdh6iyLRuNcGlbOCvVMM7mr9hErwfYP06m/UCmwSMQRFpVJLZg = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; s=default; bh=xDdSiDGnOxk+UJVzWWufZRWiKS8=; b=Y+8ucbAVcxU9Et3Jl gywKthK9+ZDwN/BAYFNib+ZPgn7AwWQTNrtmKRvZNQnnEiT5LuJBhIqiC2DHUUk+ z0Cn/+LFlZFCQl/4KQ7uLf7wc0u2fBCXD4sNgpX7Er4fPba+VzoVL6R6+FrD99GP GjHP4dJLg6FumJ8r3wwLbUUxdM= Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Message-ID: <51F5B2F2.9090508@cwilson.fastmail.fm> Date: Sun, 28 Jul 2013 20:10:26 -0400 From: Charles Wilson User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: cygwin AT cygwin DOT com Subject: Re: setup-x86_64: postinstall errors: Package bash 1, Package a2ps 2 and xinit 134 References: <51EE0951 DOT 90007 AT users DOT sourceforge DOT net> <51EEC7F2 DOT 5000402 AT cwilson DOT fastmail DOT fm> <20130723184615 DOT GK9689 AT calimero DOT vinschen DOT de> <51EED4B4 DOT 7000908 AT cwilson DOT fastmail DOT fm> <20130723192342 DOT GM9689 AT calimero DOT vinschen DOT de> <51EFD0EB DOT 6030804 AT cwilson DOT fastmail DOT fm> <1358868658 DOT 20130724173406 AT mtu-net DOT ru> <51F59159 DOT 6050005 AT dronecode DOT org DOT uk> In-Reply-To: <51F59159.6050005@dronecode.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 7/28/2013 5:47 PM, Jon TURNEY wrote: > On 25/07/2013 05:24, Kenneth Wolcott wrote: >> I downloaded a fresh setup-x86_64.exe from cygwin.com and then ran >> the update again. >> >> Now I get only this postinstall error: >> >> Package: xinit >> xinit.sh exit code 134 > I can reproduce this problem, so I had a go at investigating and fixing it. > > mkshortcut appears to exiting with SIGABRT in free(), which suggests some heap > corruption, which I managed to track down after a bit of work with dmalloc. > > This appears to be a long standing bug, which for some reason manifests itself > more severely on x86_64. > > xstrncat() does not allow for the terminating null byte in the memory > allocation it makes. strncat(dest, src, n) writes n+1 bytes to dest (n from > src plus the terminating null byte, which is always appended). So, the size > of dest must be at least strlen(dest)+n+1. Currently only strlen(dest)+n > bytes are allocated. > > Trivial patch attached. Thanks, Jon. I'll roll a new release of cygutils immediately for both x86 and x86_64. -- Chuck -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple