X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type; q=dns; s=default; b=
	PcdnXGqfMpEnYhWarVS8SvrMd2wvZTE5UkVKxO+jsCFfuSV5bEN4l0VYEuTqPJly
	ScGIh4BljQzH/2rTPNRhGgpvegFQy0JupTaSNfph7WCFfRSnd7IDFR6AdPAyKvgT
	t+aODQhNDlqun9MCnc3B83kiNIeRACjkoh7kUaeUv9g=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type; s=default; bh=Cp4Ym
	ocHNtowfCjC3O8GyQOIoew=; b=RLYsBUPsb0m5XqM834iOgIg0C8HUZGhvQDVZ5
	KabsBqMbV8UigOzNoQhHFQytRfzYA/nx2KZ9iUVbpYY9C6cAYDZdZd1mmjMeb1BV
	oJP6/s54nvHvt5grK11B/GOngEhMl+HU+wj54tuTB+8u7TnPI2Irfo60UJ0OACH/
	MBSG7U=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1
MIME-Version: 1.0
X-Received: by 10.152.22.130 with SMTP id d2mr16065851laf.33.1372840968226; Wed, 03 Jul 2013 01:42:48 -0700 (PDT)
In-Reply-To: <20130702161048.12696.qmail@sourceware.org>
References: <20130702161048 DOT 12696 DOT qmail AT sourceware DOT org>
Date: Wed, 3 Jul 2013 10:42:48 +0200
Message-ID: <CAKw7uVgUv1OU5h6-uuU=wwaNTuDHLin2WxAwHmFzLAxZoYbUCA@mail.gmail.com>
Subject: Re: setup ChangeLog win32.h
From: =?UTF-8?Q?V=C3=A1clav_Zeman?= <vhaisman AT gmail DOT com>
To: corinna AT sourceware DOT org
Cc: cygwin AT cygwin DOT com
Content-Type: text/plain; charset=UTF-8

On 2 July 2013 18:10,  wrote:
>
> CVSROOT:        /cvs/cygwin-apps
> Module name:    setup
> Changes by:     XXXX  2013-07-02 16:10:48
>
> Modified files:
>         .              : ChangeLog win32.h
>
> Log message:
>         * win32.h (struct acl_t): Make sure struct is 4 byte aligned.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/setup/ChangeLog.diff?cvsroot=cygwin-apps&r1=2.807&r2=2.808
> http://sourceware.org/cgi-bin/cvsweb.cgi/setup/win32.h.diff?cvsroot=cygwin-apps&r1=2.29&r2=2.30
>
Why not using the union trick?

 struct acl_t {
  union {
    LONG __align; /* Make sure &acl is 4-byte aligned. */
    ACL acl;
  };
  char aclbuf[TOKEN_ACL_SIZE (7)];
 };

Same effect, AFAIK, and no size overhead.

--
VZ

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple